Your message dated Fri, 10 Jun 2011 17:32:10 +0000
with message-id <[email protected]>
and subject line Bug#614068: fixed in dump 0.4b44-1
has caused the Debian Bug report #614068,
regarding Dump fails to dump some files with leading zeros correctly
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
614068: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=614068
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dump
Version: 0.4b43-1
Severity: important
Tags: upstream patch
einstein:~# /sbin/dump -0 -f- /var/spool/news/overview/ | restore -oax -f-
DUMP: Date of this level 0 dump: Sat Feb 19 13:27:45 2011
DUMP: Dumping /dev/mapper/vg0-var (/var (dir /spool/news/overview)) to
standard output
DUMP: Label: none
DUMP: Writing 10 Kilobyte records
DUMP: mapping (Pass I) [regular files]
DUMP: mapping (Pass II) [directories]
DUMP: estimated 23168 blocks.
DUMP: Volume 1 started with block 1 at: Sat Feb 19 13:27:46 2011
DUMP: dumping (Pass III) [directories]
DUMP: dumping (Pass IV) [regular files]
Missing blocks at the end of ./spool/news/overview/f/l/k/fa.linux.kernel.IDX,
assuming hole
Missing blocks at the end of ./spool/news/overview/u/t/uk.test.IDX, assuming
hole
...
Missing blocks at the end of ./spool/news/overview/c/t/t/comp.text.tex.IDX,
assuming hole
DUMP: Volume 1 completed at: Sat Feb 19 13:27:49 2011
DUMP: Volume 1 23040 blocks (22.50MB)
DUMP: Volume 1 took 0:00:03
DUMP: Volume 1 transfer rate: 7680 kB/s
DUMP: 23040 blocks (22.50MB)
DUMP: finished in 3 seconds, throughput 7680 kBytes/sec
DUMP: Date of this level 0 dump: Sat Feb 19 13:27:45 2011
DUMP: Date this dump completed: Sat Feb 19 13:27:49 2011
DUMP: Average transfer rate: 7680 kB/s
DUMP: DUMP IS DONE
einstein:~#
Problem is in version 1.67 of dump/traverse.c in the upstream code.
Backing out this one change fixes the problem.
diff -u -w -r1.67 -r1.66
--- traverse.c 18 Jun 2009 10:00:38 -0000 1.67
+++ traverse.c 2 May 2005 15:10:46 -0000 1.66
@@ -777,6 +777,8 @@
struct block_context *p;
e2_blkcnt_t i;
+ if (blockcnt < NDADDR)
+ return 0;
p = (struct block_context *)private;
for (i = p->next_block; i < blockcnt; i++) {
p->buf[p->cnt++] = 0;
@@ -984,6 +986,19 @@
msg("Warning: undefined file type 0%o\n", dp->di_mode & IFMT);
return;
}
+ if (i_size > (u_quad_t)NDADDR * sblock->fs_bsize)
+#ifdef __linux__
+ cnt = NDADDR * EXT2_FRAGS_PER_BLOCK(fs->super);
+#else
+ cnt = NDADDR * sblock->fs_frag;
+#endif
+ else
+ cnt = howmany(i_size, sblock->fs_fsize);
+ blksout(&dp->di_db[0], cnt, ino);
+ if ((quad_t) (size = i_size - NDADDR * sblock->fs_bsize) <= 0) {
+ dump_xattr(ino, dp);
+ return;
+ }
#ifdef __linux__
bc.max = NINDIR(sblock) * EXT2_FRAGS_PER_BLOCK(fs->super);
bc.buf = (int *)malloc (bc.max * sizeof (int));
@@ -991,7 +1006,7 @@
bc.ino = ino;
bc.next_block = NDADDR;
- ext2fs_block_iterate2(fs, (ext2_ino_t)ino, BLOCK_FLAG_DATA_ONLY, NULL,
dumponeblock, (void *)&bc);
+ ext2fs_block_iterate2(fs, (ext2_ino_t)ino, 0, NULL, dumponeblock, (void
*)&bc);
/* deal with holes at the end of the inode */
if (i_size > ((u_quad_t)bc.next_block) * sblock->fs_fsize) {
remaining = i_size - ((u_quad_t)bc.next_block) *
sblock->fs_fsize;
@@ -1009,15 +1024,6 @@
free(bc.buf);
dump_xattr(ino, dp);
#else
- if (i_size > (u_quad_t)NDADDR * sblock->fs_bsize)
- cnt = NDADDR * sblock->fs_frag;
- else
- cnt = howmany(i_size, sblock->fs_fsize);
- blksout(&dp->di_db[0], cnt, ino);
- if ((quad_t) (size = i_size - NDADDR * sblock->fs_bsize) <= 0) {
- dump_xattr(ino, dp);
- return;
- }
for (ind_level = 0; ind_level < NIADDR; ind_level++) {
dmpindir(ino, dp->di_ib[ind_level], ind_level, &size);
if (size <= 0)
Bug has already been reported upstream:
http://sourceforge.net/tracker/?func=detail&aid=3133762&group_id=1306&atid=101306
-- System Information:
Debian Release: 6.0
APT prefers stable
APT policy: (990, 'stable')
Architecture: i386 (i686)
Kernel: Linux 2.6.32-5-686 (SMP w/1 CPU core)
Locale: LANG=en_GB, LC_CTYPE=en_GB (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/bash
Versions of packages dump depends on:
ii e2fslibs 1.41.12-2 ext2/ext3/ext4 file system librari
ii libblkid1 2.17.2-9 block device id library
ii libc6 2.11.2-10 Embedded GNU C Library: Shared lib
ii libcomerr2 1.41.12-2 common error description library
ii libncurses5 5.7+20100313-5 shared libraries for terminal hand
ii libreadline6 6.1-3 GNU readline and history libraries
ii libselinux1 2.0.96-1 SELinux runtime shared libraries
ii libuuid1 2.17.2-9 Universally Unique ID library
ii tar 1.23-3 GNU version of the tar archiving u
dump recommends no packages.
dump suggests no packages.
-- debconf information:
dump/dumpdates_is_a_symlink:
dump/moving_from_etc_to_var:
--- End Message ---
--- Begin Message ---
Source: dump
Source-Version: 0.4b44-1
We believe that the bug you reported is fixed in the latest version of
dump, which is due to be installed in the Debian FTP archive:
dump_0.4b44-1.debian.tar.gz
to main/d/dump/dump_0.4b44-1.debian.tar.gz
dump_0.4b44-1.dsc
to main/d/dump/dump_0.4b44-1.dsc
dump_0.4b44-1_i386.deb
to main/d/dump/dump_0.4b44-1_i386.deb
dump_0.4b44.orig.tar.gz
to main/d/dump/dump_0.4b44.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bdale Garbee <[email protected]> (supplier of updated dump package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 10 Jun 2011 11:06:30 -0600
Source: dump
Binary: dump
Architecture: source i386
Version: 0.4b44-1
Distribution: unstable
Urgency: low
Maintainer: Bdale Garbee <[email protected]>
Changed-By: Bdale Garbee <[email protected]>
Description:
dump - 4.4bsd dump and restore for ext2 filesystems
Closes: 583093 614068 622350 629831
Changes:
dump (0.4b44-1) unstable; urgency=low
.
* new upstream version, closes: #583093, #614068, #622350, #629831
* add pkg-config as a build dependency
* update to newer source package format
* work around com_err not showing up in EXT2FS_LIBS with pass to configure
* update lintian overrides related to static linking of compression libs
* add Vcs entries to the control file
Checksums-Sha1:
333600733d3322f0e886847ec9af7a3fb65311e0 1830 dump_0.4b44-1.dsc
9bef0f86095a9214045b44f5c78efa3fbebcfc58 296691 dump_0.4b44.orig.tar.gz
0a184a8bf457191c1296df1591e7b37c4e04f145 10423 dump_0.4b44-1.debian.tar.gz
eafb0b7d62f1b15747ab1f62155aba05580c4fe1 269272 dump_0.4b44-1_i386.deb
Checksums-Sha256:
4ad1ea5f7f7e22803801c50ef754d3c98a315bd63b4a11f3e595aaf78820bb92 1830
dump_0.4b44-1.dsc
78cb75632ac5e99dca38af3a2574303eee3c5a7af464011d279421d8b0e64f96 296691
dump_0.4b44.orig.tar.gz
898884ee8f9ad978c368d5858b89de1649d3479ee26e07ee95fc15fc2caec505 10423
dump_0.4b44-1.debian.tar.gz
5ff4e3ef98bcff24363de1b4f0b5727a4343e5efcd350f1185cdeff7947b19f3 269272
dump_0.4b44-1_i386.deb
Files:
48d89d27c68c6e5719c57b582d704938 1830 utils optional dump_0.4b44-1.dsc
daec97b1ad905c904eba926221f4be6d 296691 utils optional dump_0.4b44.orig.tar.gz
ad9c1ffab5c0e4c4e806735d9b45f5d1 10423 utils optional
dump_0.4b44-1.debian.tar.gz
7b699ff20bb31db7d49f44a9862c6ff7 269272 utils optional dump_0.4b44-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIVAwUBTfJTajqTYZbAldlBAQqrZQ/+L3PlrZ+3KxYCXoP/LP/xlkfgzsNjxuhs
O5mZk9JBbfCFUnzTp30DgivuJ5Qf4VhwzjfQWM0UDepfATLaxz0PD6USnqsrmFEW
eh9utc4k4G/Wr+7atT6AOT3oxQy6rGQ52Y4MKyBJw7pJEcAn7nw+i8sUn4RHND3Y
CNt2U6H0d38PkcKEA+leEjze+zrrbOqTjMcoXczYmOG4X8fSyeDfvSs8a1UtTTHU
DWZY0zLXO1GseY05yO1/CWBLn22ToIwTq+fzHArUKNLuDNIqdNgae9VMcdExoGll
0nW8o55wYit7uzxTJzKBpe4VC9NJCwA9B8iyC91wY8RJus9X8+9zEY16M9ujfA/t
NXvWQ36bJwqSESauCuaBrZL8jW/k/6OJyL2Rog6QOQlIn9k8Or2TagiSwlvxPNDW
nKxl4vmymFcCEZbUm3rDmCb45Mt1MVaZ78SxwKRa2Zh/iZqAZ9sV4tfEd0GeqxmQ
Z2+Bt8pSNa+46Kd6NaJmECszaZYIqwqJ7AZHt/Ym2S406vy5fyQoewfOIKlt8Yb3
4npWDXPjMN1j4q2ndeL+gBZprJ+NCAQx9HBhurXRqJ0K/b28OLYb6H3fSIYKtTI3
iptIibVYylMdgXngdbwuTTn7cA65L29G6M5788IH5ra9/5rOzEfbE5NusP59qXUW
H/rBNTG3aaA=
=1+ky
-----END PGP SIGNATURE-----
--- End Message ---
