Your message dated Fri, 18 May 2012 11:02:12 +0000
with message-id <[email protected]>
and subject line Bug#655891: fixed in dmidecode 2.11-8
has caused the Debian Bug report #655891,
regarding Please enabled hardened build flags
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
655891: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655891
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dmidecode
Version: 2.11-4
Severity: important
Tags: patch
Please enabled hardened build flags through dpkg-buildflags.
Patch attached. I needed to make additional changes to the
Makefile, since otherwise the flags configured in debian/rules
are overridden.
(dpkg-buildflags abides "noopt" from DEB_BUILD_OPTIONS)
Cheers,
Moritz
diff -aur dmidecode-2.11.harden/debian/rules dmidecode-2.11/debian/rules
--- dmidecode-2.11.harden/debian/rules 2011-10-28 21:53:58.000000000 +0200
+++ dmidecode-2.11/debian/rules 2012-01-14 17:04:08.000000000 +0100
@@ -1,6 +1,10 @@
#!/usr/bin/make -f
# Flags fetched from the upstream Makefile.
+
+CFLAGS = `dpkg-buildflags --get CFLAGS`
+CFLAGS += `dpkg-buildflags --get CPPFLAGS`
+
CFLAGS += -W -Wall -pedantic -Wshadow -Wstrict-prototypes -Wpointer-arith \
-Wcast-qual -Wcast-align -Wwrite-strings -Wmissing-prototypes -Winline -Wundef
@@ -10,11 +14,13 @@
# Dropped -ansi as it break building on ia64
CFLAGS += -ansi
+LDFLAGS = `dpkg-buildflags --get LDFLAGS`
+
%:
dh ${@}
override_dh_auto_build:
- dh_auto_build -- CFLAGS="$(CFLAGS)"
+ dh_auto_build -- CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)"
override_dh_auto_install:
dh_auto_install -- prefix=/usr
diff -aur dmidecode-2.11.harden/Makefile dmidecode-2.11/Makefile
--- dmidecode-2.11.harden/Makefile 2012-01-14 16:57:02.000000000 +0100
+++ dmidecode-2.11/Makefile 2012-01-14 17:01:46.000000000 +0100
@@ -13,17 +13,17 @@
#
CC = gcc
-CFLAGS = -W -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual \
- -Wcast-align -Wwrite-strings -Wmissing-prototypes -Winline -Wundef
+#CFLAGS = -W -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual \
+# -Wcast-align -Wwrite-strings -Wmissing-prototypes -Winline -Wundef
#CFLAGS += -DBIGENDIAN
#CFLAGS += -DALIGNMENT_WORKAROUND
# When debugging, disable -O2 and enable -g.
-CFLAGS += -O2
+#CFLAGS += -O2
#CFLAGS += -g
# Pass linker flags here
-LDFLAGS =
+#LDFLAGS =
DESTDIR =
prefix = /usr/local
--- End Message ---
--- Begin Message ---
Source: dmidecode
Source-Version: 2.11-8
We believe that the bug you reported is fixed in the latest version of
dmidecode, which is due to be installed in the Debian FTP archive:
dmidecode-udeb_2.11-8_i386.udeb
to main/d/dmidecode/dmidecode-udeb_2.11-8_i386.udeb
dmidecode_2.11-8.debian.tar.gz
to main/d/dmidecode/dmidecode_2.11-8.debian.tar.gz
dmidecode_2.11-8.dsc
to main/d/dmidecode/dmidecode_2.11-8.dsc
dmidecode_2.11-8_i386.deb
to main/d/dmidecode/dmidecode_2.11-8_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Baumann <[email protected]> (supplier of updated
dmidecode package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Fri, 18 May 2012 12:36:27 +0200
Source: dmidecode
Binary: dmidecode dmidecode-udeb
Architecture: source i386
Version: 2.11-8
Distribution: unstable
Urgency: low
Maintainer: Daniel Baumann <[email protected]>
Changed-By: Daniel Baumann <[email protected]>
Description:
dmidecode - SMBIOS/DMI table decoder
dmidecode-udeb - SMBIOS/DMI table decoder (udeb) (udeb)
Closes: 655891
Changes:
dmidecode (2.11-8) unstable; urgency=low
.
* Using package type instead of custom field for udeb package.
* Adding patch to escape hypens in manpage.
* Also passing cppflags to make (Closes: #655891).
Checksums-Sha1:
dce0c6ae72bf2bcbc6aa32dabfd4d783ff6e6bee 1169 dmidecode_2.11-8.dsc
32f22f3f06503fa985078d0f78da63c7267b4de6 11188 dmidecode_2.11-8.debian.tar.gz
45e80b163aac2ad9d1ff5fa29e98adaad808cf86 71064 dmidecode_2.11-8_i386.deb
724ffb46713944f7edbe8612c2f2ba16b48d747c 26908 dmidecode-udeb_2.11-8_i386.udeb
Checksums-Sha256:
7e3049671333092729c91b8f4942185dfb5b517ce48a7b41543422269bc025f8 1169
dmidecode_2.11-8.dsc
b354cfb3ee270906ce97ff752834f0dce0ba0b7fe68f9404f6172c68557cec62 11188
dmidecode_2.11-8.debian.tar.gz
781b2b4d03d7516604bd9117bebafd7e713d49ad4cdad1992f3d98003d5500d1 71064
dmidecode_2.11-8_i386.deb
00f303602d90d47966fd3e13c2b1520133d42870e689e0c84d69842a77bc2660 26908
dmidecode-udeb_2.11-8_i386.udeb
Files:
e24c9dc1c8c0eaa9d529af44a2809492 1169 utils optional dmidecode_2.11-8.dsc
1259c3643b5fe794d13f5428fa5a6753 11188 utils optional
dmidecode_2.11-8.debian.tar.gz
9d63277e65256a24dba160e913cb6654 71064 utils important
dmidecode_2.11-8_i386.deb
acad4dc3ef34227eb02a975582efd4c9 26908 debian-installer optional
dmidecode-udeb_2.11-8_i386.udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAk+2KI4ACgkQ+C5cwEsrK56DqgCgzNrwyoXRemKK7hkWUwRGqXZT
I3MAoJ+5/+YUaRf1Iux+49wrID6XaWWn
=+Nnk
-----END PGP SIGNATURE-----
--- End Message ---