Your message dated Fri, 18 May 2012 11:12:48 +0000
with message-id <[email protected]>
and subject line Bug#656014: fixed in traceroute 1:2.0.18-2
has caused the Debian Bug report #656014,
regarding Please enabled hardened build flags
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
656014: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=656014
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: traceroute
Version: 1:2.0.18-1
Severity: important
Tags: patch
Please enabled hardened build flags through dpkg-buildflags.
Patch attached. The hardened build flags exposed missing format
strings, for which I've attached a patch as well.
Cheers,
Moritz
diff -aur traceroute-2.0.18.harden/debian/rules traceroute-2.0.18/debian/rules
--- traceroute-2.0.18.harden/debian/rules 2011-08-28 20:08:01.000000000 +0200
+++ traceroute-2.0.18/debian/rules 2012-01-15 22:10:01.000000000 +0100
@@ -2,6 +2,9 @@
SHELL := sh -e
+DPKG_EXPORT_BUILDFLAGS = 1
+include /usr/share/dpkg/buildflags.mk
+
%:
dh ${@}
diff -aur traceroute-2.0.18.harden/Make.rules traceroute-2.0.18/Make.rules
--- traceroute-2.0.18.harden/Make.rules 2012-01-15 22:06:37.000000000 +0100
+++ traceroute-2.0.18/Make.rules 2012-01-15 22:10:29.000000000 +0100
@@ -46,9 +46,6 @@
$(call set, INDENT, true)
gcc = $(findstring gcc,$(CC))
-$(call set, CFLAGS, $(if $(gcc), -O2 -Wall, -O))
-$(call set, CPPFLAGS, )
-$(call set, LDFLAGS, -s)
$(call set, LIBS, )
Nur in traceroute-2.0.18: Make.rules~.
diff -aur traceroute-2.0.18.orig/libsupp/clif.c traceroute-2.0.18/libsupp/clif.c
--- traceroute-2.0.18.orig/libsupp/clif.c 2007-08-06 17:20:17.000000000 +0200
+++ traceroute-2.0.18/libsupp/clif.c 2012-01-15 22:29:52.000000000 +0100
@@ -792,9 +792,9 @@
if (l > 0) {
memset (buf, ' ', l);
buf[l] = '\0';
- fprintf (stderr, buf);
+ fprintf (stderr, "%s", buf);
} else
- fprintf (stderr, spacer);
+ fprintf (stderr, "%s", spacer);
endp = buf + width;
@@ -833,7 +833,7 @@
*p = '\0';
fprintf (stderr, "%s", buf);
- fprintf (stderr, spacer);
+ fprintf (stderr, "%s", spacer);
p++;
for (s = buf; *p; *s++ = *p++) ;
Nur in traceroute-2.0.18/libsupp: clif.c~.
--- End Message ---
--- Begin Message ---
Source: traceroute
Source-Version: 1:2.0.18-2
We believe that the bug you reported is fixed in the latest version of
traceroute, which is due to be installed in the Debian FTP archive:
traceroute_2.0.18-2.debian.tar.gz
to main/t/traceroute/traceroute_2.0.18-2.debian.tar.gz
traceroute_2.0.18-2.dsc
to main/t/traceroute/traceroute_2.0.18-2.dsc
traceroute_2.0.18-2_i386.deb
to main/t/traceroute/traceroute_2.0.18-2_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Baumann <[email protected]> (supplier of updated
traceroute package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Fri, 18 May 2012 12:53:18 +0200
Source: traceroute
Binary: traceroute
Architecture: source i386
Version: 1:2.0.18-2
Distribution: unstable
Urgency: low
Maintainer: Daniel Baumann <[email protected]>
Changed-By: Daniel Baumann <[email protected]>
Description:
traceroute - Traces the route taken by packets over an IPv4/IPv6 network
Closes: 656014
Changes:
traceroute (1:2.0.18-2) unstable; urgency=low
.
* Using compression level 9 also for binary packages.
* Updating package to standards version 3.9.3.
* Updating package to debhelper version 9.
* Adding patch to avoid overwriting build environment.
* Adding patch from Moritz Muehlenhoff <[email protected]> to add missing
format strings in order to build with hardening flags.
* Enabling hardening build flags (Closes: #656014).
* Updating copyright file to machine-readable format version 1.0.
Checksums-Sha1:
491354302d4f7b7688165485cf995a154c83b8cc 1112 traceroute_2.0.18-2.dsc
7d34c4cdfd3e29baede68398b4753d1675bf5fea 8223 traceroute_2.0.18-2.debian.tar.gz
8b6fb6915f6c859f69d9745dd5f23a329b67b038 61884 traceroute_2.0.18-2_i386.deb
Checksums-Sha256:
4e07cc2e129589f7bfcaeac649b7b00ed7a9e5a401c7bd43841b0a20caa03e97 1112
traceroute_2.0.18-2.dsc
900657aec7a58e85c5e79e7a46dc8cfc73196d0471e143d136313fd843dc0e93 8223
traceroute_2.0.18-2.debian.tar.gz
e838faf01ed5a5e0c1b5ac384ef01414124c7cb408a5ca2f34da711e056e94f4 61884
traceroute_2.0.18-2_i386.deb
Files:
f53707c96526b741e4bb5d59bcfaa164 1112 net important traceroute_2.0.18-2.dsc
472889d59f8f129f15d2652ba1107aad 8223 net important
traceroute_2.0.18-2.debian.tar.gz
cfbbec00fa251b7c4cbe31217fab469e 61884 net important
traceroute_2.0.18-2_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAk+2K0UACgkQ+C5cwEsrK54s5wCgqN/xyHclva21xYL5xMiKXK5d
/+AAoIzoKv72sP2dMOJRpBPDOLrv+RgS
=wfOL
-----END PGP SIGNATURE-----
--- End Message ---
