Your message dated Wed, 23 Oct 2013 09:20:11 +0000
with message-id <[email protected]>
and subject line Bug#726145: fixed in leocad 0.80.1+svn1545-1
has caused the Debian Bug report #726145,
regarding leocad: Fail to build on Hurd and kfreebsd-*
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
726145: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726145
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: leocad
Version: 0.80-1
Severity: important
Tags: patch

The latest version of leocad fail to build on hurd and kfreebsd-*.  The
missing kfreebsd builds block the package from entering testing.  The
build problem is the same on all architectures:

qt/qtmain.cpp: In function 'int main(int, char**)':
qt/qtmain.cpp:166:37: error: 'libPath' was not declared in this scope
  if (!g_App->Initialize(argc, argv, libPath, cachePath.toLocal8Bit().data()))
                                     ^
make[1]: *** [build/release/.obj/qtmain.o] Error 1
make[1]: Leaving directory `/«PKGBUILDDIR»'
dh_auto_build: make -j1 returned exit code 2
make: *** [build-arch] Error 25

The problem is that the libPath variable is only defined for Windows,
MacOSX and Linux, but not for Hurd and FreeBSD.  I suggest to
restructure the logic to define the Linux values for every build that
isn't Windows or MacOSX, like the following patch:

--- leocad-0.80.orig/qt/qtmain.cpp
+++ leocad-0.80/qt/qtmain.cpp
@@ -134,7 +134,7 @@ int main(int argc, char *argv[])
        g_App = new lcApplication();
        gMainWindow = new lcMainWindow();
 
-#ifdef Q_OS_WIN
+#if defined(Q_OS_WIN)
        char libPath[LC_MAXPATH], *ptr;
        strcpy(libPath, argv[0]);
        ptr = strrchr(libPath,'\\');
@@ -143,19 +143,15 @@ int main(int argc, char *argv[])
 
        lcRegisterShellFileTypes();
        lcSehInit();
-#endif
-
-#ifdef Q_OS_LINUX
-       const char* libPath = LC_INSTALL_PREFIX"/share/leocad/";
-#endif
-
-#ifdef Q_OS_MAC
+#elif defined(Q_OS_MAC)
        QDir bundlePath = QDir(QCoreApplication::applicationDirPath());
        bundlePath.cdUp();
        bundlePath.cdUp();
        bundlePath = QDir::cleanPath(bundlePath.absolutePath() + 
"/Contents/Resources/");
        QByteArray pathArray = bundlePath.absolutePath().toLocal8Bit();
        const char* libPath = pathArray.data();
+#else /* Q_OS_LINUX, Hurd and FreeBSD */
+       const char* libPath = LC_INSTALL_PREFIX"/share/leocad/";
 #endif
 
        QString cachePath = 
QDesktopServices::storageLocation(QDesktopServices::CacheLocation);

It should fix the problem for both Hurd and kFreeBSD.

-- 
Happy hacking
Petter Reinholdtsen

--- End Message ---
--- Begin Message ---
Source: leocad
Source-Version: 0.80.1+svn1545-1

We believe that the bug you reported is fixed in the latest version of
leocad, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nicolas Guilbert <[email protected]> (supplier of updated leocad package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 22 Oct 2013 14:06:51 +0200
Source: leocad
Binary: leocad
Architecture: source amd64
Version: 0.80.1+svn1545-1
Distribution: unstable
Urgency: low
Maintainer: Nicolas Guilbert <[email protected]>
Changed-By: Nicolas Guilbert <[email protected]>
Description: 
 leocad     - virtual brick CAD software
Closes: 726145 726147
Changes: 
 leocad (0.80.1+svn1545-1) unstable; urgency=low
 .
   * New upstream release.
     - fix FTBFS on Hurd and kfreebsd- (Closes: #726145)
   * Patches refreshed
     - 07-fix-appearance-typo.patch removed, fixed upstream
   * Skip the check for newer available versions. (Closes: #726147)
Checksums-Sha1: 
 edfc96a8b771f3782081dfc5b2077a995d795318 1969 leocad_0.80.1+svn1545-1.dsc
 95f824b79f320ed5984abe48d3a16b994ffe70cb 961876 
leocad_0.80.1+svn1545.orig.tar.gz
 b00ac0c3ee6847ae5e031edc87679ebf42ce614a 9848 
leocad_0.80.1+svn1545-1.debian.tar.gz
 56511e88585285afb2747351c04fe71501a9c83f 402074 
leocad_0.80.1+svn1545-1_amd64.deb
Checksums-Sha256: 
 f44c64ed5115cbc6b057fff12d9943ff72fb1810e4c32c7af934dcced6a0fc2d 1969 
leocad_0.80.1+svn1545-1.dsc
 7cc9a526658da3a24ee9ff8891a4eb879ae9e5429d4c3b9fd6e6881c752e6441 961876 
leocad_0.80.1+svn1545.orig.tar.gz
 497faa89f4ff40a7253b5a2a1b0cfa96aa24271cf0085337e589690a6ec47fd9 9848 
leocad_0.80.1+svn1545-1.debian.tar.gz
 79cc27dba7bfa9446131614209308c370e7fce97b7b1a72beea6a2d1b4150388 402074 
leocad_0.80.1+svn1545-1_amd64.deb
Files: 
 5c9761aea48e02441f3ffc85cf5dbfa0 1969 utils extra leocad_0.80.1+svn1545-1.dsc
 3a6b7c7cd6f36a3d2751f6b5edbc6530 961876 utils extra 
leocad_0.80.1+svn1545.orig.tar.gz
 73d3228d809ad532ed8eb1c6a3484d27 9848 utils extra 
leocad_0.80.1+svn1545-1.debian.tar.gz
 2d3537141805876a40014cfcd34d5dd6 402074 utils extra 
leocad_0.80.1+svn1545-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iQIcBAEBCAAGBQJSZ49uAAoJEHQmOzf1tfkT8DgP/3TTvcVKLCmrfbsWFC3E84aw
kaWDolbcGTdv1Qobp0ITWUlqsOQ/KjCnPoe+5y/+mqh53iD+Mln7UrZtc+oEsQpe
BsPnPf0vIbip4m4j9p5HdlBfhghe2SxykcD0d13P7Ck3xpxdpiF3l3g7Ld8hRCOo
NtVZCqsLdlgWMUN719qNcOFJBfNTemVDNCwhTkN6Z7sZ712AxNTjUxftAYC0SzQu
+BBNrkh30I4pJ3uIGqD1DtLQg9YMBlShvfXyh/psJ/EYKpFsolUKyGBG3Lo1VSS0
yhxmRgzr5aZ9VHbAyosHLbozbB8i46wH2jRyzzeM7p0i+kyvOGGmLfqZOglXPrg0
usbq9r1JV+M8/OQ9GXbKnnGMkpTXfZeT21+wLB6WjquB2KMkmpMzE1zNU9e+XFK1
CYFYgKSyHV8Exa37oHk6vPSqj2hiKpggB1gFL0gtcRSltDOviVDWgSf3NRFpl1lb
vuLT6wCPMM3LLjiPSDzHzLPrXb1O4hHlTYOTFpw9bYnAokc5oYKsq1rr+z0zf8ET
LP7t8tRcR2DkzK4zRGrQunq3kIViPglJX0N7El86T1YmKzTl9zz28lvqpb+u3tsc
KBTClrMyG50i0Nn9xjmMJNIragd1g01+at8Gjr8PDin36szonBytm6My+EBaAige
s7xhUKbbH3U4LC4q0oQ2
=fMHH
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to