Your message dated Thu, 12 Dec 2013 10:03:33 +0000
with message-id <[email protected]>
and subject line Bug#731991: fixed in dh-golang 1.5
has caused the Debian Bug report #731991,
regarding dh-golang: The loop search for .go files returns incorrectly
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
731991: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=731991
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dh-golang
Version: 1.4
Severity: important
Dear Maintainer,
Although my system information reported here is from Ubuntu I have
reproduced in a sid sbuild as well.
I've pinpointed the problem to
http://anonscm.debian.org/gitweb/?p=collab-maint/dh-golang.git;a=blobdiff;f=lib/Debian/Debhelper/Buildsystem/golang.pm;h=9d55e63c0e9ad97a8ab6f43caf4523cfa657ecc0;hp=eb96d85327ebf2ee0dc5a81e1c1fabe388b9bf58;hb=b77530f5d4bebbb094b6dde72632a86a407e1b02;hpb=8cb05ba21120052965102bfe5c92fa626488aa73
A patch is attached
-- System Information:
Debian Release: wheezy/sid
APT prefers trusty-updates
APT policy: (500, 'trusty-updates'), (500, 'trusty-security'), (500,
'trusty'), (100, 'trusty-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.12.0-7-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages dh-golang depends on:
ii debhelper 9.20131127ubuntu1
ii dpkg 1.17.1ubuntu1
ii libparse-debcontrol-perl 2.005-4
ii perl 5.18.1-4build1
dh-golang recommends no packages.
dh-golang suggests no packages.
-- no debconf information
From dbbc3d3a5b44ce7a75a91eaf2613fe88c92a29d8 Mon Sep 17 00:00:00 2001
From: Sergio Schvezov <[email protected]>
Date: Wed, 11 Dec 2013 23:30:48 -0300
Subject: [PATCH] The loop search for .go files returns incorrectly
In the copy part of configure when looping through the sourcefiles and
not exporting DH_GOLANG_INSTALL_ALL all the go files are incorrectly
skipped.
Signed-off-by: Sergio Schvezov <[email protected]>
---
lib/Debian/Debhelper/Buildsystem/golang.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Debian/Debhelper/Buildsystem/golang.pm b/lib/Debian/Debhelper/Buildsystem/golang.pm
index 9d55e63..c73c387 100644
--- a/lib/Debian/Debhelper/Buildsystem/golang.pm
+++ b/lib/Debian/Debhelper/Buildsystem/golang.pm
@@ -65,7 +65,7 @@ sub configure {
},
wanted => sub {
my $name = $File::Find::name;
- return if substr($name, -3) eq '.go' &&
+ return if !substr($name, -3) eq '.go' &&
(!exists($ENV{DH_GOLANG_INSTALL_ALL}) ||
$ENV{DH_GOLANG_INSTALL_ALL} != 1);
return unless -f $name;
--
1.8.5.1
--- End Message ---
--- Begin Message ---
Source: dh-golang
Source-Version: 1.5
We believe that the bug you reported is fixed in the latest version of
dh-golang, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Stapelberg <[email protected]> (supplier of updated dh-golang
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 12 Dec 2013 10:46:36 +0100
Source: dh-golang
Binary: dh-golang
Architecture: source all
Version: 1.5
Distribution: unstable
Urgency: low
Maintainer: Michael Stapelberg <[email protected]>
Changed-By: Michael Stapelberg <[email protected]>
Description:
dh-golang - debhelper add-on for packaging software written in Go (golang)
Closes: 731991
Changes:
dh-golang (1.5) unstable; urgency=low
.
* Fix a bug introduce in 1.4 which lead to .go files not being installed
without DH_GOLANG_INSTALL_ALL=1 (Closes: #731991)
Checksums-Sha1:
a89050a9c9717275435fcfbffa0dcec84b16f107 1567 dh-golang_1.5.dsc
38baf7afbd927816e0a43dab336a4282b4e4ebd6 5677 dh-golang_1.5.tar.gz
b689e8c7391c68b9900c5731e18a48dfae972e11 7920 dh-golang_1.5_all.deb
Checksums-Sha256:
e062aa97ae3302d3905d2cc2cc0132597173b66f37a5023dd42c0886c8e176eb 1567
dh-golang_1.5.dsc
0ba83e137dcde285c0137f3a7ac71e5b3037ca0cbe72a40d89115ea9036d3a0a 5677
dh-golang_1.5.tar.gz
4680840eb0a0926711aec1653d6e6abb59975989bf18f1afbf6d8317d6c81126 7920
dh-golang_1.5_all.deb
Files:
ebc6b1ccbb7d7bcbebd923fe8f4fdda8 1567 devel extra dh-golang_1.5.dsc
684e742bc36ac2ec752de70cb7a24b33 5677 devel extra dh-golang_1.5.tar.gz
21b6beb3870709fb3843d0a9a5794b2b 7920 devel extra dh-golang_1.5_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCgAGBQJSqYhRAAoJEE5xYO1KyO4di2cQALokkjM9u+fbh4VS/BjCR3v5
gPem1nNpA/kJ6awfPsNCNux1AYOKBhYdASzfC2HLH2LrOkCAh8d1o+YQ5h/XoHQt
6KrhuOSKZQdchhjxlnX940RJuJLF8BqfAXCSLzlzYtSphrWqwwV4VXPShv3nnRGS
+PDXe88n0lEI14/4Xtc5jyxZ3ZgjQzWfS6TjIsTKF2kbyC1VFRi3gUTxF4zTVqlx
lNpBZsCguYWqtBybrKrNAh67/KvvuefTnCpEY5BfOLhmGCafEIjLhkLjS5R5Kose
9fN+a5fZN8ezYSN7yMnwvbd8rQio8NODbGwmrnGbbFcS3fyRddPr4spqz7QrN6FA
i1eb+EfE7eQ4bMHovPUtvmcCMybhbGxsrwHEAlOJMzEtlRsUhulI8JrpoVR2DT6O
P46OTYgJRP8kL+2LyV7/1LRLq8rWbQorgy89f6Sa05jCYAuCL64GGi0PDWOOSnC6
yOFgEYCJ1ko8U/vg2YhUOW3eRuZ8zkZ/MRlAxqchd1avkuEZiusCWxidctXd94m/
X0HLbVWHu9lLss8tspYH+JpkHmZK4btt8UG1aYn7FYw0FN2OpFEHw/3e0Pw6Pxr0
Bx1zvRi1crygdjVxbnw1Px03//AISAgNsnqw92GVEIs2V9DJnch2/X7G7WiOGX3X
bqfTuctFGgug8qQA2fiz
=y05v
-----END PGP SIGNATURE-----
--- End Message ---
