Your message dated Thu, 26 Dec 2013 11:18:59 +0000
with message-id <[email protected]>
and subject line Bug#707882: fixed in scribus 1.4.2.dfsg+r18267-1.1
has caused the Debian Bug report #707882,
regarding scribus FTBFS on armel and armhf, qreal vs double problems
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
707882: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=707882
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
package: scribus
version: 1.4.2.dfsg+r18267-1
severity: serious
Looks like you got yet another qreal vs double issue.
[ 67%] Building CXX object scribus/CMakeFiles/scribus.dir/scribus.cpp.o
/build/buildd-scribus_1.4.2.dfsg+r18267-1-armel-jtGbQP/scribus-1.4.2.dfsg+r18267/scribus/scribus.cpp:
In member function 'void ScribusMainWindow::rebuildLayersList()':
/build/buildd-scribus_1.4.2.dfsg+r18267-1-armel-jtGbQP/scribus-1.4.2.dfsg+r18267/scribus/scribus.cpp:3677:8:
warning: variable 'found' set but not used [-Wunused-but-set-variable]
/build/buildd-scribus_1.4.2.dfsg+r18267-1-armel-jtGbQP/scribus-1.4.2.dfsg+r18267/scribus/scribus.cpp:
In member function 'void ScribusMainWindow::duplicateToMasterPage()':
/build/buildd-scribus_1.4.2.dfsg+r18267-1-armel-jtGbQP/scribus-1.4.2.dfsg+r18267/scribus/scribus.cpp:5892:8:
warning: unused variable 'ok' [-Wunused-variable]
/build/buildd-scribus_1.4.2.dfsg+r18267-1-armel-jtGbQP/scribus-1.4.2.dfsg+r18267/scribus/scribus.cpp:
In member function 'void ScribusMainWindow::setAppMode(int)':
/build/buildd-scribus_1.4.2.dfsg+r18267-1-armel-jtGbQP/scribus-1.4.2.dfsg+r18267/scribus/scribus.cpp:6691:36:
error: cannot convert 'qreal* {aka float*}' to 'double*' in assignment
make[3]: *** [scribus/CMakeFiles/scribus.dir/scribus.cpp.o] Error 1
As i've said before assingments between qreal and double are ok but
assignments between pointers to double and pointers to qreal are not ok.
Unfortunately this was not a simple case like the ones i've seen before,
the assignment was between two member variables and there seemed to be
quite a chain of code in both directions. I've fixed it so it builds but
I don't really know if the fix is correct so you should probablly get
someone who understands the code to look it over before applying.
Description: Fix yet another qreal vs double issue.
On most architectures qreal is defined as double but on arm architecture
it's defined as float. Assignments between qreal and double are ok but
assignments between pointers to qreal and pointers to double are not ok.
.
This patch changes the types of some declarations to avoid attempting to
make assignments between pointers to qreal and pointers to double.
.
Author: Peter Michael Green <[email protected]>
---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:
Origin: <vendor|upstream|other>, <url of original patch>
Bug: <url in upstream bugtracker>
Bug-Debian: http://bugs.debian.org/<bugnumber>
Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
Forwarded: <no|not-needed|url proving that it has been forwarded>
Reviewed-By: <name and email of someone who approved the patch>
Last-Update: <YYYY-MM-DD>
--- scribus-1.4.2.dfsg+r18267.orig/scribus/ui/modetoolbar.cpp
+++ scribus-1.4.2.dfsg+r18267/scribus/ui/modetoolbar.cpp
@@ -40,7 +40,7 @@ ModeToolBar::ModeToolBar(ScribusMainWind
{
SubMode = 0;
ValCount = 32;
- static qreal AutoShapes0[] = {0.0, 0.0, 0.0, 0.0, 100.0, 0.0, 100.0, 0.0, 100.0, 0.0, 100.0, 0.0,
+ static double AutoShapes0[] = {0.0, 0.0, 0.0, 0.0, 100.0, 0.0, 100.0, 0.0, 100.0, 0.0, 100.0, 0.0,
100.0, 100.0, 100.0, 100.0, 100.0, 100.0, 100.0, 100.0, 0.0, 100.0, 0.0, 100.0,
0.0, 100.0, 0.0, 100.0, 0.0, 0.0, 0.0, 0.0};
ShapeVals = AutoShapes0;
@@ -84,7 +84,7 @@ ModeToolBar::ModeToolBar(ScribusMainWind
this->addAction(m_ScMW->scrActions["toolsEyeDropper"]);
languageChange();
- connect(Rechteck, SIGNAL(FormSel(int, int, qreal *)), this, SLOT(SelShape(int, int, qreal *)));
+ connect(Rechteck, SIGNAL(FormSel(int, int, double *)), this, SLOT(SelShape(int, int, double *)));
}
void ModeToolBar::GetPolyProps()
@@ -98,7 +98,7 @@ void ModeToolBar::GetPolyProps()
delete dia;
}
-void ModeToolBar::SelShape(int s, int c, qreal *vals)
+void ModeToolBar::SelShape(int s, int c, double *vals)
{
m_ScMW->scrActions["toolsInsertShape"]->setIcon(QIcon(Rechteck->getIconPixmap(s,16)));
// insertShapeButtonMenu->hide();
--- scribus-1.4.2.dfsg+r18267.orig/scribus/ui/modetoolbar.h
+++ scribus-1.4.2.dfsg+r18267/scribus/ui/modetoolbar.h
@@ -51,13 +51,13 @@ public:
int SubMode;
int ValCount;
- qreal *ShapeVals;
+ double *ShapeVals;
virtual void changeEvent(QEvent *e);
public slots:
void GetPolyProps();
- void SelShape(int s, int c, qreal *vals);
+ void SelShape(int s, int c, double *vals);
void languageChange();
protected:
--- End Message ---
--- Begin Message ---
Source: scribus
Source-Version: 1.4.2.dfsg+r18267-1.1
We believe that the bug you reported is fixed in the latest version of
scribus, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mattia Rizzolo <[email protected]> (supplier of updated scribus package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 21 Dec 2013 16:13:37 +0100
Source: scribus
Binary: scribus
Architecture: source amd64
Version: 1.4.2.dfsg+r18267-1.1
Distribution: unstable
Urgency: medium
Maintainer: Oleksandr Moskalenko <[email protected]>
Changed-By: Mattia Rizzolo <[email protected]>
Description:
scribus - Open Source Desktop Page Layout - stable branch
Closes: 707882
Changes:
scribus (1.4.2.dfsg+r18267-1.1) unstable; urgency=medium
.
* Non-maintainer upload.
* debian/patch/qreal_double.patch: Avoid qreal/double clashes on ARM
(imported from Ubuntu). (Closes: #707882)
Checksums-Sha1:
faba835e6b631915b8ea0883566fc8cd72610f01 2151 scribus_1.4.2.dfsg+r18267-1.1.dsc
82701e0565d35c211f72efbd85ae6997ace96af8 27995
scribus_1.4.2.dfsg+r18267-1.1.debian.tar.gz
c41e59cb16e79d78bc433dc26798f011bcff63f3 19795674
scribus_1.4.2.dfsg+r18267-1.1_amd64.deb
Checksums-Sha256:
470816ce2b233a924a1480b306e5015e208d5b17e1b0bb59a9b343cfe389700e 2151
scribus_1.4.2.dfsg+r18267-1.1.dsc
55d0685256677e2d2e0e59326b2ca744af085e94591e7903593a29d9848f8391 27995
scribus_1.4.2.dfsg+r18267-1.1.debian.tar.gz
c9731cd29b2f88cb11a456f03c4fa4d937efa745a53248753fbfccb9158f212e 19795674
scribus_1.4.2.dfsg+r18267-1.1_amd64.deb
Files:
9e1182b2c53a4a0f3d23ddd1806657b2 2151 graphics optional
scribus_1.4.2.dfsg+r18267-1.1.dsc
a30fe3dfd3e4c12632b207528e65b393 27995 graphics optional
scribus_1.4.2.dfsg+r18267-1.1.debian.tar.gz
f72a739c965b4c874bf2e7a57a487d78 19795674 graphics optional
scribus_1.4.2.dfsg+r18267-1.1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
iQIcBAEBAgAGBQJSuWYzAAoJECcT5nkIRlGvVssQAJPg0YaQNt3kUS4i6teV6voR
tIvo5ga/fIuL1E0jB02dpchJKZNacysA3gzq4FQpCPX5JuP41p23fZbgDTEd1Xoi
lH/+f6NsleuXSlJJYteebMQYg/JfJQvvTf1bo93r7Rm22thECmDcG5zJiiVP8WuT
pTlOYE0w2jYNlVYKFdcRxVACUwDBftLSxDlloWam/vmv/TowGwi4uyjzkZparlRU
r6+TZ7/I1IXEbR/tsoNecfXApfZqX7WjUluXOjxhpeSSzx9y7AvCbVxJOiI11rGk
oJkNWveVd4cRW4ws1yyxw5HdPleiAm4KLbFwlYdznadjNU8Z1DDRoYyfDf3ETHwh
BA5mC7vGAwiTsDEl4ynUjP9xpiLsYUD6g1s+P1hiGjnbATy7ryVasPtQ9g2NjHmJ
Fia9PA3NANpSLO7453WOQPTZeQnBlshSD14X3tvc/Sd2BDCHs8hlyJwLtYxV3VDP
HFE/4hE7aysCLQKqnFMJMo/kMywVdqlLiziqcrB5M8YwsJrKx7zFENDmqGxdUoDl
dJF16C1qAFVRMornAd+59FJa0+k/ks11zQ4N9CG0fzDkuTRALLLBjqbwU8ZXHntM
U6/hWdvsqbnUHIs/z4gtmHaBAY6aTiMzGYEss4Dcx9wC+KiRc77BqcvYRS2wIMjf
yO8lKy9wK8zRP100sWde
=bE9g
-----END PGP SIGNATURE-----
--- End Message ---
