Your message dated Sat, 07 Jun 2014 17:33:36 +0000
with message-id <[email protected]>
and subject line Bug#749067: fixed in kupfer 0+v208-5
has caused the Debian Bug report #749067,
regarding kupfer: Kupfer no longer reads firefox bookmark files
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
749067: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749067
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: kupfer
Version: 0+v208-3
Severity: normal
Tags: patch
Dear Maintainer,
Since iceweasel 29 kupfer no longer reads the bookmark file.
For a while it was looking for backup files even though
bookmarks were stored in places.sqlite. Included patch adapts
functionality already present for reading history to reading
bookmarks.
Cheers,
Itai
-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (600, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.14-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages kupfer depends on:
ii dbus 1.8.2-1
ii python-dbus 1.2.0-2+b2
ii python-gobject 3.12.1-1
ii python-gtk2 2.24.0-3+b1
ii python-keybinder 0.3.0-3
ii python-xdg 0.25-4
pn python:any <none>
Versions of packages kupfer recommends:
ii python-keyring 3.8-1
ii python-wnck 2.32.0+dfsg-3
Versions of packages kupfer suggests:
pn python-cjson <none>
pn python-gdata <none>
pn python-qrencode <none>
-- no debconf information
Description: <short summary of the patch>
TODO: Put a short summary on the line above and replace this paragraph
with a longer explanation of this change. Complete the meta-information
with other relevant fields (see below for details). To make it easier, the
information below has been extracted from the changelog. Adjust it or drop
it.
.
kupfer (0+v208-3.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Read firefox bookmarks from places.sqlite
Author: Itaï BEN YAACOV <[email protected]>
---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:
Origin: <vendor|upstream|other>, <url of original patch>
Bug: <url in upstream bugtracker>
Bug-Debian: http://bugs.debian.org/<bugnumber>
Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
Forwarded: <no|not-needed|url proving that it has been forwarded>
Reviewed-By: <name and email of someone who approved the patch>
Last-Update: <YYYY-MM-DD>
--- kupfer-0+v208.orig/kupfer/plugin/firefox.py
+++ kupfer-0+v208/kupfer/plugin/firefox.py
@@ -65,12 +65,21 @@ class BookmarksSource (AppLeafContentMix
self.output_exc()
def _get_ffx3_bookmarks(self, fpath):
- """Parse Firefox' .json bookmarks backups"""
- from kupfer.plugin import firefox3_support
- self.output_debug("Parsing", fpath)
- bookmarks = firefox3_support.get_bookmarks(fpath)
- for book in bookmarks:
- yield UrlLeaf(book["uri"], book["title"])
+ """Query the firefox places bookmark database"""
+ fpath = firefox_support.get_firefox_home_file("places.sqlite")
+ if not (fpath and os.path.isfile(fpath)):
+ return
+ try:
+ self.output_debug("Reading bookmarks from", fpath)
+ with closing(sqlite3.connect(fpath, timeout=1)) as conn:
+ c = conn.cursor()
+ c.execute("""SELECT moz_places.url, moz_bookmarks.title
+ FROM moz_places, moz_bookmarks
+ WHERE moz_places.id = moz_bookmarks.fk""")
+ return [UrlLeaf(url, title) for url, title in c]
+ except sqlite3.Error:
+ # Something is wrong with the database
+ self.output_exc()
def _get_ffx2_bookmarks(self, fpath):
"""Parse Firefox' bookmarks.html"""
--- End Message ---
--- Begin Message ---
Source: kupfer
Source-Version: 0+v208-5
We believe that the bug you reported is fixed in the latest version of
kupfer, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Hugo Lefeuvre <[email protected]> (supplier of updated kupfer package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 07 Jun 2014 16:16:36 +0200
Source: kupfer
Binary: kupfer
Architecture: source all
Version: 0+v208-5
Distribution: unstable
Urgency: medium
Maintainer: Python Applications Packaging Team
<[email protected]>
Changed-By: Hugo Lefeuvre <[email protected]>
Description:
kupfer - fast and lightweight desktop summoner/launcher
Closes: 749067
Changes:
kupfer (0+v208-5) unstable; urgency=medium
.
* debian/patches/bookmarks-places.sqlite.patch:
- Fix the error when reading firefox bookmark files (Closes: #749067).
Checksums-Sha1:
b1e26a7f8d753e7f8602667f384f1d469fd591a0 2020 kupfer_0+v208-5.dsc
7e9ca8af25f3c140558a1a2fb47889b23c2a8501 16268 kupfer_0+v208-5.debian.tar.xz
e31e95981c52b5d7dd89ab4619a15f02ad38d2aa 542564 kupfer_0+v208-5_all.deb
Checksums-Sha256:
94e0f99053dd50bb40ab1cbacff69ca181996c8548189d159752c5e2302e4d07 2020
kupfer_0+v208-5.dsc
652cc26a2815dece0306ba1ab5d49e28eec90ce6c379c52f0b42ce4c4b723985 16268
kupfer_0+v208-5.debian.tar.xz
21377f8abad9a2b58850de2bdd8d1786e7f2116872f1ed9c577e1689023cf703 542564
kupfer_0+v208-5_all.deb
Files:
94b5a97868a725f82c5cd773c5e953cb 542564 utils optional kupfer_0+v208-5_all.deb
2f20fa065aae2f918c93a3eecac62172 2020 utils optional kupfer_0+v208-5.dsc
d78ebac344f5e121236c3407481e7cc4 16268 utils optional
kupfer_0+v208-5.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJTk0jDAAoJEEkIatPr4vMfTsAQAIinyu7SiZ6222dK4Gak//a5
OTTD922SA8peYHHT+0kN8yqg3J0Y055f+cfNLqML61UexwU4FlZil3JxOTcE3uVA
EDWFlo3DHSRkdAjgAFR4ADc9oJeoOcYcHFaqR4gJnmCjmicIK5RSJEjPTVyDgECj
Pjk7gj86X2lJx7oeMfNQ44yHRuZT1ekcPOKcAw4y9vopUcbPIrVk/Vs/IjONy6bw
AMRhvM30kvScH4BG4x8BGaHKYlkGe95ciTuJn/idDiXg6+mjWyPYGCNYxaGqjpoF
TzdOmGD3g5hloyhZfWiTAYPnmw0qukao/s3wben2YEOfV4ZJYTC2hoj7nDVWFzpy
xliLzjPinga6TjZqSmAkQSUEtj2DU3f32y9SsYNI9Zfkw6v7ADh88JY8/zE3mi7C
nx06syvCAIzS9hHrclHtKp/bqBBLaS/LgL/xaf+EyCcyfD8NA9HVLAS5DR3Q6Dkc
KWqotF0kF6lG2ZgzZeVqKov+TJnfVP5Gn/cJ4xFm8BsmoaHYRAvAAu2am8Fv0QsH
6wmrIPWcEHd2FY2r3fo1Taki7oXIl+/c6Xwvr/fB6/R2S85XDPXDXZT6CeANzfO7
MK1PC3FS8JAzuyc4XiQMNJIkPT35z2GO5409ZEf9Af3Nc2Bh1eOUS8Vq3Wbyg7p9
G7DZ2qdk+8aqwkWXqR36
=Lsth
-----END PGP SIGNATURE-----
--- End Message ---
