Your message dated Tue, 26 May 2015 12:47:06 +0000
with message-id <[email protected]>
and subject line Bug#782996: fixed in smstools 3.1.15-1.1+deb8u1
has caused the Debian Bug report #782996,
regarding smsd: 'reload' function of initscript broken if used by systemd
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
782996: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=782996
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: smstools
Version: 3.1.15-1.1
Severity: serious
Hello,
the smstools initscript has a wrong implementation of the 'reload'
function which breaks if used through systemd tools. In fact, the 'reload'
function in smstools initscript doesn't reload the configuration of the
service without actually stopping and restarting the service. Instead, it
stops the service if it runs and restarts it afterwards. This is, what
'force-reload' is for.
As a result, 'invoke-rc.d smstools reload', 'service smstools reload' and
'systemctl reload smstools.service' all result in the smsd daemon being
killed and not restarted afterwards.
The smstools logrotate script runs 'invoke-rc.d smstools reload' as post-
rotate action, which leads to the smsd daemon process being killed
The bug can be fixed by renaming the 'reload' function to 'force-reload'
and dropping the original 'force-reload' alias for 'restart'. Please note,
that fixing the 'Usage:' line by dropping 'reload' from the list of
supported actions is important as well. Otherwise, systemd tools try to
invoke 'reload' even if 'force-reload' is given as argument.
See the attached patch for a proper fix.
I consider this bug as release-critical for Jessie, as it renders
smmstools unusable on Jessie installations whenever logrotate is
installed. Thus I suggest to push the fix into Jessie within the next
days. I'll gladly do an NMU if the maintainer(s) don't have the time
to push this fix into Jessie in time.
Cheers,
jonas
-- System Information:
Debian Release: 8.0
APT prefers testing-updates
APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 3.16.0-4-amd64 (SMP w/20 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages smstools depends on:
ii adduser 3.113+nmu3
ii debconf 1.5.56
ii libc6 2.19-18
ii libmm14 1.4.2-5
ii ucf 3.0030
smstools recommends no packages.
smstools suggests no packages.
-- debconf information:
smstools/devicepin: (password omitted)
smstools/modems/devicepin1: (password omitted)
smstools/configureanothermodem: false
smstools/eventhandler:
smstools/modems/devicenode1: /dev/ttyS0
smstools/configure: true
smstools/modems/deviceinit1:
smstools/modems/devicename1: GSM1
smstools/devicebaudrate: 19200
smstools/deviceinit:
smstools/devicenode:
smstools/configureanothermodem1: false
smstools/devicename: GSM1
smstools/modems/deviceincoming1: true
smstools/devicenodeother:
smstools/devicebaudrateother:
smstools/modems/devicebaudrate1: 19200
smstools/deviceincoming: true
diff -rNu smstools-3.1.15.orig/debian/changelog smstools-3.1.15/debian/changelog
--- smstools-3.1.15.orig/debian/changelog 2015-04-20 11:46:00.000000000 +0200
+++ smstools-3.1.15/debian/changelog 2015-04-20 11:52:23.746207040 +0200
@@ -1,3 +1,14 @@
+smstools (3.1.15-1.2) unstable; urgency=high
+
+ * NMU by Jonas Meurer to push the fix into Jessie.
+ * Fix initscript: rename action 'reload' to 'force-reload' and drop 'reload'
+ from supported actions. Use 'force-reload' in logrotate post-rotate action.
+ This fixes 'force-reload' function when used through systemd tools and
+ prevents the smsd daemon process from being killed at every log rotation.
+ (closes: #XXXXXX)
+
+ -- Jonas Meurer <[email protected]> Mon, 20 Apr 2015 11:46:53 +0200
+
smstools (3.1.15-1.1) unstable; urgency=low
* NMU - preventing smstools from entering jessie.
diff -rNu smstools-3.1.15.orig/debian/init.d smstools-3.1.15/debian/init.d
--- smstools-3.1.15.orig/debian/init.d 2015-04-20 11:46:00.000000000 +0200
+++ smstools-3.1.15/debian/init.d 2015-04-20 11:46:38.266199428 +0200
@@ -218,7 +218,7 @@
echo "$NAME."
;;
- reload)
+ force-reload)
echo -n "Reloading $DESC: "
status
if [ "$?" = 0 ]; then
@@ -230,14 +230,14 @@
;;
- restart|force-reload)
+ restart)
echo -n "Restarting $DESC: "
stop restart
start
;;
*)
- echo "Usage: /etc/init.d/$NAME {start|stop|force-stop|reload|force-reload|restart|status}"
+ echo "Usage: /etc/init.d/$NAME {start|stop|force-stop|force-reload|restart|status}"
exit 3
;;
esac
diff -rNu smstools-3.1.15.orig/debian/logrotate smstools-3.1.15/debian/logrotate
--- smstools-3.1.15.orig/debian/logrotate 2015-04-20 11:46:00.000000000 +0200
+++ smstools-3.1.15/debian/logrotate 2015-04-20 11:46:50.426199696 +0200
@@ -4,6 +4,6 @@
compress
missingok
postrotate
- invoke-rc.d smstools reload > /dev/null
+ invoke-rc.d smstools force-reload > /dev/null
endscript
}
--- End Message ---
--- Begin Message ---
Source: smstools
Source-Version: 3.1.15-1.1+deb8u1
We believe that the bug you reported is fixed in the latest version of
smstools, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jonas Meurer <[email protected]> (supplier of updated smstools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 17 May 2015 12:05:33 +0200
Source: smstools
Binary: smstools
Architecture: source amd64
Version: 3.1.15-1.1+deb8u1
Distribution: stable
Urgency: high
Maintainer: Mark Purcell <[email protected]>
Changed-By: Jonas Meurer <[email protected]>
Description:
smstools - SMS server tools for GSM modems
Closes: 782996
Changes:
smstools (3.1.15-1.1+deb8u1) stable; urgency=high
.
* NMU by Jonas Meurer to push the fix into Jessie.
* Fix initscript (debian/init.d):
* drop action 'reload' as it does not what policy demands it to do. Use
'force-reload' in logrotate post-rotate action. This fixes 'force-reload'
action when used through systemd tools and prevents the smsd daemon
process from being killed at every log rotation. (closes: #782996)
* source /lib/lsb/init-functions in order to make systemd tools aware of
status changes to the daemon that have been caused by invoking the
initscript directly.
Checksums-Sha1:
a7aeae0ce34939a1ab48e14f7232e4348b17e402 1926 smstools_3.1.15-1.1+deb8u1.dsc
bfae59565eddb44cc899fade246ea572be2653e7 34211
smstools_3.1.15-1.1+deb8u1.diff.gz
d374c7fd281e02adeff6db5e402ca3001d673875 274594
smstools_3.1.15-1.1+deb8u1_amd64.deb
Checksums-Sha256:
af1b4f48a3dbcaa2d5257de77a37ba5372b986686cb85368fad428f08352d0f0 1926
smstools_3.1.15-1.1+deb8u1.dsc
73c752f821d030e4efade73227980938041c58f9d71668bc91ed72b1141678d0 34211
smstools_3.1.15-1.1+deb8u1.diff.gz
3671387a44a2036367401483c148dd4a2f4e6d862ad02a00215ce379783877d0 274594
smstools_3.1.15-1.1+deb8u1_amd64.deb
Files:
496596affaf48d42a505abb9a6003b88 1926 comm optional
smstools_3.1.15-1.1+deb8u1.dsc
f9c5616dd56e547a52ce3212b235e7d1 34211 comm optional
smstools_3.1.15-1.1+deb8u1.diff.gz
ca464ffa77ff4203c472f4fd14d8ba3a 274594 comm optional
smstools_3.1.15-1.1+deb8u1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJVWGhDAAoJEBvzc5c7ZRqnCzIQAMQSKa2Hjk5+mHBhcNt6iMW1
f4jOzFYdr4H4OgWnNPAqg01ja52Z6GqpIAdF35ALB781eahFtMDgu9A7p2HKfYDM
NN/k+t6saS49evDwpVYj0mcugN/dfu1hJCNwJ+Uj+r/xq3bsT75S3zHgyf7S5Bwa
/Va0u0Y/QHLCi/Yfh4sf7wlYQhRF6s1CSKxJ+4rsq6hjt3RKE0WM4d1+PHEQDSJ7
cu5KavUYSyaiLc6gI8vzg8ZSaCMtaJbD9Lmvj1bV7YX4eoN8oB6grcMMRI+3YfPY
bCE4KAUKGLN5G0thB4az+81CJ6BzjKXDCQI+OWvuBFKVdgVFc/WmHi9wmOU9gB4A
kwLKHZhUSidNdU+fDze1RL9I/CVcgmOhlxqcFdnOqht4pAxU8V1sMIMXVtPXt1dD
Cr4uQ9bXcA8t8HZwNAKs5lbLlcs7z3GslKU+GgxWwHiU+8obSf6mZjDWdixVI5TL
OwR170qYphp+AomXMmPdwWG/cp7Ol9AqhDbVuynddf3LJ5JM/tR9a/8fU43FkVEy
xDfg1eXhVpIgSsFIY84wodznYnYWK4mhZolct6x6EMpERYX6ROpBfyYaeEWXJtLE
cAnnNycjeujEXI84JV4kbuVv+q5oDrNAPl4pDOPUE8QatxXb0an8oBUI6DsXur1u
MggdMZxbm3sXZ+7rsTc1
=ftVq
-----END PGP SIGNATURE-----
--- End Message ---
