Your message dated Mon, 27 Apr 2015 22:23:40 +0000
with message-id <[email protected]>
and subject line Bug#782996: fixed in smstools 3.1.15-1.2
has caused the Debian Bug report #782996,
regarding smsd: 'reload' function of initscript broken if used by systemd
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
782996: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=782996
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: smstools
Version: 3.1.15-1.1
Severity: serious
Hello,
the smstools initscript has a wrong implementation of the 'reload'
function which breaks if used through systemd tools. In fact, the 'reload'
function in smstools initscript doesn't reload the configuration of the
service without actually stopping and restarting the service. Instead, it
stops the service if it runs and restarts it afterwards. This is, what
'force-reload' is for.
As a result, 'invoke-rc.d smstools reload', 'service smstools reload' and
'systemctl reload smstools.service' all result in the smsd daemon being
killed and not restarted afterwards.
The smstools logrotate script runs 'invoke-rc.d smstools reload' as post-
rotate action, which leads to the smsd daemon process being killed
The bug can be fixed by renaming the 'reload' function to 'force-reload'
and dropping the original 'force-reload' alias for 'restart'. Please note,
that fixing the 'Usage:' line by dropping 'reload' from the list of
supported actions is important as well. Otherwise, systemd tools try to
invoke 'reload' even if 'force-reload' is given as argument.
See the attached patch for a proper fix.
I consider this bug as release-critical for Jessie, as it renders
smmstools unusable on Jessie installations whenever logrotate is
installed. Thus I suggest to push the fix into Jessie within the next
days. I'll gladly do an NMU if the maintainer(s) don't have the time
to push this fix into Jessie in time.
Cheers,
jonas
-- System Information:
Debian Release: 8.0
APT prefers testing-updates
APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 3.16.0-4-amd64 (SMP w/20 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages smstools depends on:
ii adduser 3.113+nmu3
ii debconf 1.5.56
ii libc6 2.19-18
ii libmm14 1.4.2-5
ii ucf 3.0030
smstools recommends no packages.
smstools suggests no packages.
-- debconf information:
smstools/devicepin: (password omitted)
smstools/modems/devicepin1: (password omitted)
smstools/configureanothermodem: false
smstools/eventhandler:
smstools/modems/devicenode1: /dev/ttyS0
smstools/configure: true
smstools/modems/deviceinit1:
smstools/modems/devicename1: GSM1
smstools/devicebaudrate: 19200
smstools/deviceinit:
smstools/devicenode:
smstools/configureanothermodem1: false
smstools/devicename: GSM1
smstools/modems/deviceincoming1: true
smstools/devicenodeother:
smstools/devicebaudrateother:
smstools/modems/devicebaudrate1: 19200
smstools/deviceincoming: true
diff -rNu smstools-3.1.15.orig/debian/changelog smstools-3.1.15/debian/changelog
--- smstools-3.1.15.orig/debian/changelog 2015-04-20 11:46:00.000000000 +0200
+++ smstools-3.1.15/debian/changelog 2015-04-20 11:52:23.746207040 +0200
@@ -1,3 +1,14 @@
+smstools (3.1.15-1.2) unstable; urgency=high
+
+ * NMU by Jonas Meurer to push the fix into Jessie.
+ * Fix initscript: rename action 'reload' to 'force-reload' and drop 'reload'
+ from supported actions. Use 'force-reload' in logrotate post-rotate action.
+ This fixes 'force-reload' function when used through systemd tools and
+ prevents the smsd daemon process from being killed at every log rotation.
+ (closes: #XXXXXX)
+
+ -- Jonas Meurer <[email protected]> Mon, 20 Apr 2015 11:46:53 +0200
+
smstools (3.1.15-1.1) unstable; urgency=low
* NMU - preventing smstools from entering jessie.
diff -rNu smstools-3.1.15.orig/debian/init.d smstools-3.1.15/debian/init.d
--- smstools-3.1.15.orig/debian/init.d 2015-04-20 11:46:00.000000000 +0200
+++ smstools-3.1.15/debian/init.d 2015-04-20 11:46:38.266199428 +0200
@@ -218,7 +218,7 @@
echo "$NAME."
;;
- reload)
+ force-reload)
echo -n "Reloading $DESC: "
status
if [ "$?" = 0 ]; then
@@ -230,14 +230,14 @@
;;
- restart|force-reload)
+ restart)
echo -n "Restarting $DESC: "
stop restart
start
;;
*)
- echo "Usage: /etc/init.d/$NAME {start|stop|force-stop|reload|force-reload|restart|status}"
+ echo "Usage: /etc/init.d/$NAME {start|stop|force-stop|force-reload|restart|status}"
exit 3
;;
esac
diff -rNu smstools-3.1.15.orig/debian/logrotate smstools-3.1.15/debian/logrotate
--- smstools-3.1.15.orig/debian/logrotate 2015-04-20 11:46:00.000000000 +0200
+++ smstools-3.1.15/debian/logrotate 2015-04-20 11:46:50.426199696 +0200
@@ -4,6 +4,6 @@
compress
missingok
postrotate
- invoke-rc.d smstools reload > /dev/null
+ invoke-rc.d smstools force-reload > /dev/null
endscript
}
--- End Message ---
--- Begin Message ---
Source: smstools
Source-Version: 3.1.15-1.2
We believe that the bug you reported is fixed in the latest version of
smstools, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jonas Meurer <[email protected]> (supplier of updated smstools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Mon, 27 Apr 2015 20:45:40 +0200
Source: smstools
Binary: smstools
Architecture: source amd64
Version: 3.1.15-1.2
Distribution: unstable
Urgency: high
Maintainer: Mark Purcell <[email protected]>
Changed-By: Jonas Meurer <[email protected]>
Description:
smstools - SMS server tools for GSM modems
Closes: 782996
Changes:
smstools (3.1.15-1.2) unstable; urgency=high
.
* NMU by Jonas Meurer to push the fix into Jessie.
* Fix initscript (debian/init.d):
* drop action 'reload' as it does not what policy demands it to do. Use
'force-reload' in logrotate post-rotate action. This fixes 'force-reload'
action when used through systemd tools and prevents the smsd daemon
process from being killed at every log rotation. (closes: #782996)
* source /lib/lsb/init-functions in order to make systemd tools aware of
status changes to the daemon that have been caused by invoking the
initscript directly.
Checksums-Sha1:
f913393dff83a33b1547d6d9fed450ed887afdbf 1898 smstools_3.1.15-1.2.dsc
edb722fa49dd65805cb288a113254480265d905a 34204 smstools_3.1.15-1.2.diff.gz
daada183e49c7185ed9d90893a1d2d624170ec02 274568 smstools_3.1.15-1.2_amd64.deb
Checksums-Sha256:
c66197f668f2d6bcddceeaf60dbee06db1f959904ca2f2a4c5ca7342784b63ad 1898
smstools_3.1.15-1.2.dsc
66fcb978b585bf5536d0048c5a27a59342cacc2b3244d9d907aaddec7e8b3a3b 34204
smstools_3.1.15-1.2.diff.gz
de862e48bfae1f1cc2886c320732c3c78fa0b0adc1a44340a76f9fbc00c2c1b9 274568
smstools_3.1.15-1.2_amd64.deb
Files:
a1b607215975bf52eb4ceff91cc954e7 1898 comm optional smstools_3.1.15-1.2.dsc
cedde1fd7d19eab4d779bb4b5f612939 34204 comm optional
smstools_3.1.15-1.2.diff.gz
28d7d7e7030ca4d721b41d9154610152 274568 comm optional
smstools_3.1.15-1.2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJVPoQiAAoJEBvzc5c7ZRqnmycP/1DPb9PBPqvI/WFqM1D5xPjY
+Ud77sAj3A+REO1vB4FKR1JlnD8DOSF1E+VwjX+RBzBRFIxbkyR2uTh5yvWmovuV
PQV/OKjt5RSmL7C5BZViKwxE6RBR8X9gip0kwLxch7vggkEO5bBd2uxdiswSP8qK
xl/Zf6QyWg5ex90zZ+WFuCczxrmfVYm4voVhpY5pf1ZS70FcS7tiaXx1mel4kAY6
j8VlkenGTrnHuewKa7hc7kmDtb1DFkrdt/Gu4rdynuPrxQT57MrCJ7phaKgeEFNL
Le9K3HIvTfOI/dK4S3ZhVKkPT8GDiRdlDvrNwVFmEvbvEDRTuDnLHRc6rM3wOL0Y
RoU+4zi2fHmSeADrQw48AIRjpDyeh0X7HbB3MYzbQ4a48eLaoy1A+MYOqTXfkUA9
nIXloKRtaSwNbnztYD6YDeuGsl/J3KEqcl5/ANmUbSJi9QaW+0093DsW4G2b9OER
qaDV6no/0hrgNU0sEGDo+PUy4k8ojZ/UR6pUKf+Oo3La5MuKqT58aYCGJe5DOQy3
bwzXPZEiXZQKPzyPwycRogIewELc4RU7t4PeomyRidxvujp4QPxbk/GWrNTPWjGk
2Nv7hVu44iNXEKj0UXwTytAomlvlLZMepNXnwQZdmBb2q+wpZ25Zj+SybGi07hNf
y3MKCBtqf4dZzU0iy7ME
=h8TG
-----END PGP SIGNATURE-----
--- End Message ---
