Your message dated Sun, 19 Jul 2015 19:51:42 +0000
with message-id <[email protected]>
and subject line Bug#786854: fixed in rsnapshot 1.4.0-1
has caused the Debian Bug report #786854,
regarding Incorrect quote handling breaks "--rsync-path" option in 
rsync_long_args
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
786854: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=786854
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Subject: rsnapshot: Incorrect quote handling breaks "--rsync-path" option in 
rsync_long_args
Package: rsnapshot
Version: 1.3.1-7
Severity: normal
Tags: upstream

Hi maintainer,

rsnapshot on jessie and sid (versions 1.3.1-4, 1.3.1-6, and 1.3.1-7) appear to
handle quotes in rsync_long_args incorrectly, preventing passing arguments
like:

    --rsync-path="sudo rsync"

...which makes many backup scenarios much harder.

I have attached an rsnapshot.conf which exhibits the problem. For
simplicity of testing, it tries to use --rsync-path="env rsync".

To test, change the backup point at the bottom to some server you have
access to and run `rsnapshot -v -c rsnapshot.conf sync`. Output should
be similar to:

    $ rsnapshot -vc rsnapshot.conf sync
    echo 4160 > /tmp/rsnapshot.pid
    /usr/bin/rsync -a --delete --numeric-ids --relative --delete-excluded \
        --rsync-path="env rsync" --rsh=/usr/bin/ssh ckuehl@supernova:~/bin \
        /tmp/backup/.sync/test/
    zsh:1: command not found: env rsync
    rsync: connection unexpectedly closed (0 bytes received so far) [Receiver]
    rsync error: error in rsync protocol data stream (code 12) at io.c(226) 
[Receiver=3.1.1]
    ----------------------------------------------------------------------------
    rsnapshot encountered an error! The program was invoked with these options:
    /usr/bin/rsnapshot -vc rsnapshot.conf sync
    ----------------------------------------------------------------------------
    ERROR: /usr/bin/rsync returned 12 while processing ckuehl@supernova:~/bin
    touch /tmp/backup/.sync/
    rm -f /tmp/rsnapshot.pid

The "zsh:1: command not found: env rsync" suggests over-quoting (the same
appears when using bash or dash as the shell).

The test case works fine in wheezy (version 1.3.1-3).

Many thanks!
Chris


-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.0.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages rsnapshot depends on:
ii  liblchown-perl  1.01-2+b1
ii  logrotate       3.8.7-2
ii  perl            5.20.2-6
ii  rsync           3.1.1-3

Versions of packages rsnapshot recommends:
ii  openssh-client [ssh-client]  1:6.7p1-6

rsnapshot suggests no packages.

-- no debconf information
config_version  1.2

cmd_cp          /bin/cp
cmd_rm          /bin/rm
cmd_rsync       /usr/bin/rsync
cmd_ssh /usr/bin/ssh
cmd_logger      /usr/bin/logger

rsync_long_args --delete --numeric-ids --relative --delete-excluded 
--rsync-path="env rsync"

sync_first      1

lockfile        /tmp/rsnapshot.pid

# backup root directory
snapshot_root   /tmp/backup/

# backup intervals (must be in ascending order)
retain          daily   7
retain          weekly  4
retain          monthly 6

# backup points/scripts
backup  ckuehl@supernova:~/bin  test/

--- End Message ---
--- Begin Message ---
Source: rsnapshot
Source-Version: 1.4.0-1

We believe that the bug you reported is fixed in the latest version of
rsnapshot, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guillaume Delacour <[email protected]> (supplier of updated rsnapshot package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 18 Jul 2015 14:03:05 +0000
Source: rsnapshot
Binary: rsnapshot
Architecture: source all
Version: 1.4.0-1
Distribution: unstable
Urgency: medium
Maintainer: Guillaume Delacour <[email protected]>
Changed-By: Guillaume Delacour <[email protected]>
Description:
 rsnapshot  - local and remote filesystem snapshot utility
Closes: 784650 786854
Changes:
 rsnapshot (1.4.0-1) unstable; urgency=medium
 .
   * New upstream release (Closes: #786854)
    + Retains renamed, provide helper migration script debian/rename_retains.sh
      and changes retains in debian/cron.d
    + Drop accepted or cherry picked patches:
      03_pod_missing_back.diff
      06_fix_random_file_verify.diff
      08_manpage_hourly_to_daily.diff
      09_strip_backtick.diff
      10_space_destdir.diff
      11_lvm_snapshots.diff
      12_include_conf_with_arguments.diff
      13_print_warn.diff
      14_rsync_rsh_quoting.diff
      16_configtest_manpage.diff
      17_linux_lvm_cmd_lvremove_silenced.diff
      19_cmd_postexec_umount.diff
   * Refresh debian/patches/18_rsnapreport_rsync_output.diff to remove "," in
     bytes rsync transfert output and required verbose level (Closes: #784650)
   * debian/docs: Use README.md instead of README, remove no more provided TODO
Checksums-Sha1:
 ea4bb4e3286f46da52002839745184fa36701251 2010 rsnapshot_1.4.0-1.dsc
 2ec77096fc75fd860434dd29b01c8e42cabde2f8 488785 rsnapshot_1.4.0.orig.tar.gz
 5c712768efcbe89f7a796d47d39ffea82d53f772 14612 rsnapshot_1.4.0-1.debian.tar.xz
 ab1301010678d75ab9767f8ec63c4c039068132a 130036 rsnapshot_1.4.0-1_all.deb
Checksums-Sha256:
 11a6af9a5616692e8376282eac0b0e9bf4b8ad0106c51eb94d7ec727c2b58c6d 2010 
rsnapshot_1.4.0-1.dsc
 222574fee2f59d0e3ef5da6e6dd0f445205fecfa7ca12ef821eb8a89cf4f2ca8 488785 
rsnapshot_1.4.0.orig.tar.gz
 f0b7d7e5f902c241dabccc0d44591cf5bde7a72081260bb318858155d74cbd77 14612 
rsnapshot_1.4.0-1.debian.tar.xz
 5042d987565b78682a7c1f51aaf057c47dce1ca1c9edc6d21feab84281e0279a 130036 
rsnapshot_1.4.0-1_all.deb
Files:
 6bb4351297ae54dbc2c37b9e9f91a818 2010 utils optional rsnapshot_1.4.0-1.dsc
 4011768eb6ec122a0f9479275ed64a27 488785 utils optional 
rsnapshot_1.4.0.orig.tar.gz
 97cd040828dbd2e30f47c7690dc26f0b 14612 utils optional 
rsnapshot_1.4.0-1.debian.tar.xz
 d4b2ff33a73891cd4c1d29fefc54fdae 130036 utils optional 
rsnapshot_1.4.0-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Signed by Ana Guerrero

iQIcBAEBCAAGBQJVq/x8AAoJELNGT4lqoVlIBbcQAMCXHMYszPrWNJYwPKAsi3KA
YW/2aHbk5icIfejEsyerH8QKeNx5v+fg4RhUUzbPeXruuE56IhCO5azb8PrStIgE
JdfxuXXj3VylHWkufRiQWmFFFAR/Y388f3pCB6eIGN1qixMwwg6toearZIvibaMX
JX7kPEPwpxabCsEsisUWH3nmRK09IKxz5q+oB4MVwLLNCrdSQNra8VN7ewmbJlKm
o+sFO1oqpUCV7klEviCZosxFfS4oRcwLBCbJy8+Uv/mytQCLPj9EpYCBrB9/rsEW
PtCmF8A6EK4MqqNLHLSLKOFRO+Gead3DuRiov005vM3NItfJS2brfBhXaZki4rTD
vAU0hlhhYkEEHolMcJTu+liyR4jfv4cBustcHTnnIbuFZD672gD+QgpCmn0kvdOT
NnTKzLi8zbvVwwV6S5TcazAe5GP+HdK+rO7QxPiuKq/ZHaBa5Y4FBda+RxIpsTeI
ThSiRfD7GJEwzTVyNmitvH6fZoJW9YJtbP/EN1FeQLwrMhSDWvw5U2KTTrkU/SnJ
tZVgs3W4RLB3iegGQQIk3DKwfrYrnPwHfcuphkBWJFVIKyrJc8gmNGgG1iR6szpb
1KNz82bY2Z/y+enautUdPQuNk/MbYf1zGUomgX4i5EKrxeg68W6kK7PfI+qkZkqU
jKYW01wyLo4Q6Agdfqzs
=+I+1
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to