Your message dated Sat, 14 Sep 2019 16:49:54 +0000
with message-id <[email protected]>
and subject line Bug#910012: fixed in python3-antlr3 3.5.2-6
has caused the Debian Bug report #910012,
regarding python3-antlr3: Please remove unnecessary overrides
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
910012: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=910012
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: python3-antlr3
Version: 3.5.2-5
Severity: normal
Tags: patch

Hi,

Hi,

The debian/rules file appears to include a suspiciously high number of
dh_override_-style overrides.

It is likely that is this was intended to optimise package builds by
introducing "no-op" overrides that avoid specific debhelper commands.

However, whilst using overrides are not a problem per-se, such a list
is usually a premature optimisation, subject to constant revision,
prevents future debhelper versions fixing archive-wide problems, adds
unnecessary noise/distraction for anyone reviewing the package,
increases the package's "bus factor" and is typically a premature
optimisation. It is, in addition, aesthetically displeasing.

Please remove the unnecessary overrides. A patch is attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-
diff --git a/debian/rules b/debian/rules
index 107c572..9ef1eeb 100755
--- a/debian/rules
+++ b/debian/rules
@@ -31,13 +31,3 @@ override_dh_auto_clean:
 override_dh_clean:
        dh_clean
        rm -rf build
-
-# Commands not to run
-override_dh_installcatalogs:
-override_dh_installemacsen override_dh_installifupdown:
-override_dh_installinfo override_dh_installmenu override_dh_installmime:
-override_dh_installmodules override_dh_installlogcheck:
-override_dh_installpam override_dh_installppp override_dh_installudev 
override_dh_installwm:
-override_dh_installxfonts override_dh_gconf override_dh_icons override_dh_perl 
override_dh_usrlocal:
-override_dh_installcron override_dh_installdebconf:
-override_dh_installlogrotate override_dh_installgsettings:

--- End Message ---
--- Begin Message ---
Source: python3-antlr3
Source-Version: 3.5.2-6

We believe that the bug you reported is fixed in the latest version of
python3-antlr3, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Goirand <[email protected]> (supplier of updated python3-antlr3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 14 Sep 2019 18:29:11 +0200
Source: python3-antlr3
Architecture: source
Version: 3.5.2-6
Distribution: unstable
Urgency: medium
Maintainer: Debian OpenStack <[email protected]>
Changed-By: Thomas Goirand <[email protected]>
Closes: 910012
Changes:
 python3-antlr3 (3.5.2-6) unstable; urgency=medium
 .
   [ Ondřej Nový ]
   * d/control: Use [email protected] as maintainer
   * Use debhelper-compat instead of debian/compat.
 .
   [ Thomas Goirand ]
   * Remove unecessary overrides (Closes: #910012).
   * Using pkgos-dh_auto_install and re-order debian/rules.
Checksums-Sha1:
 6bdf3175ec9a29d4ac8eb8bfe33b2f4a729369a0 2115 python3-antlr3_3.5.2-6.dsc
 4e0f3b1fd85f77e2d13d824b784848123faaaaef 11500 
python3-antlr3_3.5.2-6.debian.tar.xz
 7e5f6cfd34b5b2e8128165973fe2c6af7a3efedd 6210 
python3-antlr3_3.5.2-6_amd64.buildinfo
Checksums-Sha256:
 b814325d09b199a01fb10abcaf1fe6cd905b261fc2bd45ec423c7effa7e73d82 2115 
python3-antlr3_3.5.2-6.dsc
 afa1b2c404d84589bf08190cd2d7c95b582df6f53b51632f6f6ff223fc54f431 11500 
python3-antlr3_3.5.2-6.debian.tar.xz
 ad159e985afc052cb6bd330237a75d42a41d84950f9e928a22520e6d716a1f22 6210 
python3-antlr3_3.5.2-6_amd64.buildinfo
Files:
 1acaa4d4f45c2185af3229c18bc50167 2115 python optional 
python3-antlr3_3.5.2-6.dsc
 62c2a4fa8e731479dce4d7d15426de26 11500 python optional 
python3-antlr3_3.5.2-6.debian.tar.xz
 943e4d908884dc0233089c378dc9ed89 6210 python optional 
python3-antlr3_3.5.2-6_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoLGp81CJVhMOekJc1BatFaxrQ/4FAl19FggACgkQ1BatFaxr
Q/5Jug/8DqxLUr5N5mh6DvagBEyku05GcyQh8z/76R8DXzNIq8mCylz/WAh8Exrk
/E3xUnP+fJ1YZjfYdtrmdC0omCJL9pgt9fLzSdfwdYTD4x5XK0F2EaHG41l7rIkU
Oi52XrjddTBQQgglqTPlXlUalZfLrSV7Ax7C6J4FS3X/zXCXe8dRy9JUaAmCe+mH
0CmX8YPlPQoxAx3hYvChmyZnxcFlbR9N5zRVZ8oLqgfpIJHFvV2crq67SqIHXmAu
kd6uVa5n3a8YP2n9nKYtWGhA3PFfySopn2elhH3pnbIhFPd/Hrm7xoMUWGOacqeQ
+lBUoSuS1id0VSt4rxuxZl2vVz9D32h9RzfaWg7eqW7P1j/8g7TrkIdD5b8ipl2C
9aHMm+h9nC3ofBq5VlVUOl4xmCHKjAn85O2RLEdt5voNJEaLFZqE4aMB3y5W+TY3
2/2CcO0bsfNN9CAoUUKEG1yJNJTtUXwSwAo5mBwQBMf0oAQt1atM+L3UgKVMheU9
pbWk72tcS2CBqNFYuUgqhSd8E42ApgMAA78ASc9f1cWcV//zFJ5xcdxDNruvBjwo
b1VTFtvKnJl3XjUmx84LSW6kHu6OnC8s0l9odGLRY+JFAfV13H7o2Z1X9H1PQ9Zj
KYAkQ+gC9J5DbSqPMh3O0X1FB+lIReShvOrTU84Ec7anfAlRz8w=
=kVPU
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to