Your message dated Thu, 26 Sep 2019 23:19:24 +0000 with message-id <[email protected]> and subject line Bug#939971: fixed in runit 2.1.2-34 has caused the Debian Bug report #939971, regarding runit: Export NAME and add a VERBOSE option to invoke-run to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 939971: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=939971 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: runit Version: 2.1.2-34 Severity: normal Tags: patch Hi, as discussed in #935958 it's inconvenient to print messages like 'starting foo' or 'stopping foo' by default, as they are written to the service log. The attached patch does the following: * add support for a VERBOSE option to invoke run: the value is sourced from /etc/default/runit file (off by default) and can be overridden for each service placing a file in /etc/sv/<service>/conf/ * export the NAME variable in invoke-run * add a system-wide file to be sourced for runit services the verbose option should be tested in runscripts like if [ "$VERBOSE" = 1 ]; then echo "runsv: starting $NAME..." fi I'm not sure using /etc/default path (rather than /etc/runit) is appropriate; file there are usually meant for daemons but there are exceptions (I have a Grub directory there). Lorenzo -- System Information: Debian Release: bullseye/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 4.20.3-van (SMP w/4 CPU cores; PREEMPT) Kernel taint flags: TAINT_OOT_MODULE Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: runit (via /run/runit.stopit) Versions of packages runit depends on: ii libc6 2.28-10 ii sysuser-helper 1.3.3 Versions of packages runit recommends: ii runit-init 2.1.2-34 runit suggests no packages. -- Configuration Files: /etc/runit/3 changed [not included] -- no debconf information -- debsums errors found: debsums: changed file /lib/runit/invoke-run (from runit package)>From 354706b5eac44d35814eb584c1b0272995f441ff Mon Sep 17 00:00:00 2001 From: Lorenzo Puliti <[email protected]> Date: Tue, 10 Sep 2019 16:31:53 +0200 Subject: [PATCH] invoke-run: add verbose option and export NAME Export `NAME` variable and add a `VERBOSE` option into invoke-run interpreter. Also add a runit default file for system wide setting about runit services. --- debian/contrib/lib/invoke-run | 8 ++++++++ debian/runit.default | 4 ++++ 2 files changed, 12 insertions(+) create mode 100644 debian/runit.default diff --git a/debian/contrib/lib/invoke-run b/debian/contrib/lib/invoke-run index b3b0c55..b0f6ef6 100755 --- a/debian/contrib/lib/invoke-run +++ b/debian/contrib/lib/invoke-run @@ -31,6 +31,8 @@ case "${runscript}" in esac readonly runscript service +export NAME=$service + if [ -f "/etc/sv/${service}/.meta/installed" ] ; then readonly installed="/usr/share/runit/meta/${service}/installed" # uninstalled, but not purged. See #929693 and commit [4c485b] @@ -49,6 +51,12 @@ if [ -r "/etc/default/${service}" ] ; then set +a -u fi +if [ -r /etc/default/runit ]; then + set -a + . /etc/default/runit + set +a +fi + readonly initscript="/etc/init.d/${service}" readonly noreplace="/usr/share/runit/meta/${service}/noreplace" diff --git a/debian/runit.default b/debian/runit.default new file mode 100644 index 0000000..26d057e --- /dev/null +++ b/debian/runit.default @@ -0,0 +1,4 @@ +# system wide setting for runit services + +# print runsv messages about starting and stopping the service +VERBOSE=0 -- 2.23.0
--- End Message ---
--- Begin Message ---Source: runit Source-Version: 2.1.2-34 We believe that the bug you reported is fixed in the latest version of runit, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Dmitry Bogatov <[email protected]> (supplier of updated runit package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Wed, 25 Sep 2019 21:23:50 +0000 Source: runit Architecture: source Version: 2.1.2-34 Distribution: unstable Urgency: medium Maintainer: Dmitry Bogatov <[email protected]> Changed-By: Dmitry Bogatov <[email protected]> Closes: 933078 939971 Changes: runit (2.1.2-34) unstable; urgency=medium . [ Dmitry Bogatov ] * Add series of patches to implement force-rescan feature (Closes: #933078) * Fix 1 second delay in forced rescan implementation . [ Lorenzo Puliti ] * update-service: move supervise directories in tmpfs * invoke-run: add verbose option and export NAME (Closes: #939971) Checksums-Sha1: eb8ee6dfabec5bc387befe12495f7d5ec3cf561d 2221 runit_2.1.2-34.dsc 2f0144a86b3cb41f99cdc6c0454d68b661b13336 40332 runit_2.1.2-34.debian.tar.xz 814e4895a9f186bf17222090cdb2072bcbab2f75 6015 runit_2.1.2-34_source.buildinfo Checksums-Sha256: 2f36d36a3e3a3d8d69e8602d96bde0cd5c3b3d4c4c014f34f82a6b6c3471d159 2221 runit_2.1.2-34.dsc 54432249369e6b80411f3b48b9b9bdfd311757e0e0d73d6303b716a05de775cc 40332 runit_2.1.2-34.debian.tar.xz feca83848f8b7db5f49ef304d12ac219d0c5a4d651a466af3bd903b7b9e14a42 6015 runit_2.1.2-34_source.buildinfo Files: f2bfb2613e401ea7849379d3cf2730cf 2221 admin optional runit_2.1.2-34.dsc e8e6247f005217bf8a245a2fdff8b1a4 40332 admin optional runit_2.1.2-34.debian.tar.xz 4db83656099391239799d144450985ce 6015 admin optional runit_2.1.2-34_source.buildinfo -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAxFiEEhnHVzDbtdH7ktKj4SBLY3qgmEeYFAl2NQmgTHGthY3Rpb25A ZGViaWFuLm9yZwAKCRBIEtjeqCYR5tI4D/9auz8e1pYIauCz2X+yUPoLb6JemWZo Km/UDmCJqpiwGFV8+Pz5Kc2FuU2l1gTGCiWRNpkOCzQb79cRSMKMKq4ezaCSvHDM bD01r7q6PRbknsNFypSJhTopv2Ps5a6NBwIe9J81XAMaexaDPB3jz+GjAoZBgWRd Pp1K4IgpArLhMpqa23z23nlN4vfTMhztAram/F2QyBffW3T4TStz/5ViYHAxko5s 6IA2jZPuqswPmZScxL/p8ufQo6tUbfLB4Jhg/4CW3NyblNTRMpJDHVLp23nRMcXn 06ypY7GAAKiQxnmFVwmPMCSaEuYQ/N09XBLA8jYWCJ4bFP4nBO+h0lEw4IubAyoP JsttHIDOMy8WOlzfBltXwhpg3YD9I6lBnPX+gJw1JUsUHj36DCDi/8FfuQnLJejv koUcnkF5vPyUqcmPrs4+bQFncehKiAupHZUfqq36TFkUKARzOHJGal5tRtEPi5YV 9xkWkWq18WLtYojAcejlssBxfWPI6m9yDhBkS2c57XpAfIJSAi5f9tFMesbh0EzE rNKXSTP3fUPDPFEddxQa6t11+8FaemZxRJzLD6FhL5WIjVn+uGfL3VZ/8LAH0A8e 5uFEPqhmg1hjEoJB8jr4hgkqE4BWB61UlBZUXbmbIl0Xm2CtqznMz8CYWEqjlDj6 6PXxUSrFEiXiyA== =HmGo -----END PGP SIGNATURE-----
--- End Message ---
