Your message dated Fri, 27 Sep 2019 23:36:48 +0000 with message-id <[email protected]> and subject line Bug#939971: fixed in runit 2.1.2-35 has caused the Debian Bug report #939971, regarding runit: Export NAME and add a VERBOSE option to invoke-run to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 939971: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=939971 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: runit Version: 2.1.2-34 Severity: normal Tags: patch Hi, as discussed in #935958 it's inconvenient to print messages like 'starting foo' or 'stopping foo' by default, as they are written to the service log. The attached patch does the following: * add support for a VERBOSE option to invoke run: the value is sourced from /etc/default/runit file (off by default) and can be overridden for each service placing a file in /etc/sv/<service>/conf/ * export the NAME variable in invoke-run * add a system-wide file to be sourced for runit services the verbose option should be tested in runscripts like if [ "$VERBOSE" = 1 ]; then echo "runsv: starting $NAME..." fi I'm not sure using /etc/default path (rather than /etc/runit) is appropriate; file there are usually meant for daemons but there are exceptions (I have a Grub directory there). Lorenzo -- System Information: Debian Release: bullseye/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 4.20.3-van (SMP w/4 CPU cores; PREEMPT) Kernel taint flags: TAINT_OOT_MODULE Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: runit (via /run/runit.stopit) Versions of packages runit depends on: ii libc6 2.28-10 ii sysuser-helper 1.3.3 Versions of packages runit recommends: ii runit-init 2.1.2-34 runit suggests no packages. -- Configuration Files: /etc/runit/3 changed [not included] -- no debconf information -- debsums errors found: debsums: changed file /lib/runit/invoke-run (from runit package)>From 354706b5eac44d35814eb584c1b0272995f441ff Mon Sep 17 00:00:00 2001 From: Lorenzo Puliti <[email protected]> Date: Tue, 10 Sep 2019 16:31:53 +0200 Subject: [PATCH] invoke-run: add verbose option and export NAME Export `NAME` variable and add a `VERBOSE` option into invoke-run interpreter. Also add a runit default file for system wide setting about runit services. --- debian/contrib/lib/invoke-run | 8 ++++++++ debian/runit.default | 4 ++++ 2 files changed, 12 insertions(+) create mode 100644 debian/runit.default diff --git a/debian/contrib/lib/invoke-run b/debian/contrib/lib/invoke-run index b3b0c55..b0f6ef6 100755 --- a/debian/contrib/lib/invoke-run +++ b/debian/contrib/lib/invoke-run @@ -31,6 +31,8 @@ case "${runscript}" in esac readonly runscript service +export NAME=$service + if [ -f "/etc/sv/${service}/.meta/installed" ] ; then readonly installed="/usr/share/runit/meta/${service}/installed" # uninstalled, but not purged. See #929693 and commit [4c485b] @@ -49,6 +51,12 @@ if [ -r "/etc/default/${service}" ] ; then set +a -u fi +if [ -r /etc/default/runit ]; then + set -a + . /etc/default/runit + set +a +fi + readonly initscript="/etc/init.d/${service}" readonly noreplace="/usr/share/runit/meta/${service}/noreplace" diff --git a/debian/runit.default b/debian/runit.default new file mode 100644 index 0000000..26d057e --- /dev/null +++ b/debian/runit.default @@ -0,0 +1,4 @@ +# system wide setting for runit services + +# print runsv messages about starting and stopping the service +VERBOSE=0 -- 2.23.0
--- End Message ---
--- Begin Message ---Source: runit Source-Version: 2.1.2-35 We believe that the bug you reported is fixed in the latest version of runit, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Dmitry Bogatov <[email protected]> (supplier of updated runit package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Fri, 27 Sep 2019 23:19:30 +0000 Source: runit Architecture: source Version: 2.1.2-35 Distribution: unstable Urgency: medium Maintainer: Dmitry Bogatov <[email protected]> Changed-By: Dmitry Bogatov <[email protected]> Closes: 933078 939971 941273 Changes: runit (2.1.2-35) unstable; urgency=medium . * Temporary disable forced-rescan test (Closes: #941273) . runit (2.1.2-34) unstable; urgency=medium . [ Dmitry Bogatov ] * Add series of patches to implement force-rescan feature (Closes: #933078) * Fix 1 second delay in forced rescan implementation . [ Lorenzo Puliti ] * update-service: move supervise directories in tmpfs * invoke-run: add verbose option and export NAME (Closes: #939971) Checksums-Sha1: ba3bd305748048a77f4115840e503485b10f7b53 2221 runit_2.1.2-35.dsc 4045d51a984b694c727be7787b048feba3c16378 40416 runit_2.1.2-35.debian.tar.xz e4b2de488679b0aeab7b788424139cb436165a87 6015 runit_2.1.2-35_source.buildinfo Checksums-Sha256: 853f93541f88ce7ea070379a0ada19b11fd9f18ff0fc50550e891925d0584359 2221 runit_2.1.2-35.dsc 043bb18dec013c82ba499f8d2189b8e6eb0bf8540187a2b590d3bed8ba3775b9 40416 runit_2.1.2-35.debian.tar.xz a5f7f6192627ffd73be88428bef418391cde64cacb50f7f7ad40c26d355c0f4f 6015 runit_2.1.2-35_source.buildinfo Files: 1fbe2c59b520ad92a75e47dbfb9b56bc 2221 admin optional runit_2.1.2-35.dsc e3dd03c290826e03e93ed14a7f1c100b 40416 admin optional runit_2.1.2-35.debian.tar.xz 81c222aab5261d4ff0ac1ec0419f3a10 6015 admin optional runit_2.1.2-35_source.buildinfo -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAxFiEEhnHVzDbtdH7ktKj4SBLY3qgmEeYFAl2OmSgTHGthY3Rpb25A ZGViaWFuLm9yZwAKCRBIEtjeqCYR5u0UD/97bnqQ/zcuv3I5DlMqNHLY3gUqKXPq E4kuTLZhgBcFenr43yRQOtTJu5dFX1PxU9frGMKekDvvyDiEVoBEB8Tz5nkvKGA4 6vUCHEl8JxwIZ1wOw2VOazofc9GAMB9mDD74NN+bjjlcuDPdsiyrCUiqdoVrDgKI +LVA5zfOsiKgsGyFbEWY3ACA4g8TR9+GkXSz0qHxw7V3dAHG0hTTlDhXIHN9MjQl 5+GdFs/8gTDy7OPNih/WcYhVLTqNmSIZZntHN9DGhqWhpC/DuS/1vQygZv5EUcUQ nRQAW+N9PDBZqI2rePJgeUvXnMn8G/lsPp1Wqw2UOa7xk202t7+5XgUuvstb7hxp d1qHkjQCnIJG0puzdG9x2d433TRQtypmQwAWcM5T6YuTAti3KXfAZqJ7Rxpi0BcF b0ORz5LT+wkmRIRV8acgg7Nu0oWSkMYbnDknOrNbintOd8mzrUkO0MMSH9JYY4RY 6InX/ZbdRWOeXncJ88titEKHqXh2ukzjAANFIF2nUWZStlXUl8OaiAo0jhW9mDEe KlvRxOouB1eTzlcQQhHERzd4vHOqlqZ5AfoPZyx21uxS7TIiQkAnnQpHIW62LCz1 koB66kA8Fp4Ss38GB5hNm4dl/x6h9z7QzCva5dvHBGz1HqtKm6xjRWEkqSHbWJu/ PKs86YHl2PYS9Q== =bONw -----END PGP SIGNATURE-----
--- End Message ---
