Your message dated Sat, 14 Mar 2020 13:08:49 +0000 with message-id <[email protected]> and subject line Bug#943397: fixed in runit 2.1.2-36 has caused the Debian Bug report #943397, regarding runit: Add a finish-default to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 943397: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943397 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: runit Version: 2.1.2-35 Severity: normal As discussed in #934231 [Dmitry Bogatov] >> create mode 100644 debian/anacron.runscript/finish > There is nothing in this script specific to anacron. I propose > following: > > * add this finish script into bin:runit as /lib/runit/finish-default or > something like this. > > * document error codes (161, 160, -1, etc) in invoke-run manpage. > > * modify dh_runit to generate finish script with following content: > > #!/bin/sh > /lib/runit/finish-default > > Not sure should it be default or yet-another option. > > This is more work initially, but will make improvements to finish script > transparent (just upgrade bin:runit), should need appear and avoid > copy-paste work for future runscripts. I'm testing the following -------------------------------- $cat /lib/runit/finish-default #!/bin/sh # no need to sv d service here, runsv will stop trying after the first attempt to start [ $1 = -1 ] && echo "runsv: ERROR $1 in $NAME: unexpected error or wrong sh syntax" [ $1 = 161 ] && echo "runsv: ERROR $1 in $NAME: disabled by local settings" \ && sv d $NAME && exit 0 [ $1 = 162 ] && echo "runsv: ERROR $1 in $NAME: configtest or early setup failed" \ && sv d $NAME && exit 0 [ $1 = 170 ] && echo "runsv: ERROR $1 in $NAME: a runtime hard dependecy is missing" \ && sv d $NAME && exit 0 exit 0 -------------------------------- to be used with a finish file like ---------------------------------- cat /etc/sv/ssh/finish #!/bin/sh set -e . /etc/default/runit export NAME=$(dirname $0) /lib/runit/finish-default "$1" "$2" if [ "$VERBOSE" = 1 ]; then echo "runsv: $NAME stopped" fi ------------------------------------- As you can see, there is still some non-service specific code, but I don't know how to export the NAME inside the sourced script, is it feasible in dash/POSIX? Also some daemon may need specific code between /lib/runit/finish-default "$1" "$2" and if [ "$VERBOSE" = 1 ]; then Examples: get some daemon specific exit codes, clean up PID file... It is not mandatory to have the 'echo' after this specific code but it's better so i know that all code it's been executed correctly. I will wait for your comment and then write a proper patch, also documenting exit codes in manpage. Lorenzo -- System Information: Debian Release: bullseye/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 4.20.3-van (SMP w/4 CPU cores; PREEMPT) Kernel taint flags: TAINT_OOT_MODULE Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: runit (via /run/runit.stopit) Versions of packages runit depends on: ii libc6 2.29-2 ii sysuser-helper 1.3.3 Versions of packages runit recommends: ii runit-init 2.1.2-35 runit suggests no packages. -- Configuration Files: /etc/default/runit changed [not included] /etc/runit/3 changed [not included] -- no debconf information -- debsums errors found: debsums: changed file /lib/runit/invoke-run (from runit package) debsums: changed file /sbin/update-service (from runit package)
--- End Message ---
--- Begin Message ---Source: runit Source-Version: 2.1.2-36 Done: Lorenzo Puliti <[email protected]> We believe that the bug you reported is fixed in the latest version of runit, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Lorenzo Puliti <[email protected]> (supplier of updated runit package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Thu, 27 Feb 2020 12:12:07 +0100 Source: runit Architecture: source Version: 2.1.2-36 Distribution: unstable Urgency: medium Maintainer: Lorenzo Puliti <[email protected]> Changed-By: Lorenzo Puliti <[email protected]> Closes: 942320 943395 943397 Changes: runit (2.1.2-36) unstable; urgency=medium . * Use dot-symlink to mark a service as disabled (Closes: #942320) * Minor improvements to invoke-run (Closes: #943395) * Add finish-default (Closes: #943397) * Update invoke-run manpage for finish-default * Bump Standards Version to 4.5.0: - Create '_runit-log' user * New maintainer * Add a lintian override for runit Checksums-Sha1: 85821d655cba705b2726a0f3e5d51380278092ff 2194 runit_2.1.2-36.dsc 7e6d1105a28514b6d5fb5f3c510ca3f9f93ceec7 41644 runit_2.1.2-36.debian.tar.xz 16ae2aa45a6bdbf0d0cc856831a3c0c9a7328db0 5682 runit_2.1.2-36_source.buildinfo Checksums-Sha256: 12d853f98f6b2076816f6282b83ca1147253241ed4fb011ee874f2d54e9d7b91 2194 runit_2.1.2-36.dsc abdf9d3cbe8912339b39f15ce20e9dc6cb9a8b2ffa1f94a32784a40392abc1ac 41644 runit_2.1.2-36.debian.tar.xz b7c759c49c8502b72399573fe7c091bb8f95ddf385bcb6d96d3c4b7907a7f7fa 5682 runit_2.1.2-36_source.buildinfo Files: e1cbf4f867bbcac997d713c4f267db91 2194 admin optional runit_2.1.2-36.dsc 41a8eeeca0cff64bc193c6ef72b3a261 41644 admin optional runit_2.1.2-36.debian.tar.xz 3c1b2f34e8f7c1d98ab8a378ac570af3 5682 admin optional runit_2.1.2-36_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAl5s01cACgkQweDZLphv fH5Ucg/+Kbz5AZ2ApTtnUoc3YbkPs3rFNhdYV8XczAU5rHVk9lV/5ChOcpc4ls9B nB2j0ofq7Dm/4D8tGUcaZ86m8CefBjfSI+aRs0btFUcMH0yuGn3m9kBKKgzYj3GK Nfcm79L86qpAE77LsSGVFw6EhoSwn7SRw3Ezo0/9LhqNFrVyJ3cT0MoYvQVve1RL o0J6U/juOt7bE5nExTxQ5A9FLSl2kfMjE0JmkvnBF7Hd96x97uEljgQMWg3YslY2 E9BkNR7G7qxULwSvMioWCGhEycang1NHZ4pDYM7zZ/AgXacUntkaCI8D9mtlCZ7l zaeKxd2oNxf390Z2g/sm6wfZW6+jD40kCv7Or25NhfB63tOLGgzxyO7/ON3W6Fae BVmCxL/mLKpoXSRLnm8+AmEdOBCCyevXuANYSCmTHbE3GuyS9nVZ6u4qUnpY4R4n uF/s0DHr2/dGdS+PImagpcC63ipsyeauyPmS5YOd92dVHPK3UdjFB+eyRsBMIAfI lPUZoEmWFByniN7N8tkiMvAm7wuW4zKrIinHexrjGgSsftfJOOPY1urhZQl0kGk2 MYKVNiuE5OHY1QmITY6j5796jp0FNyV3o9GMZPqQaX2OVjyLia4/wg+TQGl4GCAN WIX1e5dRVncFPQ1sV5bXZbD5efsI6pR9gvdpMSlPNijeLbocPvA= =b7sF -----END PGP SIGNATURE-----
--- End Message ---
