Your message dated Sat, 14 Mar 2020 13:08:48 +0000
with message-id <[email protected]>
and subject line Bug#942320: fixed in runit 2.1.2-36
has caused the Debian Bug report #942320,
regarding update-service: use .symlink to mark a service as disabled
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
942320: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=942320
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: runit
Version: 2.1.2-35
Severity: wishlist
Tags: patch
Hi,
this is to be consistent with a patch that I'm about to send
for dh-runit.
The attached patch here makes update-service create a .symlink
rather than just removing the symlink to disable a service.
This will help in preserving local admin choice to keep a service disabled.
I've added some detail in the man page but I hope to provide some more
detailed info in update-rc.d man page as runit support is merged there.
Lorenzo
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 4.20.3-van (SMP w/4 CPU cores; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: runit (via /run/runit.stopit)
Versions of packages runit depends on:
ii libc6 2.29-2
ii sysuser-helper 1.3.3
Versions of packages runit recommends:
ii runit-init 2.1.2-35
runit suggests no packages.
-- Configuration Files:
/etc/default/runit changed [not included]
/etc/runit/3 changed [not included]
-- no debconf information
-- debsums errors found:
debsums: changed file /sbin/update-service (from runit package)
>From d6369d7e8cfee3473f525940aa02a1d846090671 Mon Sep 17 00:00:00 2001
From: Lorenzo Puliti <[email protected]>
Date: Mon, 14 Oct 2019 13:47:30 +0200
Subject: [PATCH] Use dot-symlink to mark a service as disabled
When removing a service with update-service, replace 'service'
with a '.service' symlink rather than removing the symlink.
This is done to preserve the local admin choice to disable a
service.
---
debian/contrib/update-service | 4 ++++
debian/contrib/update-service.8 | 20 ++++++++++++++++++++
2 files changed, 24 insertions(+)
diff --git a/debian/contrib/update-service b/debian/contrib/update-service
index 7e72501..d393b78 100644
--- a/debian/contrib/update-service
+++ b/debian/contrib/update-service
@@ -70,6 +70,9 @@ case "$opt" in
ln -s /var/lib/runit/log/supervise/"$sv" "$svdir"/log/supervise
fi
fi
+ if [ -d "$servicedir"/."$sv" ]; then
+ rm "$servicedir"/."$sv"
+ fi
ln -s "$svdir" "$servicedir"/"$sv"
printf '%s\n' "Service $sv added."
exit 0
@@ -85,6 +88,7 @@ case "$opt" in
test "$relsymdir"/"$sv" = "$(readlink "$servicedir"/"$sv")" ||
fatal "$servicedir/$sv does not point to $svdir."
rm -f "$servicedir"/"$sv"
+ ln -s "$svdir" "$servicedir"/."$sv"
printf '%s %s\n' \
"Service $sv removed," \
"the service daemon received the TERM and CONT signals."
diff --git a/debian/contrib/update-service.8 b/debian/contrib/update-service.8
index a45e113..e8686a8 100644
--- a/debian/contrib/update-service.8
+++ b/debian/contrib/update-service.8
@@ -89,6 +89,26 @@ program to control the removed service, or query its status,
e.g.:
# sv status
.I service-directory
+When the service directory
+.IR service-directory
+is removed, the service
+.I service-name
+will be marked as disabled by creating a
+.I .service-name
+symlink. This will prevent tools like
+.BR dh_runit (1)
+and runit-helper from auto-enabling
+.I service-name
+at install or upgrade of the package that ships
+.IR service-directory .
+The
+.I .service-name
+symlink will be removed as the
+.IR service-directory
+is added again to the system-wide service supervision or when the package that
ships
+.IR service-directory
+is purged.
+
.TP
.B \--list | \-l
If
--
2.23.0
--- End Message ---
--- Begin Message ---
Source: runit
Source-Version: 2.1.2-36
Done: Lorenzo Puliti <[email protected]>
We believe that the bug you reported is fixed in the latest version of
runit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Lorenzo Puliti <[email protected]> (supplier of updated runit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 27 Feb 2020 12:12:07 +0100
Source: runit
Architecture: source
Version: 2.1.2-36
Distribution: unstable
Urgency: medium
Maintainer: Lorenzo Puliti <[email protected]>
Changed-By: Lorenzo Puliti <[email protected]>
Closes: 942320 943395 943397
Changes:
runit (2.1.2-36) unstable; urgency=medium
.
* Use dot-symlink to mark a service as disabled (Closes: #942320)
* Minor improvements to invoke-run (Closes: #943395)
* Add finish-default (Closes: #943397)
* Update invoke-run manpage for finish-default
* Bump Standards Version to 4.5.0:
- Create '_runit-log' user
* New maintainer
* Add a lintian override for runit
Checksums-Sha1:
85821d655cba705b2726a0f3e5d51380278092ff 2194 runit_2.1.2-36.dsc
7e6d1105a28514b6d5fb5f3c510ca3f9f93ceec7 41644 runit_2.1.2-36.debian.tar.xz
16ae2aa45a6bdbf0d0cc856831a3c0c9a7328db0 5682 runit_2.1.2-36_source.buildinfo
Checksums-Sha256:
12d853f98f6b2076816f6282b83ca1147253241ed4fb011ee874f2d54e9d7b91 2194
runit_2.1.2-36.dsc
abdf9d3cbe8912339b39f15ce20e9dc6cb9a8b2ffa1f94a32784a40392abc1ac 41644
runit_2.1.2-36.debian.tar.xz
b7c759c49c8502b72399573fe7c091bb8f95ddf385bcb6d96d3c4b7907a7f7fa 5682
runit_2.1.2-36_source.buildinfo
Files:
e1cbf4f867bbcac997d713c4f267db91 2194 admin optional runit_2.1.2-36.dsc
41a8eeeca0cff64bc193c6ef72b3a261 41644 admin optional
runit_2.1.2-36.debian.tar.xz
3c1b2f34e8f7c1d98ab8a378ac570af3 5682 admin optional
runit_2.1.2-36_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAl5s01cACgkQweDZLphv
fH5Ucg/+Kbz5AZ2ApTtnUoc3YbkPs3rFNhdYV8XczAU5rHVk9lV/5ChOcpc4ls9B
nB2j0ofq7Dm/4D8tGUcaZ86m8CefBjfSI+aRs0btFUcMH0yuGn3m9kBKKgzYj3GK
Nfcm79L86qpAE77LsSGVFw6EhoSwn7SRw3Ezo0/9LhqNFrVyJ3cT0MoYvQVve1RL
o0J6U/juOt7bE5nExTxQ5A9FLSl2kfMjE0JmkvnBF7Hd96x97uEljgQMWg3YslY2
E9BkNR7G7qxULwSvMioWCGhEycang1NHZ4pDYM7zZ/AgXacUntkaCI8D9mtlCZ7l
zaeKxd2oNxf390Z2g/sm6wfZW6+jD40kCv7Or25NhfB63tOLGgzxyO7/ON3W6Fae
BVmCxL/mLKpoXSRLnm8+AmEdOBCCyevXuANYSCmTHbE3GuyS9nVZ6u4qUnpY4R4n
uF/s0DHr2/dGdS+PImagpcC63ipsyeauyPmS5YOd92dVHPK3UdjFB+eyRsBMIAfI
lPUZoEmWFByniN7N8tkiMvAm7wuW4zKrIinHexrjGgSsftfJOOPY1urhZQl0kGk2
MYKVNiuE5OHY1QmITY6j5796jp0FNyV3o9GMZPqQaX2OVjyLia4/wg+TQGl4GCAN
WIX1e5dRVncFPQ1sV5bXZbD5efsI6pR9gvdpMSlPNijeLbocPvA=
=b7sF
-----END PGP SIGNATURE-----
--- End Message ---
