Your message dated Sat, 2 May 2020 16:45:50 +0200
with message-id <[email protected]>
and subject line Re: Bug#959421: debhelper 13 complains about source files
missing in the binary of ebumeter
has caused the Debian Bug report #959421,
regarding debhelper 13 complains about source files missing in the binary of
ebumeter
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
959421: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959421
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: debhelper
Version: 13
Severity: serious
Tags: upstream ftbfs
Justification: fails to build from source
Dear Maintainer,
when upgrading to dh 13 with ebumeter, dh complains about source files from
ebumeter/source missing in the binary.
https://salsa.debian.org/multimedia-team/ebumeter
Best regards,
Dennis
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armhf
Kernel: Linux 5.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8),
LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages debhelper depends on:
ii autotools-dev 20180224.1
ii dh-autoreconf 19
ii dh-strip-nondeterminism 1.8.0-1
ii dpkg 1.19.7
ii dpkg-dev 1.19.7
ii dwz 0.13-5
ii file 1:5.38-4
ii libdebhelper-perl 13
ii libdpkg-perl 1.19.7
ii man-db 2.9.1-1
ii perl 5.30.0-10
ii po-debconf 1.0.21
debhelper recommends no packages.
Versions of packages debhelper suggests:
ii dh-make 2.202001
-- no debconf information
--- End Message ---
--- Begin Message ---
Hi Niels,
first of all: sorry for the minimal infos.
Yes, i bumped dh-compat in the control file from 12 to 13 and then i was
taking more attention on this, because --fail-missing is active on default.
I tried what you said, using --sourcedirectory (didn't know it makes a
difference to ---sourcedir) and removing the ../ from the install files
and now all works fine.
Thanks a lot for your help and work, and sorry again (for the noise).
Best regards,
Dennis
Am 02.05.20 um 12:01 schrieb Niels Thykier:
> Control: severity -1 normal
> Control: tags -1 moreinfo
>
> Dennis Braun:
>> Package: debhelper
>> Version: 13
>> Severity: serious
>> Tags: upstream ftbfs
>> Justification: fails to build from source
>>
>> Dear Maintainer,
>>
>> when upgrading to dh 13 with ebumeter, dh complains about source files from
>> ebumeter/source missing in the binary.
>>
>> https://salsa.debian.org/multimedia-team/ebumeter
>>
>> Best regards,
>> Dennis
>>
>>
>> [...]
> Hi Dennis,
>
> This bug report leaves me with very mixed feelings.
>
> The report has no details of what you did other than a vague "Upgrading
> to dh" which is ambiguous (did you upgrade to debhelper 13 or bump
> compat level to 13? There is a major difference between the two).
> There are no details of what you did to understand the problem nor any
> mention of unclear documentation from debhelper's documentation.
>
>
> This leaves me with the feeling that you bumped the compat level without
> reading the relevant documentation and when it broke you shoved the
> broken pieces to me with an implicit "Please fix this for me!".
>
>
> This is hopefully not what you intended to do. In the future, I would
> recommend you provide a bit more details on what you have tried to do
> or/and which part of the documentation that you do not feel match the
> reality you see.
> This would leave me with less guess work and also less likely to come
> to the above assumption that cannot be part of a fruitful discussion on
> how we fix the issue you experience.
>
>
> *Moving on*
> Pushing that aside, lets move on to ebumeter. I presume what you were
> experiencing was that dh_missing terminated when an error as it now
> defaults to --fail-missing instead of --list-missing. This is
> documented in "man 7 debhelper" under "Supported compatibility levels"
> (see the "v13" / "Changes from v12" entry). Related, dh_missing emits
> the same warnings already under compat 12, which is an early warning and
> would have enabled you to fix this problem ahead of time. I can
> recommend checking the build logs for warnings before bumping compat levels.
>
> At this point, we might be tempted to just neuter the dh_missing issue
> (instructions are in "man 7 debhelper") and move on. However, I
> recommend that you fix the root cause, which in this case involves the
> --sourcedir parameter to dh and some follow up fixes.
>
>
> *The root cause for ebumeter*
>
> The "--sourcedir" parameter is accepted by dh_install AND the dh_auto_*
> commands. But in ebumeter, it *seem* to be used to make sure dh_auto_*
> pick up the upstream source files directly. This can be done by using
> the longer form "--sourcedirectory", which only dh_auto_* responds to[1].
>
> This will trigger some errors from the .install and .manpages files
> because the "../" hack does not work any longer. That said, it is
> unneeded and simply removing "../" will work because the relevant
> dh_install* helpers will fall back to the source root when they do not
> get the --sourcedir parameter.
>
>
> These changes should also work in compat 12, so you can try them out
> without bumping to compat 13 and see all the dh_missing warnings disappear.
>
> Note: I have made no attempts to check if the package work after these
> changes and include every thing as you would expect. I leave that to you.
>
> *In summary*
>
> I do not see a bug in debhelper, only a failed attempt to migrate to
> compat 13 (which I have provided suggestions on how to fix).
> Should you find that the documentation for bumping compat levels is
> unclear or have suggestions to improve it, please let me know and I will
> look at fixing it.
>
> ~Niels
>
>
> [1] Yes, it is confusing that --sourcedir is picked up by both
> dh_install + dh_auto_*.
>
signature.asc
Description: OpenPGP digital signature
--- End Message ---
