Your message dated Mon, 05 Oct 2020 23:03:25 +0000
with message-id <[email protected]>
and subject line Bug#953100: fixed in snoopy 2.4.8-1
has caused the Debian Bug report #953100,
regarding snoopy: Build with -Wno-error=stringop-truncation for compatibility
with -O3
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
953100: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953100
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: snoopy
Version: 2.4.6-6
Severity: minor
Tags: patch
User: [email protected]
Usertags: origin-ubuntu focal ubuntu-patch
Hi Marco,
In Ubuntu, the latest version of snoopy was failing to build on ppc64el
because Ubuntu builds ppc64el with -O3 by default, and the added
optimization causes a failure because gcc detects a possible truncation when
using strncpy():
[...]
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../.. -Wdate-time
-D_FORTIFY_SOURCE=2 -Wall -Werror -Wextra -Wno-unused-parameter -std=c99
-pedantic -I../../.. -g -O3 -fdebug-prefix-map=/<<PKGBUILDDIR>>=.
-fstack-protector-strong -Wformat -Werror=format-security -c ini.c -fPIC -DPIC
-o .libs/ini.o
In file included from /usr/include/string.h:494,
from ini.c:16:
In function ‘strncpy’,
inlined from ‘strncpy0’ at ini.c:73:5,
inlined from ‘ini_parse_stream’ at ini.c:202:17:
/usr/include/powerpc64le-linux-gnu/bits/string_fortified.h:106:10: error:
‘__builtin_strncpy’ output may be truncated copying 49 bytes from a string of
length 199 [-Werror=stringop-truncation]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[5]: *** [Makefile:462: ini.lo] Error 1
[...]
(https://launchpad.net/ubuntu/+source/snoopy/2.4.6-6/+build/18085537)
This is an entirely safe use of strncpy in context, so I think this error
should just be overridden instead of giving the compiler its satisfaction.
The attached patch lets snoopy build on Ubuntu/ppc64el. Would you consider
applying this in Debian, for improved compatibility with -O3 builds?
Cheers,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru snoopy-2.4.6/debian/rules snoopy-2.4.6/debian/rules
--- snoopy-2.4.6/debian/rules 2019-11-08 15:23:51.000000000 -0800
+++ snoopy-2.4.6/debian/rules 2020-03-04 05:28:41.000000000 -0800
@@ -3,6 +3,7 @@
export DEB_BUILD_MAINT_OPTIONS = hardening=+all
DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
+export DEB_CFLAGS_MAINT_APPEND = -Wno-error=stringop-truncation
%:
dh $@
--- End Message ---
--- Begin Message ---
Source: snoopy
Source-Version: 2.4.8-1
Done: Marcos Fouces <[email protected]>
We believe that the bug you reported is fixed in the latest version of
snoopy, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Marcos Fouces <[email protected]> (supplier of updated snoopy package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 05 Oct 2020 23:20:58 +0200
Source: snoopy
Architecture: source
Version: 2.4.8-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Security Tools <[email protected]>
Changed-By: Marcos Fouces <[email protected]>
Closes: 953100 957824
Changes:
snoopy (2.4.8-1) unstable; urgency=medium
.
* Fix FTBFS in ppc64el. Thanks to Steve Langasek.
(Closes: #953100).
* Bump to Standards-Version: 4.5.0 (no changes required).
* New upstream version 2.4.8 (Closes:#957824).
* Refresh patches that remain and remove the following
already applied upstream:
~ 0001-parse-proc-properties-to-the-end.patch
~ 0002-properly-extract-Name-values-containing-whitespace.patch
~ 04_gcc-7.patch
~ 05_gcc-9.patch
* Update uploader email to @debian.org
* Improve upstream metadata.
* Fix Lintian overrides.
* Convert some *.po files to utf-8 encoding.
* Bump to debhelper-compat level 13.
Checksums-Sha1:
70f1ec092d3405c2db93ea69c2d1e3e571554ccb 1920 snoopy_2.4.8-1.dsc
78dd1eb72cd29cd8ae0d0bf66cbcabddefb5f798 130896 snoopy_2.4.8.orig.tar.gz
f48c7f18ac98da7281aff24adcca5dcbc07930f2 16356 snoopy_2.4.8-1.debian.tar.xz
9cce4b1befc86d9d1f3326c23c2c5ece55546e61 5662 snoopy_2.4.8-1_source.buildinfo
Checksums-Sha256:
2d4dda2780893a8b9e0cf28b0a028892e8a3ee6b43acf2b2c950412f21d48efa 1920
snoopy_2.4.8-1.dsc
c47a15f2b476cce991ae1caa502f0d0cb1a735b87aab949a0636ab1251ad7ba1 130896
snoopy_2.4.8.orig.tar.gz
2f63baa8ba7a26850938ed9290036410f92a4b030886ea474efc40b00bd49999 16356
snoopy_2.4.8-1.debian.tar.xz
1405aec4cc3c9e8dfbda416da3d0ad3713b3aceee537313ffeceb70e98904e02 5662
snoopy_2.4.8-1_source.buildinfo
Files:
6ed33cdc1db6a79774ebf606a5b1a30c 1920 admin optional snoopy_2.4.8-1.dsc
44883e611c5af42969808e2cba6d9b87 130896 admin optional snoopy_2.4.8.orig.tar.gz
b20233c6a4ebc3deaf27cfb8b20659c9 16356 admin optional
snoopy_2.4.8-1.debian.tar.xz
c4e21ff3ed44f504f696dfe1cbfea84e 5662 admin optional
snoopy_2.4.8-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEfLiv/VYDL+NaNH0uasy9D6O3RHwFAl97oswACgkQasy9D6O3
RHx+yA/8DZzSBs2Ayu1kQKnARSx3gFdSKsax6dbBbQSs2SyreSQ2cdnaogqWT6Zq
Sh6AxoJ5oV/H6a16kBNrZhJV4tbyWlyXrvslwp8jwiZnR3gIW1l5wNzz3F70JbGF
ODUMB+9vSdz00szAHboObOVORceBj7gUgrDKja1ZmeTsky9ZA/BwSgMWTwFJyuVV
mINgU7CYh9qEjBbegF1wMCPtSTYmB+FiUkG8MVlXtkjsras3/hYpuiw1KD6m9aK6
GWjYb8HJkOrOgjvg4iOwEtw2JgcGnB9NH4NM7Uknx3RnXgc1Eo6JnROJw6JhlaFo
sWDMky3BHvxLIu5i1kiLQda66PNcoGUp8b5WEu4goXR9cqs9ZtA4Jll4W68j05UC
Qz1B46TOyePps0WevOZu5OOU1GwAV3k+wNMBaMNoTeMHA659llJtQDZ3Z+1vzSXO
sZR1ZZemZDQF81UC9x1HXL5p41FxY9AG/UmlsEaOT8oQZVJOGyEQXOJgw0kq1yCq
zllzIltEUiCvWoV9vDmuEXoel3RjkwjN+lnnKSN65W4zpI+YOCSbI4BZNa0iT+ql
MX+G4R7XXWEf5vSOZx9Ftwhab0RtVnMAPruVOvsRz8AQLqroew8BhXCP2H+ZS65W
cHXlrGFrCjmai2ZAJdHvyO10j6whjf4b/lG8M9Khb5bWTyRIwlM=
=KSWS
-----END PGP SIGNATURE-----
--- End Message ---
