Your message dated Sat, 02 Nov 2024 03:34:06 +0000
with message-id <[email protected]>
and subject line Bug#1082101: fixed in ipmitool 1.8.19-7.1
has caused the Debian Bug report #1082101,
regarding ipmitool sdr type stopped accepting raw hex values
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1082101: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1082101
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ipmitool
Severity: important
Tags: patch
Hi,
Upstream has a patch that fixes using hex values when sending raw data. I've
attached it to this bug report, though it's available here:
https://codeberg.org/IPMITool/ipmitool/commit/202f7427e0a4d1f319fc4b914676cc2f08da6c6c
Please apply it in the Debian package.
It'd be nice to have this patch also applied in Debian Stable. If you do not
have enough available time to handle it, I can take care of this once the
patch lands in Debian Testing.
Cheers,
Thomas Goirand (zigo)
>From 202f7427e0a4d1f319fc4b914676cc2f08da6c6c Mon Sep 17 00:00:00 2001
From: Alexander Amelkin <[email protected]>
Date: Tue, 17 Sep 2024 15:15:45 +0300
Subject: [PATCH] sdr: Refix 6e037d6bfbbb93b349c8ca331ebde03a (#41)
A bug was introduced by commit 6e037d6bfbbb93b349c8ca331ebde03a837f76bf
due to which the command `ipmitool sdr type` stopped accepting raw
hex values for the type and would only accept strings.
Fix that by partially reverting the troublesome commit.
Additionally, apply the logic of that commit to calls of
`strcasecmp()` in ipmi_sdr.c.
Resolves https://codeberg.org/IPMITool/ipmitool/issues/41
Signed-off-by: Alexander Amelkin <[email protected]>
---
lib/ipmi_sdr.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/lib/ipmi_sdr.c b/lib/ipmi_sdr.c
index abd4ee1..4732762 100644
--- a/lib/ipmi_sdr.c
+++ b/lib/ipmi_sdr.c
@@ -4570,8 +4570,9 @@ ipmi_sdr_print_type(struct ipmi_intf *intf, char *type)
uint8_t sensor_type = 0;
if (!type ||
- strcasecmp(type, "help") == 0 ||
- strcasecmp(type, "list") == 0) {
+ !strcasecmp(type, "help") ||
+ !strcasecmp(type, "list"))
+ {
printf("Sensor Types:\n");
for (x = 1; x < SENSOR_TYPE_MAX; x += 2) {
printf("\t%-25s (0x%02x) %-25s (0x%02x)\n",
@@ -4581,7 +4582,7 @@ ipmi_sdr_print_type(struct ipmi_intf *intf, char *type)
return 0;
}
- if (!strcmp(type, "0x")) {
+ if (!strncmp(type, "0x", 2)) {
/* begins with 0x so let it be entered as raw hex value */
if (str2uchar(type, &sensor_type) != 0) {
lprintf(LOG_ERR,
@@ -4591,7 +4592,7 @@ ipmi_sdr_print_type(struct ipmi_intf *intf, char *type)
}
} else {
for (x = 1; x < SENSOR_TYPE_MAX; x++) {
- if (strcasecmp(sensor_type_desc[x], type) == 0) {
+ if (!strcasecmp(sensor_type_desc[x], type)) {
sensor_type = x;
break;
}
@@ -4638,8 +4639,8 @@ ipmi_sdr_print_entity(struct ipmi_intf *intf, char
*entitystr)
int rc = 0;
if (!entitystr ||
- strcasecmp(entitystr, "help") == 0 ||
- strcasecmp(entitystr, "list") == 0) {
+ !strcasecmp(entitystr, "help") ||
+ !strcasecmp(entitystr, "list")) {
print_valstr_2col(entity_id_vals, "Entity IDs", -1);
return 0;
}
@@ -4654,7 +4655,7 @@ ipmi_sdr_print_entity(struct ipmi_intf *intf, char
*entitystr)
/* now try string input */
for (i = 0; entity_id_vals[i].str; i++) {
- if (strcasecmp(entitystr,
entity_id_vals[i].str) == 0) {
+ if (!strcasecmp(entitystr,
entity_id_vals[i].str)) {
entity.id = entity_id_vals[i].val;
entity.instance = 0x7f;
j=1;
--- End Message ---
--- Begin Message ---
Source: ipmitool
Source-Version: 1.8.19-7.1
Done: Shengqi Chen <[email protected]>
We believe that the bug you reported is fixed in the latest version of
ipmitool, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Shengqi Chen <[email protected]> (supplier of updated ipmitool package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 27 Oct 2024 23:57:07 +0800
Source: ipmitool
Architecture: source
Version: 1.8.19-7.1
Distribution: unstable
Urgency: medium
Maintainer: Jörg Frings-Fürst <[email protected]>
Changed-By: Shengqi Chen <[email protected]>
Closes: 1061770 1082101
Changes:
ipmitool (1.8.19-7.1) unstable; urgency=medium
.
* Non-maintainer upload.
* d/patches: backport several important fixes from upstream
+ fix a buffer overrun in `open` interface
+ fix lan print fails on unsupported parameters (closes: #1061770)
+ fix parameter passed to read temperature sensors
+ fix using hex values when sending raw data (closes: #1082101)
* Some build tweaks:
+ add patch to enable verbose output from libtool
+ d/rules: run autoupdate before autoreconf
* d/control: bump std-ver to 4.7.0 (no changes required)
Checksums-Sha1:
80ce1c5b329c535e8352172fd80ef94009d2fa4b 1800 ipmitool_1.8.19-7.1.dsc
d0979a316b5a6edf28112fae7826d8d9f12e72e1 1557120
ipmitool_1.8.19-7.1.debian.tar.xz
58a97493baef9bb0a99b3bbde48c87ce48404de1 5693
ipmitool_1.8.19-7.1_source.buildinfo
Checksums-Sha256:
6a128f60d561a3ff9ce3dcdc5f6deb4806ede9403f80309574d38ee7519eee9d 1800
ipmitool_1.8.19-7.1.dsc
9b239e451367d96c96ee4da8b68ff45736f57c1ecbb08b911a4f928310061828 1557120
ipmitool_1.8.19-7.1.debian.tar.xz
697e95f59bcc4ec245a62e571ac785bad5457706164ad9f4739bd5f8e5d5a224 5693
ipmitool_1.8.19-7.1_source.buildinfo
Files:
9df7927119074568926aa7f82b2674f6 1800 utils optional ipmitool_1.8.19-7.1.dsc
a90992c70f38bef6fe7177d90fd756ab 1557120 utils optional
ipmitool_1.8.19-7.1.debian.tar.xz
c219c2caedc1831e413bc2632d9afb43 5693 utils optional
ipmitool_1.8.19-7.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEBLHAyuu1xqoC2aJ5NP8o68vMTMgFAmce+3UACgkQNP8o68vM
TMiw6Qf/bPo0VqsFIR9XLOto/4R5L/P2t9/9gzZenHp6gBqdEI3OZHqIRZtDoZQV
i7+5EJEI6dV7KiXH4Kz11CecMs4BrQe3d1HDrKRxQkM+rDJevKOqzHabO4CuqBCc
dI7MJCTSxLUrLOHjwWuh73WudIZiOtE1tsA286GMDg0gUDItFePs70c9TNWXZLLc
ExDpWOrTYTq+dZ1xgWLnKzmenOfh1PhkDDC0Isujpba2xQG9cEqK0iPk8OvozjqX
OPK/yfh0FRwQliD8HSqHZIv9PTlcmJa1HBB503z1DniCyoEXKBIGlBtGf2MdG/lk
ui/kutzOlEZBkdpiWW2LdrMl27IVKg==
=CXLT
-----END PGP SIGNATURE-----
pgpHTz8dELwtJ.pgp
Description: PGP signature
--- End Message ---
