Your message dated Sat, 02 Nov 2024 16:32:08 +0000
with message-id <[email protected]>
and subject line Bug#1082101: fixed in ipmitool 1.8.19-4+deb12u2
has caused the Debian Bug report #1082101,
regarding ipmitool sdr type stopped accepting raw hex values
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1082101: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1082101
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ipmitool
Severity: important
Tags: patch
Hi,
Upstream has a patch that fixes using hex values when sending raw data. I've
attached it to this bug report, though it's available here:
https://codeberg.org/IPMITool/ipmitool/commit/202f7427e0a4d1f319fc4b914676cc2f08da6c6c
Please apply it in the Debian package.
It'd be nice to have this patch also applied in Debian Stable. If you do not
have enough available time to handle it, I can take care of this once the
patch lands in Debian Testing.
Cheers,
Thomas Goirand (zigo)
>From 202f7427e0a4d1f319fc4b914676cc2f08da6c6c Mon Sep 17 00:00:00 2001
From: Alexander Amelkin <[email protected]>
Date: Tue, 17 Sep 2024 15:15:45 +0300
Subject: [PATCH] sdr: Refix 6e037d6bfbbb93b349c8ca331ebde03a (#41)
A bug was introduced by commit 6e037d6bfbbb93b349c8ca331ebde03a837f76bf
due to which the command `ipmitool sdr type` stopped accepting raw
hex values for the type and would only accept strings.
Fix that by partially reverting the troublesome commit.
Additionally, apply the logic of that commit to calls of
`strcasecmp()` in ipmi_sdr.c.
Resolves https://codeberg.org/IPMITool/ipmitool/issues/41
Signed-off-by: Alexander Amelkin <[email protected]>
---
lib/ipmi_sdr.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/lib/ipmi_sdr.c b/lib/ipmi_sdr.c
index abd4ee1..4732762 100644
--- a/lib/ipmi_sdr.c
+++ b/lib/ipmi_sdr.c
@@ -4570,8 +4570,9 @@ ipmi_sdr_print_type(struct ipmi_intf *intf, char *type)
uint8_t sensor_type = 0;
if (!type ||
- strcasecmp(type, "help") == 0 ||
- strcasecmp(type, "list") == 0) {
+ !strcasecmp(type, "help") ||
+ !strcasecmp(type, "list"))
+ {
printf("Sensor Types:\n");
for (x = 1; x < SENSOR_TYPE_MAX; x += 2) {
printf("\t%-25s (0x%02x) %-25s (0x%02x)\n",
@@ -4581,7 +4582,7 @@ ipmi_sdr_print_type(struct ipmi_intf *intf, char *type)
return 0;
}
- if (!strcmp(type, "0x")) {
+ if (!strncmp(type, "0x", 2)) {
/* begins with 0x so let it be entered as raw hex value */
if (str2uchar(type, &sensor_type) != 0) {
lprintf(LOG_ERR,
@@ -4591,7 +4592,7 @@ ipmi_sdr_print_type(struct ipmi_intf *intf, char *type)
}
} else {
for (x = 1; x < SENSOR_TYPE_MAX; x++) {
- if (strcasecmp(sensor_type_desc[x], type) == 0) {
+ if (!strcasecmp(sensor_type_desc[x], type)) {
sensor_type = x;
break;
}
@@ -4638,8 +4639,8 @@ ipmi_sdr_print_entity(struct ipmi_intf *intf, char
*entitystr)
int rc = 0;
if (!entitystr ||
- strcasecmp(entitystr, "help") == 0 ||
- strcasecmp(entitystr, "list") == 0) {
+ !strcasecmp(entitystr, "help") ||
+ !strcasecmp(entitystr, "list")) {
print_valstr_2col(entity_id_vals, "Entity IDs", -1);
return 0;
}
@@ -4654,7 +4655,7 @@ ipmi_sdr_print_entity(struct ipmi_intf *intf, char
*entitystr)
/* now try string input */
for (i = 0; entity_id_vals[i].str; i++) {
- if (strcasecmp(entitystr,
entity_id_vals[i].str) == 0) {
+ if (!strcasecmp(entitystr,
entity_id_vals[i].str)) {
entity.id = entity_id_vals[i].val;
entity.instance = 0x7f;
j=1;
--- End Message ---
--- Begin Message ---
Source: ipmitool
Source-Version: 1.8.19-4+deb12u2
Done: Shengqi Chen <[email protected]>
We believe that the bug you reported is fixed in the latest version of
ipmitool, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Shengqi Chen <[email protected]> (supplier of updated ipmitool package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 02 Nov 2024 14:52:14 +0800
Source: ipmitool
Architecture: source
Version: 1.8.19-4+deb12u2
Distribution: bookworm
Urgency: medium
Maintainer: Jörg Frings-Fürst <[email protected]>
Changed-By: Shengqi Chen <[email protected]>
Closes: 1061770 1082101
Changes:
ipmitool (1.8.19-4+deb12u2) bookworm; urgency=medium
.
* Non-maintainer upload.
* d/control: Remove obsolete lsb-base from Depends
* d/patches: backport several important fixes from upstream
+ fix a buffer overrun in `open` interface
+ fix lan print fails on unsupported parameters (closes: #1061770)
+ fix parameter passed to read temperature sensors
+ fix using hex values when sending raw data (closes: #1082101)
Checksums-Sha1:
27e8830d09c95ca04be4e2c6c599a76fbc73ba35 1627 ipmitool_1.8.19-4+deb12u2.dsc
ecbf25e20a48c570316aa9347e977954a7f0aff3 1586680
ipmitool_1.8.19-4+deb12u2.debian.tar.xz
3f33f202c78e74cd0de4af3cf388d656b7499c30 5717
ipmitool_1.8.19-4+deb12u2_source.buildinfo
Checksums-Sha256:
e6e1b4ce1d8b603e922637d921c371cbcdaa4d82b648de97d6ff0b0ae024d972 1627
ipmitool_1.8.19-4+deb12u2.dsc
efc880610f1b0160689197a927b94bf009fac82684817ffad8c26949d7c275de 1586680
ipmitool_1.8.19-4+deb12u2.debian.tar.xz
672027686157175f70e211642dbfd21d1fc0017012ae762d47f6ace5ae7059ab 5717
ipmitool_1.8.19-4+deb12u2_source.buildinfo
Files:
0403ce4f4fadf4514f654483966a81a1 1627 utils optional
ipmitool_1.8.19-4+deb12u2.dsc
1886c4054222f9b70617bc78656d0823 1586680 utils optional
ipmitool_1.8.19-4+deb12u2.debian.tar.xz
0dbe490208dc5757910a43aba3d5124f 5717 utils optional
ipmitool_1.8.19-4+deb12u2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEBLHAyuu1xqoC2aJ5NP8o68vMTMgFAmcmDr4ACgkQNP8o68vM
TMiseQf/SXhn50iO2jmyTuVxzy1ox7wMuHALtNwSWeYUCccvzsP7t1HQyeshV+C1
xMIt0p/Ca2ySsby43l5WvRx3rS3KH247A9ymr44Aqcn5dfXxANxWBtB3RkWyHnYU
w33Etvxgjv+r/eqVfskBJ5AZk8UgQtFfLbSHxJRXqjDY7pNIfjUgMt/OKMEPcdeg
8Za7lORKYPMDFLlRyxNlRw77SzOuXI4C7JJZpg+XP0XQNYfHjdt21PS3vh7L66iS
mgnxld7Qtidtw6dIU39XnBimW3DSInYr7nt0+hLom5Pya3cWfGkTlP5xcDONPJkH
BWB3Vm1HNc5O4yNiDCEPafG+RGVdrA==
=a7bb
-----END PGP SIGNATURE-----
pgpUuZ_engj0P.pgp
Description: PGP signature
--- End Message ---
