Package: firehol
Version: 1.214-1
Severity: important

firehol bitches and moans if neither wget or curl are installed, even if
the given argument isn't valid:

-----
[EMAIL PROTECTED]:/lib/firehol# firehol helpme

ERROR:  Command 'curl' not found in the system path.
        FireHOL requires this command for its operation.
        Please install the required package and retry.
-----

But the package does not Depends: wget | curl

Additionally, wget or curl are only used to download the ECN shame file.
The firehol script has code in place to deal with this download failing,
so it should deal with wget and curl missing in the same way.

I won't install wget or curl on my firewall machine, nor will the
firewall I'm about to configure allow the machine to make HTTP fetches.
I'd prefer to simply live without the ECN shame file, or turn ECN off.

Trivial barely tested patch to ignore missing wget and curl attached.
-- 
Sam "Eddie" Couter  |  mailto:[EMAIL PROTECTED]
Debian Developer    |  mailto:[EMAIL PROTECTED]
                    |  jabber:[EMAIL PROTECTED]
OpenPGP fingerprint:  A46B 9BB5 3148 7BEA 1F05  5BD5 8530 03AE DE89 C75C
--- firehol.orig        2005-01-18 22:03:21.000000000 +1100
+++ firehol     2005-01-18 22:01:33.000000000 +1100
@@ -73,7 +73,7 @@
 which_cmd TR_CMD tr
 which_cmd UNAME_CMD uname
 which_cmd UNIQ_CMD uniq
-which_cmd -n WGET_CMD wget || which_cmd CURL_CMD curl
+which_cmd -n WGET_CMD wget || which_cmd -n CURL_CMD curl
 
 
 # 
------------------------------------------------------------------------------

Attachment: signature.asc
Description: Digital signature

Reply via email to