reopen 587442
found 587442 1:2.8.2
tags 587442 patch
thanks

I don't think Benjamin is going to manually check the Adobe website
every day before his cronjob runs. That's ridiculous. What would he do
then, cancel the cronjob? Your solution would be more hassle than this
bug already causes. Benjamin came up with a perfectly fine solution
over 2 years ago.

However, while Benjamin's solution works, it does have a technical
error. Those parenthesis create a subshell, and the exit command only
exits out of that subshell. So the script continues to run to the next
command, where it exits with a confusing error message.

I've included a patch that is a little longer but exits clean and
without error.

It's a bad idea to close bug reports that describe bugs that are
still standing, even if you have no intention of fixing them. Here are
two reasons:
1) somebody else will come across the same bug and report it again
2) in this case, at least, there are solutions listed here that someone
else who comes across the same bug can incorporate themselves

-Brandon
--- /usr/sbin/update-flashplugin-nonfree	2010-09-17 11:42:15.000000000 -0700
+++ ./update-flashplugin-nonfree	2012-09-02 09:58:22.000000000 -0700
@@ -201,6 +201,11 @@
 		targetdir=/usr/lib/flashplugin-nonfree
 		libflashplayerdotso=`grep "  .*libflashplayer\.so$" checksums.txt | cut -c 131-`
 
+		# Check to see if Flash player has been updated, exit if it has not.
+		diff $libflashplayerdotso $targetdir/libflashplayer.so && do_exit=true
+		[ "$do_exit" != "true" ] || do_cleanup;
+		[ "$do_exit" != "true" ] || exit 0;
+
 		[ "$verbose" != "yes" ] || echo "moving $libflashplayerdotso to $targetdir ..."
 		rm -f $targetdir/flashplayer.xpt
 		mv -f $libflashplayerdotso $targetdir

Reply via email to