Package: ftphs
Version: 1.0.8-1
Severity: normal
Tags: upstream
Hi,
I tested this on Ubuntu Raring, but it will apply to Debian too.
,----
| Preprocessing library ftphs-1.0.8...
| [1 of 4] Compiling Network.FTP.Client.Parser (
src/Network/FTP/Client/Parser.hs, dist-ghc/build/Network/FTP/Client/Parser.o )
|
| src/Network/FTP/Client/Parser.hs:251:9: Warning:
| Pattern match(es) are overlapped
| In an equation for `procq': procq ('"' : '"' : xs) = ...
| [2 of 4] Compiling Network.FTP.Server.Parser (
src/Network/FTP/Server/Parser.hs, dist-ghc/build/Network/FTP/Server/Parser.o )
| [3 of 4] Compiling Network.FTP.Server ( src/Network/FTP/Server.hs,
dist-ghc/build/Network/FTP/Server.o )
|
| src/Network/FTP/Server.hs:169:18: Not in scope: `try'
|
| src/Network/FTP/Server.hs:217:33: Not in scope: `catch'
| make: *** [build-ghc-stamp] Error 1
`----
Fix attached but I'm not sure about uploading as IIRC we were considering
removing ftphs.
Are we?
Cheers,
Iain Lane [ [email protected] ]
Debian Developer [ [email protected] ]
Ubuntu Developer [ [email protected] ]
-- System Information:
Debian Release: wheezy/sid
APT prefers raring-updates
APT policy: (500, 'raring-updates'), (500, 'raring-security'), (500,
'raring-proposed'), (500, 'raring')
Architecture: amd64 (x86_64)
Kernel: Linux 3.8.0-19-generic (SMP w/8 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL
set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru ftphs-1.0.8/debian/changelog ftphs-1.0.8/debian/changelog
diff -Nru ftphs-1.0.8/debian/patches/ghc-7.6-compatibility ftphs-1.0.8/debian/patches/ghc-7.6-compatibility
--- ftphs-1.0.8/debian/patches/ghc-7.6-compatibility 1970-01-01 01:00:00.000000000 +0100
+++ ftphs-1.0.8/debian/patches/ghc-7.6-compatibility 2013-04-24 15:05:49.000000000 +0100
@@ -0,0 +1,40 @@
+Description: Port to work with catch from Control.Exception as found in GHC 7.6
+Author: Iain Lane <[email protected]>
+Forwarded: yes
+
+--- ftphs-1.0.8.orig/src/Network/FTP/Server.hs
++++ ftphs-1.0.8/src/Network/FTP/Server.hs
+@@ -1,3 +1,4 @@
++{-# LANGUAGE ScopedTypeVariables #-}
+ {- arch-tag: FTP server support
+ Copyright (C) 2004 John Goerzen <[email protected]>
+
+@@ -98,7 +99,7 @@ import Text.Printf
+ import Data.Char
+ import Data.IORef
+ import Data.List
+-import Control.Exception(finally)
++import Control.Exception(finally, try, catch, IOException)
+ import System.IO
+
+ data DataType = ASCII | Binary
+@@ -168,8 +169,8 @@ trapIOError :: FTPServer -> IO a -> (a -
+ trapIOError h testAction remainingAction =
+ do result <- try testAction
+ case result of
+- Left err -> do sendReply h 550 (show err)
+- return True
++ Left (err :: IOException) -> do sendReply h 550 (show err)
++ return True
+ Right result -> remainingAction result
+
+ forceLogin :: CommandHandler -> CommandHandler
+@@ -214,7 +215,7 @@ commandLoop h@(FTPServer fh _ _) =
+ ("Closing due to error: " ++ (show e))
+ hClose fh
+ return False
+- in do continue <- (flip catch) errorhandler
++ in do continue <- (flip catch) (\(e :: IOException) -> errorhandler e)
+ (do x <- parseCommand fh
+ case x of
+ Left err -> do sendReply h 500 $
diff -Nru ftphs-1.0.8/debian/patches/series ftphs-1.0.8/debian/patches/series
--- ftphs-1.0.8/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ ftphs-1.0.8/debian/patches/series 2013-04-24 15:02:58.000000000 +0100
@@ -0,0 +1 @@
+ghc-7.6-compatibility