Control: clone -1 -2 Control: reassign -2 sponsorship-requests Control: retitle -2 RFS: splix/2.0.0+svn308-1 Control: owner -2 o...@debian.org Control: affects -2 src:splix Control: block -1 by -2
Hi Luca, thanks for your answer to this bugreport. I'm hereby cloning this bug to a "Request for Sponsorship" on the sponsorship- requests pseudo-package, to track the comments on your package there. Le mardi, 4 juin 2013 01.18:21, Luca Niccoli a écrit : > Here's the link to the dsc: > http://mentors.debian.net/debian/pool/main/s/splix/splix_2.0.0+svn308-1.dsc Le dimanche, 2 juin 2013 13.03:04, Luca Niccoli a écrit : > I've uploaded to mentors a new version of splix. > The changes are: > - move to the lates svn snapshot Ack, great. One comment though: the Ubuntu package [0] closed one "Launchpad" (LP:) bug in that changelog entry (LP: #898986). It's good practice to include these when possible as that makes Ubuntu's job easier too at synchronisation time (and costs the Debian package nothing more than some bits in the changelog). > - copy fixed splix.ppd-updater from Ubuntu Ack, great. > - add conditional apport hook for Ubuntu and derivatives This doesn't work as the "derives_from_ubuntu" Make variable hasn't been defined. You need to add it's definition in debian/rules (on one line of course): derives_from_ubuntu := $(shell (dpkg-vendor --derives-from Ubuntu && echo "yes") || echo "no") > - add get-orig-source target Good. > - used dpkg-buildflags to import hardening flags I see that you applied these using a Debian-specific quilt patch. Although I would initially have written that these flags are modifiable without a quilt patch, apparently the LDFLAGS variables can't inheritate from debian/rules. That said, it would be good to: a) set V=1 to get a verbose build (that allows one to verify that the flags are correctly set); b) define the flags from dpkg at make execution time instead of executing dpkg-buildflags at every CC invocation, with: $(shell dpkg-buildflags --get CXXFLAGS) > - bumped Standards-Version Just to make that clear: did you check the upgrading-checklist from the debian-policy package while doing so? > I'd be glad if you could review the upload and give me some comments. See above. > Didier, I'd be glad to move splix packaging under team maintenance, > possibly under git. Cool. These are two different things though: - putting the packaging under team maintenance means setting "Debian Printing Team <debian-print...@lists.debian.org>" as Maintainer and yourself in the list of Uploaders. This implies that your package might get enhancements of fixes from other members of the printing team. Such changes are not supposed to happen without coordination with the main Uploaders though, don't worry. - moving the packaging in git. I invite you to read [PackagingWithGit] on the wiki, if possible using the pristine-tar option. Get started and ask if you have questions! For the initial git'ification, I suggest that you use the git- import-dscs tool to fetch all past releases from Debian Snapshots. [PackagingWithGit] http://wiki.debian.org/PackagingWithGit > Maybe we can talk about it in private mail or on a list, so we do not fill > this bug with unrelated stuff? Please answer to the cloned bug (once we know it's number). There's no (and almost never) reason to handle things in private when it's possible to handle them in public: the comments on your package can be helpful to others. > P.S. mentors seems a bit slow in accepting my upload, but I'm hopeful that > it will appear in the next few hours. That's apparently solved, great. Cheers, OdyX [0] https://launchpad.net/ubuntu/+source/splix/2.0.0+svn308-0ubuntu1 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
