On Mon, Aug 19, 2013 at 12:28 AM, Vincent Bernat <ber...@debian.org> wrote:
> OK, it works for me too. > > Great! > > I've also explicitly removed the .symbols file as I found the Policy > Manual > > explicitly talks about C++ libraries in the last paragraph of section > 8.6 ( > > > http://www.debian.org/doc/debian-policy/ch-sharedlibs.html#s-sharedlibs-depends > > ): > > Please add a lintian override for this: > libcapnp-0.2.0: no-symbols-control-file usr/lib/libcapnp-0.2.0.so > > Will do. > > Last of all, I've just built & uploaded a new build of 0.2.0-1 with the > > changes you suggested in your original review, plus the changes discussed > > in this email: > > > > > http://mentors.debian.net/debian/pool/main/c/capnproto/capnproto_0.2.0-1.dsc > > > > Thanks! Please let me know if I can do anything else to move this > forward. > > So, a few other comments: > > - Remove the comments at the top of debian/rules, they clutter it and > they do not match the content (since you are using the tiny debhelper > set). Don't even keep the DH_VERBOSE stuff > > Likewise. > - The hardening stuff does not seem to work correctly. Maybe you could > just try with debhelper 9 and debian/compat to 9 to have them apply > automatically. > > Happy to try compat 9, but what can I do to verify that the hardening stuff has been fixed? I mean, what's telling you that it's not working correctly? Maybe I need to go reading more documentation. > - Use DEP3 (http://dep.debian.net/deps/dep3/) to describe the patchs > that you add (with Author, Description and Forwarded fields). - You ship the .la file and empty the dependency_libs field. I think > that you can just not ship it at all. There was a release goal to > remove them. Since you don't have any reverse dependency, it is > better to not ship it. > > Ah I see -- I'll omit the .la. > - You use --with python2. I don't see any Python files in the resulting > packages. Therefore, you don't need to use dh_python2. I suppose > Python is only used in tests. Just keep it as a Build-Depends. > > I can do that, but without it I think I was getting a warning about python-support being deprecated & I should use --with python2 to "fix" it. I'll try it again tomorrow to be sure, but is that safe enough to ignore? Easy enough either way. > - In debian/control, don't start the short description with a capital > for capnproto. > > Shall do. Should be able to push a new build of this package tomorrow. Thanks again! -- *Tom Lee */ http://tomlee.co / @tglee <http://twitter.com/tglee>
