On Sun, Apr 20, 2014 at 9:24 AM, RJ Clay <j...@rocasa.us> wrote:
> On 04/20/2014 04:49 AM, Vincent Cheng wrote:
>>
>>
>> - debian/copyright: your LGPL-2.1 license block should contain the
>> standard LGPL header (similar to that of your GPL-2 license block just
>> below it in your copyright file)
>
> I'll be fixing that...
>
>
>> - debian/control: Vcs-{Git,Browser} should point to where your
>> packaging is stored on alioth, not your upstream git repository (see
>> Policy 5.6.26 [1])
>
> The one now listed has both the packaging ('debian' branch) and upstream
> ('master' branch), and the one at alioth is the same. However, the one at
> alioth has been having problems that's been causing issues with updates to
> it; I still plan to continue mirroring the repo there but first I have to
> fix the issues it has.
Just curious, what sort of issues are you having with alioth? Have you
tried contacting the alioth admins about it if it's something that you
can't fix for yourself?
> But it's also true that the packaging branch in neither repo is not the
> default branch, and that unlike github that cannot be changed; so I'll need
> to update those fields in the debian/control to include the branch info.
>
>
>
>> - debian/rules has a redundant override_dh_installchangelogs target
>
> I don't now recall why I left that in there when I rewrote the file;
> I'll fix it...
>
>
>
>> - your debian/README.source is redundant given that you use source
>> format "3.0 (quilt)"
>
> Perhaps; but while a DD or DM might know that, whom else would? I've been
> using such a file since before I joined the Perl team [1], and haven't
> really been considering it redundant since many people would not know what
> that format means. But you consider not really necessary to have it?
It's redundant in the sense that as long as you use source format "3.0
(quilt)", dpkg-source is able to handle quilt-formatted patches by
itself (so you don't need an explicit build-dep on quilt, you don't
need to call dh_quilt in d/rules, etc.), so you don't actually need to
use quilt directly. This is just me being pedantic, however; you can
keep debian/README.source if you want. :)
Anyways, the d/copyright issue is the only true blocker, fix that and
I can upload this.
Regards,
Vincent
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
