* Dariusz Dwornikowski <dariusz.dwornikow...@cs.put.poznan.pl>, 2014-05-30,
13:32:
* Added patch fixing memset transposed arguments
Good catch. Please don't forget to forward the patch upstream.
Laszlo caught this but the patch was backported from 2.8.2 of crashme.
So technically upstream forwarded it to me.
Oh. I read “Forwarded: no” as “it should be forwarded, but it's not been
done yet”. In this case “Forwarded: not-needed” would be more adequate;
or even better, use “Origin: upstream”, and then you don't need
Forwarded at all.
I didn't get answer to my question about mprotect(2):
Shouldn't we run this code also on non-Linux architectures? At least
on kfreebsd-amd64, heap is not executable by default, which is what
this code is trying to work around.
Yes, forgot to clear this. I am not sure I fully undestand. Crashme is
built on all archs but this is probably not what you meant.
Won't this conditional catch for kfreebsd-amd64 (defined(__FreeBSD__)
compiler macro will catch it ?
Nope, __FreeBSD__ is not defined on GNU/kFreeBSD, only on “true” FreeBSD
systems.
Here's useful piece of documentation about porting to kFreeBSD:
http://glibc-bsd.alioth.debian.org/porting/PORTING
(the relvant section is “Add our system name to checks here and there”)
Another problem on kFreeBSD is that I get this warning:
crashme.c:758:17: warning: incompatible implicit declaration of built-in
function 'execlp' [enabled by default]
{status = execlp(cmd,cmd,nb,arg2,nt,arg4,arg5,subprocess_ind,NULL);
^
--
Jakub Wilk
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
