> Package: viewvc > Version: 1.1.5-1.1 > Severity: normal > > > The "as text" links are displayed in the ViewVC log pages in wrong > circumstances. They ARE displayed for binary files and are NOT displayed > for plain text files. That is exactly the other way around as it should > be. > > I just did a quick view in /usr/lib/viewvc/lib/viewvc.py and found out > there's a negation error on line 1049: > > if not is_plain_text(mime_type): > download_text_href = request.get_url(view_func=view_checkout, > > The "not" should not be there.
Hello, Durk. I have been trying to understand your bug report and I
think I
finally understand what's going on here.
The logic is totally fine, what is probably wrong is the label. It
should read
"see as raw file", not "as text", as it's very misleading.
That is why it's on for binary files and off for the others, because it
doesn't
make sense as it's already a text file. If you see a PNG on the normal markup
interface, it'll show up as "broken", and the only way of displaying it properly
is through the checkout view (which is accessed with the "as test" link)
Please tell me if this satisfies you or you prefer to contact upstream
to see
if we can change this. I'm on your side with this and I think it could be
worded better.
Thanks for your report,
Ender.
signature.asc
Description: OpenPGP digital signature
