Hello Vagrant Cascadian!

Thanks for your work! Much appreciated.
A few minor nitpicks/comments/feedback below/inline...

On Thu, Jun 12, 2014 at 12:17:48PM -0700, Vagrant Cascadian wrote:
[...]
> Ok, based on the above, I'm inclined to build with:
> 

I only tested u-boot-sunxi-with-spl.bin myself, but for
consistency with Cubietruck_FEL and if I interpretted Ian Campbell
correctly using u-boot.bin target would probably be preferred over
u-boot.img in the below line:

>   armhf                   Cubietruck      u-boot.img spl/sunxi-spl.bin 
> u-boot-sunxi-with-spl.bin
>   armhf                   Cubietruck_FEL  u-boot.bin spl/u-boot-spl.bin
> 
> (spl/sunxi-spl.bin failed to build with the _FEL target)
> 
> Hopefully those are the targets you need? If that sounds good, I'll include in
> the next upload.

Anyway, this is a very good start! Thanks!

I think Ian Campbell also had a few good points about SATA support so if
you haven't already considered it I would recommend looking at
http://lists.denx.de/pipermail/u-boot/2014-June/181047.html

(Hopefully these will be merged upstream any day now..)

> 
> Definitely starting to think about splitting the u-boot package into one
> package per platform, at least for armhf...

I'm not aware of your reasoning for that, but in my experience
splitting packages up in very small pieces in not a great idea.
Even if I don't doubt you're ability to deal with the maintenance
overhead, you'll still hit the NEW queue alot ....

Regards,
Andreas Henriksson


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to