Package: mgetty
Severity: important
Tags: patch

mgetty FTBFS on arm64 with the following error.

conf_mg.c:140:18: warning: cast from pointer to integer of different size 
[-Wpointer-to-int-cast]
 { "gettydefs", {(p_int)GETTYDEFS_DEFAULT_TAG}, CT_STRING, C_PRESET },
                 ^
conf_mg.c:140:2: error: initializer element is not constant
 { "gettydefs", {(p_int)GETTYDEFS_DEFAULT_TAG}, CT_STRING, C_PRESET },
 ^
conf_mg.c:140:2: error: (near initialization for 'c.gettydefs_tag.d.i')
Makefile:332: recipe for target 'conf_mg.o' failed
make[1]: *** [conf_mg.o] Error 1



Doing some searching through the source revealed a hardcoded list of 64-bit architectures. Adding arm64 to said list made the package build.

Debdiff attatched, if I get no response to this bug it is likely to be uploaded as a NMU. If you have any objections please raise them now.
diff -u mgetty-1.1.36/debian/changelog mgetty-1.1.36/debian/changelog
--- mgetty-1.1.36/debian/changelog
+++ mgetty-1.1.36/debian/changelog
@@ -1,3 +1,10 @@
+mgetty (1.1.36-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Add arm64 to the list of 64-bit architectures.
+
+ -- Peter Michael Green <plugw...@debian.org>  Sun, 12 Oct 2014 02:09:38 +0000
+
 mgetty (1.1.36-2) unstable; urgency=medium
 
   * Don't ship folders within /var/run or /var/lock anymore. Closes: #689899
diff -u mgetty-1.1.36/debian/patches/00list mgetty-1.1.36/debian/patches/00list
--- mgetty-1.1.36/debian/patches/00list
+++ mgetty-1.1.36/debian/patches/00list
@@ -29,0 +30 @@
+79-arm64
\ No newline at end of file
only in patch2:
unchanged:
--- mgetty-1.1.36.orig/debian/patches/79-arm64
+++ mgetty-1.1.36/debian/patches/79-arm64
@@ -0,0 +1,19 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 79-arm64.dpatch by  <plugw...@debian.org>
+## 
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: add aarch64 (reffered to in debian as arm64) to list of 64-bit 
architectures
+
+@DPATCH@
+diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' 
'--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' 
mgetty-1.1.36~/mgetty.h mgetty-1.1.36/mgetty.h
+--- mgetty-1.1.36~/mgetty.h    2014-10-12 02:02:38.000000000 +0000
++++ mgetty-1.1.36/mgetty.h     2014-10-12 02:06:46.000000000 +0000
+@@ -198,7 +198,7 @@
+  */
+ #if defined(__alpha__) || defined(__sparc64__) || \
+           defined(__ia64__) || defined(__s390x__) || defined(__x86_64__) || \
+-          defined(__powerpc64__)
++          defined(__powerpc64__) || defined (__aarch64__)
+ # define PTR_IS_LONG
+ #endif
+ 

Reply via email to