Thanks from me as well. It seems that your patch is more sophisticated than my upstream fix (which essentially just switches the scripts shebang to /bin/bash). Please let me know if you want me to deploy your patch instead.
Best, Torsten On Dec 15, 2014 6:36 AM, "Yaroslav Halchenko" <y...@debian.org> wrote: > thank you guys for helping with the cmtk package! And sorry for being > slow to respond/react > > Upstream also issued a patch to address bashisms, see it attached. > it seems that we are still at -1.2 in the archive so I could issue -2 > with this one or if you are at it already -- just go ahead with NMU and > I will absorb it later into VCS > (http://git.debian.org/?p=pkg-exppsy/cmtk.git) > > cheers > > On Sun, 14 Dec 2014, Adam D. Barratt wrote: > > > Control: reopen -1 > > > On Sun, 2014-12-14 at 21:48 +0000, Michael Gilbert wrote: > > > cmtk (3.2.2-1.1) unstable; urgency=medium > > > . > > > * Non-maintainer upload. > > > * Fix bashisms in shell scripts (closes: #772217). > > > Unfortunately the fixes are incorrect in some cases: > > > +- if [[ "${line}" =~ ^\} ]]; then > > ++ if [ "${line}" =~ ^\} ]; then > > > Even bash doesn't support =~ outside of its [[ extension. > > > Regards, > > > Adam > > > -- > Yaroslav O. Halchenko, Ph.D. > http://neuro.debian.net http://www.pymvpa.org http://www.fail2ban.org > Research Scientist, Psychological and Brain Sciences Dept. > Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755 > Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419 > WWW: http://www.linkedin.com/in/yarik >
