Hi! On Fri, Jul 24, 2015 at 12:22:56AM +0200, Adam Borowski wrote: > On Tue, Jul 21, 2015 at 10:50:23PM -0400, Michael Zahniser wrote: > > * Package name : endless-sky
I see you've just made a new release, 0.8.8-1. I reviewed it. Too bad, almost all points I described in my previous review are still there -- could you please address them? I'm almost a DD, waiting only for account creation. It seems this is done roughly monthly, so I expect to be able to be able to upload before the end of the year. Thus, if you won't find a sponsor before then, I'll do so. > I'm afraid it fails to build in sbuild, because the first alternative in > "libjpeg-turbo8-dev | libjpeg62-turbo-dev" is notexistant, and sbuild > ignores everything but the first, per the buildd policy. And sbuild is > what the autobuilders use... Please depend on "libjpeg-dev", either solely or as the first alternative. That's a metapackage that depends on the default libjpeg implementation, in Debian that's libjpeg62-turbo-dev, in Ubuntu libjpeg-turbo8-dev. > W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at > line 76) > W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at > line 82) > W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at > line 88) > W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at > line 165) > W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at > line 184) > W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at > line 189) > W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at > line 194) > W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at > line 199) > W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at > line 561) > W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at > line 875) > > This is because you use paragraphs like: > .---- > License: CC-BY-SA-3.0 > (creativecommons.org/licenses/by-sa/3.0) > Taken from Wikimedia commons. Cropped and edited. > `---- > You want instead: > .---- > License: CC-BY-SA-3.0 > Comment: Taken from Wikimedia commons. Cropped and edited. > `---- > as the definition of what "CC-BY-SA-3.0" means is already included. > Also, single-threaded build is _slow_. This may be fixed by using: > .---- > ifneq (,$(findstring parallel,$(DEB_BUILD_OPTIONS))) > PROCS=$(patsubst parallel=%,%,$(filter > parallel=%,$(DEB_BUILD_OPTIONS))) > SCONS_OPTIONS += -j$(PROCS) > endif > `---- > then changing scons invocations to $(SCONS) $(SCONS_OPTIONS) This one is not mandatory, but makes test builds of the package a lot faster. If you have a 6-way machine and set DEB_BUILD_OPTIONS=parallel=6 the build will be nearly that much faster. Meow! -- ⢎⣉⠂⠠⠤⡀⣄⠤⡀⠠⡅⠀⠤⡧⠄⡄⠀⡄⠀⠀⠀⠠⡅⠀⡠⠤⠄⠀⠀⠀⢴⠍⠀⡠⠤⡀⣄⠤⡀⠀⠀⠀⠤⡧⠄⣇⠤⡀⡠⠤⡀⠀⠀⠀⡄⠀⡄⡠⠤⡀⠠⠤⡀⡇⡠⠄⠀⠀⠀ ⠢⠤⠃⠪⠭⠇⠇⠀⠇⠀⠣⠀⠀⠣⠄⠨⠭⠃⠀⠀⠀⠀⠣⠀⠬⠭⠂⠀⠀⠀⠸⠀⠀⠣⠤⠃⠇⠀⠀⠀⠀⠀⠀⠣⠄⠇⠀⠇⠫⠭⠁⠀⠀⠀⠣⠣⠃⠫⠭⠁⠪⠭⠇⠏⠢⠄⠀⠄⠀ (https://github.com/kilobyte/braillefont for this hack)