On Tue, Dec 15, 2015 at 10:04:09AM +0100, Jérôme wrote:
> Hi.

Hi Jérôme!
Please note that nor me nor anybody else but the maintainer receive
emails from bug reports unless they have subscribed through the PTS or
to that specific bug.  So if you want to get the attention of somebody
in cases like this would be better if you keep the in Cc or such.

> To my knowledge, gbirthday is not worked on by anyone but myself.
> 
> The Debian package is maintained is Rolf Leggewie.

whatever, is always *great* when the upstream developer of a project
interacts in the Debian bug tracker!

> I'm clueless about Debian packaging, so I'm afraid I can't help with the
> python-support issue. I've paid a look at the wiki page about the
> migration to see if I could help, but that's too many new concepts to
> grasp.

Yeah, this bug is mostly about deprecating a debian tool (pysupport) in
favour of another (dh-python, or better, dh_python2 in this case).

I uploaded dozens of packages in the last 4 days removing it, but I'm
stuck at gbirthday because it insists at installing images in sitelib,
which used to be /usr/share/pyshared/gbirthday/ with pysupport, but now
we're migrating off that directory and going to
/usr/lib/python2.7/dist-packages, where images are not really welcome.

So, given that this is actually an application and not a python module
or such.

To do so, I'd like to upload what I attached as debdiff.
In particoular I'm adding a patch to let it load from
/usr/share/gbirthday.  Happens that the program doesn't load here, no UI
appears; since this is the same behaviour I have with the package
already in the archive that's not a regression, but given that uploading
such untested changes would be too bad, I'd like to ask you what do you
think of the patch attached as 'patch'.

> For the record, gbirthday has moved to GitHub:
> https://github.com/Jerome-github/gbirthday/. I should update the watch
> file (this seems feasible to me, but there is no need to do it as long
> as there is no new release).

I would update it, but I don't know which kind of filenames you'll use,
since there is no release already made there.

[...]
> - Unless somebody comes in, gbirthday won't evolve as it is and will
> probably be out of Stretch or the next Debian release due to
> dependencies deprecation. I'm happy if I'm wrong.

Not with *this* deprecation ;)

> - I hope to get a Qt version packageable for Stretch. Help welcome, of
> course.

Stretch will still release with python2, even if we definitely would
like to remove it for buster.



-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  http://mapreri.org                              : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
diffstat for gbirthday-0.6.7 gbirthday-0.6.7

 changelog                           |   15 +++++++++++++++
 compat                              |    2 +-
 control                             |   24 ++++++++++++++++--------
 copyright                           |    6 +++---
 patches/load-from-private-dir.patch |   22 ++++++++++++++++++++++
 patches/series                      |    1 +
 rules                               |    4 ++--
 7 files changed, 60 insertions(+), 14 deletions(-)

diff -Nru gbirthday-0.6.7/debian/changelog gbirthday-0.6.7/debian/changelog
--- gbirthday-0.6.7/debian/changelog    2014-06-19 09:21:13.000000000 +0000
+++ gbirthday-0.6.7/debian/changelog    2015-12-15 13:22:30.000000000 +0000
@@ -1,3 +1,18 @@
+gbirthday (0.6.7-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Bump Standards-Version to 3.9.6: no changes needed.
+  * Run wrap-and-sort.
+  * Canonicalize Vcs-* fields.
+  * Bump debhelper compat level to 9.
+  * Stop recommending python-evolution.  Closes: #707843
+  * Add a patch to allow gbirthday load from /usr/share/gbirthday if needed.
+  * Build using dh-python instead of python-support.  Closes: #786165.
+    Also, move all the files to the private location /usr/share/gbirthday, 
since
+    this is an application.
+
+ -- Mattia Rizzolo <mat...@debian.org>  Tue, 15 Dec 2015 12:58:11 +0000
+
 gbirthday (0.6.7-1) unstable; urgency=low
 
   * new upstream release 0.6.7
diff -Nru gbirthday-0.6.7/debian/compat gbirthday-0.6.7/debian/compat
--- gbirthday-0.6.7/debian/compat       2014-06-19 09:10:22.000000000 +0000
+++ gbirthday-0.6.7/debian/compat       2015-12-15 12:56:59.000000000 +0000
@@ -1 +1 @@
-7
+9
diff -Nru gbirthday-0.6.7/debian/control gbirthday-0.6.7/debian/control
--- gbirthday-0.6.7/debian/control      2014-06-19 09:10:22.000000000 +0000
+++ gbirthday-0.6.7/debian/control      2015-12-15 13:16:25.000000000 +0000
@@ -2,19 +2,27 @@
 Section: gnome
 Priority: extra
 Maintainer: Rolf Leggewie <f...@rolf.leggewie.biz>
-Build-Depends: debhelper (>= 7.0.50~), python-nose, python-support, 
python-coverage, python-gtk2, intltool
+Build-Depends: debhelper (>= 9),
+               dh-python,
+               intltool,
+               python,
+               python-coverage,
+               python-gtk2,
+               python-nose
 X-Python-Version: >= 2.6
-Standards-Version: 3.9.5
+Standards-Version: 3.9.6
 Homepage: http://gbirthday.sf.net/
-Vcs-Browser: http://git.debian.org/?p=collab-maint/gbirthday.git
-Vcs-Git: git://git.debian.org/collab-maint/gbirthday.git
-
+Vcs-Browser: https://anonscm.debian.org/cgit/collab-maint/gbirthday.git
+Vcs-Git: git://anonscm.debian.org/collab-maint/gbirthday.git
 
 Package: gbirthday
 Architecture: all
-Depends: ${shlibs:Depends}, ${misc:Depends}, python,
- python-gtk2 (>= 2.10), ${python:Depends}
-Recommends: python-evolution, evolution-data-server
+Depends: python,
+         python-gtk2 (>= 2.10),
+         ${misc:Depends},
+         ${python:Depends},
+         ${shlibs:Depends}
+Recommends: evolution-data-server
 Description: birthday reminder applet
  GBirthday is an applet to help you remember your friends' and contacts'
  birthdays.  It uses the notifcation area for alerts.  Data can be stored
diff -Nru gbirthday-0.6.7/debian/copyright gbirthday-0.6.7/debian/copyright
--- gbirthday-0.6.7/debian/copyright    2014-06-19 09:07:29.000000000 +0000
+++ gbirthday-0.6.7/debian/copyright    2015-12-15 12:56:59.000000000 +0000
@@ -8,7 +8,7 @@
     Alex Mallo <derna...@gmail.com>
     Thomas Spura and Andres Bresser
 
-Copyright: 
+Copyright:
 
     Copyright © 2007 Alex Mallo
     Copyright © 2009 Thomas Spura
@@ -19,12 +19,12 @@
     This package is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation.
- 
+
     This package is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
- 
+
     You should have received a copy of the GNU General Public License
     along with this package; if not, write to the Free Software
     Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
diff -Nru gbirthday-0.6.7/debian/patches/load-from-private-dir.patch 
gbirthday-0.6.7/debian/patches/load-from-private-dir.patch
--- gbirthday-0.6.7/debian/patches/load-from-private-dir.patch  1970-01-01 
00:00:00.000000000 +0000
+++ gbirthday-0.6.7/debian/patches/load-from-private-dir.patch  2015-12-15 
13:16:06.000000000 +0000
@@ -0,0 +1,22 @@
+Description: We install gbirthday in a private location in /usr/share/gbirthday
+ let's make the launcher cope with this
+Author: Mattia Rizzolo <mat...@debian.org>
+Last-Update: 2015-12-15
+Forwarded: no
+
+--- a/src/gb
++++ b/src/gb
+@@ -1,4 +1,12 @@
+ #!/usr/bin/python
+ '''import main function from gbirthday and execute it'''
+-from gbirthday import main
++try:
++    from gbirthday import main
++except ImportError:
++    # maybe it's installed in a private location
++    import os, sys
++    usr_share_path = os.path.join('/', 'usr', 'share', 'gbirthday')
++    if os.path.exists(usr_share_path):
++        sys.path.insert(0, usr_share_path)
++        from gbirthday import main
+ main()
diff -Nru gbirthday-0.6.7/debian/patches/series 
gbirthday-0.6.7/debian/patches/series
--- gbirthday-0.6.7/debian/patches/series       2014-06-16 22:41:21.000000000 
+0000
+++ gbirthday-0.6.7/debian/patches/series       2015-12-15 13:12:00.000000000 
+0000
@@ -1 +1,2 @@
 01_deactivate-nosetests.patch
+load-from-private-dir.patch
diff -Nru gbirthday-0.6.7/debian/rules gbirthday-0.6.7/debian/rules
--- gbirthday-0.6.7/debian/rules        2014-06-16 22:41:21.000000000 +0000
+++ gbirthday-0.6.7/debian/rules        2015-12-15 13:04:55.000000000 +0000
@@ -1,6 +1,6 @@
 #!/usr/bin/make -f
 %:
-       dh $@
+       dh $@ --with python2
 
 override_dh_auto_install:
-       dh_auto_install -- sitelib=/usr/share/pyshared
+       dh_auto_install -- sitelib=/usr/share/gbirthday
Description: We install gbirthday in a private location in /usr/share/gbirthday
 let's make the launcher cope with this
Author: Mattia Rizzolo <mat...@debian.org>
Last-Update: 2015-12-15
Forwarded: no

--- a/src/gb
+++ b/src/gb
@@ -1,4 +1,12 @@
 #!/usr/bin/python
 '''import main function from gbirthday and execute it'''
-from gbirthday import main
+try:
+    from gbirthday import main
+except ImportError:
+    # maybe it's installed in a private location
+    import os, sys
+    usr_share_path = os.path.join('/', 'usr', 'share', 'gbirthday')
+    if os.path.exists(usr_share_path):
+        sys.path.insert(0, usr_share_path)
+        from gbirthday import main
 main()

Attachment: signature.asc
Description: PGP signature

Reply via email to