Control: tag -1 + pending
Hi Daniel,
Daniel Reichelt wrote:
> when --nopygrub is passed to xen-create-image, the hooks called during
> installation act as if --pygrub were passed.
>
> This setting gets exported to the hooks' environments as pygrub=0|1. The hooks
> however do a check like
>
> `if [ ${pygrub} ]; then`
>
> which in sh/bash always yields true (non-empty string). This only works if
> $pygrub were set to literal "true"|"false".
Thanks for the detailed bug report…
> The attached patch changes these
> checks to
>
> `if [ "${pygrub}" = "1" ]; then`
>
> The patch applies cleanly to both jessie an stretch verions of the xen-tools
> package.
… and the patch!
Applied upstream
(https://github.com/xen-tools/xen-tools/commit/ef096628225bd8b2ef6a8c18fd4743f5fdbfe8f6)
and will be part of the (soon to be uploaded) next upstream release.
Regards, Axel
--
,''`. | Axel Beckert <a...@debian.org>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
