On 2017-02-05 23:46:07 [+0100], John Paul Adrian Glaubitz wrote:
> Hi Sebastian!
Hi Adrian,

> However, I'm afraid your patch currently has no chance to get merged into
> the Debian package as it involves too many changes and will therefore
> rejected by the release team for Debian Stretch.

as per #854412 it got unblocked. Any reason not to upload it as-is?

> Also, your patch contains unrelated changes to the formatting like:
> 
> @@ -421,23 +394,23 @@
>      # MiNT.  But MiNT is downward compatible to TOS, so this should
>      # be no problem.
>      atarist[e]:*MiNT:*:* | atarist[e]:*mint:*:* | atarist[e]:*TOS:*:*)
> -     echo m68k-atari-mint${UNAME_RELEASE}
> +        echo m68k-atari-mint${UNAME_RELEASE}
>       exit ;;
>      atari*:*MiNT:*:* | atari*:*mint:*:* | atarist[e]:*TOS:*:*)
>       echo m68k-atari-mint${UNAME_RELEASE}
> -     exit ;;
> +        exit ;;
> 
> These changes should be removed, so that your patch contains actual
> functional changes only. I also recommend splitting your patch up
> into smaller, logical chunks.

now I understand what you mean. Earlier, while reading it, I though you
were asking to get them removed because I introduced them. Now I
understand what you emant.

> If upstream is dead, I'd suggest put your changes in a repo on github
> and point the Homepage field of the Debian package to that repo.
I am not sure whether or not upstream is dead. I would like to get as
little involved in this as possible and just fix what stops it getting
into testing. Changing the homepage field + creating a github repo looks
somehow like asking to become the maintainer.

> Adrian

Sebastian

Reply via email to