tag 843038 +patch
thanks

Hello,
Either of these two patches will fix this for now and is fine with me.

A nicer patch would be to replace all lines matching
@Test(timeout
with
//@Test(timeout
to disable only those tests that rely on a timeout (i.e. that will fail on
a too slow CPU).

These tests are very unlikely to detect build errors; but they are
regression tests to detect if someone replaces the sorting code with a
version that degrades to O(n^2) runtime on certain corner cases (e.g. all
identical).
Maybe they could eventually be replaced with a test that uses introspection
and counters rather than a timeout, but that requires much more work.

So for now, I would simply disable either all tests, or the problematic
timeout-based tests.

Regards,
Erich


On Wed, Mar 8, 2017 at 7:53 PM, Santiago Vila <sanv...@unex.es> wrote:

> On Wed, Mar 08, 2017 at 06:13:34PM +0100, Erich Schubert wrote:
>
> > Or you just add* e.g. the -*Dmaven.test.skip=true parameter, and it will
> > build fine.
>
> You probably mean the first attached patch.
>
> I've tested that and it still run tests (not sure if all of them or
> only some of them).
>
> The second attached patch seems to disable all the tests.
>
> If this is how you would really fix this FTBFS bug, please say so
> or better tag this bug as "patch".
>
> Thanks.
>

Reply via email to