Dear Lumin,
many thanks for reviewing the package! Please find my comments in-line.
On 04/23/2018 10:35 AM, Lumin wrote:
> 1. There seems to be ruby binding available, why isn't it packaged?
I have too little experience with Ruby. However, I will look at how to package
it.
> 2. control: Your -dev package should also depend on the lib package.
> Depends: ${misc:Depends}, libsymspg1 (= ${binary:Version})
Fixed.
> The python package should depend on it too.
Is it really so? As I understand, all objects are linked in Python SO file and
it alone is sufficient to use the Python binding. At least all Python tests
pass having python3-spglib installed only.
> 3. libsymspg1.install :
Done.
> Apart from that, this looks a bit weird:
> DEBIAN/symbols DEBIAN
Fixed.
> 4. the install file of -dev package could be simplified
Done.
> 5. I'd suggest you install the library in the multiarch directory.
> for example /usr/lib/$(dpkg-architecture -qDEB_HOST_MULTIARCH)
Done.
> 6. tests: your autopkgtest testsuite failed:
I will look into this. It is possible that I invoke the Python tests
incorrectly.
Thanks again!
Andrius
--
Andrius Merkys
Vilnius University Institute of Biotechnology, Saulėtekio al. 7, room V325
LT-10257 Vilnius, Lithuania
