Package: sakura
Version: 3.6.0-1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu cosmic ubuntu-patch

Dear Andrew,

The sakura package is failing to build in Ubuntu because it requires pcre2.h
but does not build-depend on libpcre2-dev:

  make[3]: Leaving directory '/<<PKGBUILDDIR>>'
  [ 50%] Built target translations
  /<<PKGBUILDDIR>>/src/sakura.c:253:10: fatal error: pcre2.h: No such file or 
directory
   #include <pcre2.h>
            ^~~~~~~~~
  compilation terminated.
  make[3]: *** [CMakeFiles/sakura.dir/build.make:66: 
CMakeFiles/sakura.dir/src/sakura.o] Error 1

https://launchpad.net/ubuntu/+source/sakura/3.6.0-1/+build/14836077

This appears to not be an issue in Debian because something else is already
pulling libpcre2-dev into the build environment as an indirect dependency. 
(The main difference for Ubuntu is that Ubuntu has not yet adopted pcre2 in
main).  However, since sakura requires this header directly, it would be
best to explicitly build-depend on it.

Thanks for considering the attached patch.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org
diff -Nru sakura-3.6.0/debian/control sakura-3.6.0/debian/control
--- sakura-3.6.0/debian/control 2018-05-02 15:10:07.000000000 -0700
+++ sakura-3.6.0/debian/control 2018-08-22 12:57:12.000000000 -0700
@@ -6,6 +6,7 @@
 Build-Depends: cmake,
                debhelper (>= 11),
                libgtk-3-dev,
+               libpcre2-dev,
                libvte-2.91-dev,
                perl
 Standards-Version: 4.0.0

Reply via email to