Hi,
On Wed, 21 Nov 2018, Xavier wrote:
> Sorry, I found a SALSA_TEAM in your conf file. For clarity, SALSA_TEAM
> has been replaced by SALSA_GROUP (same for all team commands/options
> replaced by *group*).
Working much better with SALSA_GROUP ;) But then I got this:
wapiti:
bad irc channel: #debian-pkg-security
It was really not clear what was wrong. But it seems that you expect:
SALSA_IRC_CHANNEL=debian-pkg-security
And not the value that I had put initially:
SALSA_IRC_CHANNEL=#debian-pkg-security
It seems strange to require to strip the leading hash. I would rather
be more user-friendly: add the leading hash if it's missing, but otherwise
assume that the value is the full name (some channels can start with two
leading hashes). Also the documentation should be clear on this.
Another detail I noticed, the values of SALSA_EMAIL_RECIPIENTS should benefit
from the same substitution as SALSA_DESC_PATTERN so that we can include the
name of the repo in the generated email addresses.
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/
