Paul Gevers wrote:
> https://ci.debian.net/data/autopkgtest/testing/amd64/g/git-remote-hg/1428119/log.gz
>
> not ok 32 - pull tags
The package ought to run "make TEST_OPTS=-v" to produce a more useful
log[*].
Bisects to the following Git change:
e198b3a740409fabe5ba774c5f1255b55fdd21c1 is the first bad commit
commit e198b3a740409fabe5ba774c5f1255b55fdd21c1
Author: Junio C Hamano <gits...@pobox.com>
Date: Tue Sep 25 13:25:04 2018 -0700
fetch: replace string-list used as a look-up table with a hashmap
In find_non_local_tags() helper function (used to implement the
"follow tags"), we use string_list_has_string() on two string lists
as a way to see if a refname has already been processed, etc.
All this code predates more modern in-core lookup API like hashmap;
replace them with two hashmaps and one string list---the hashmaps
are used for look-ups and the string list is to keep the order of
items in the returned result stable (which is the only single thing
hashmap does worse than lookups on string-list).
Similarly, get_ref_map() uses another string-list as a look-up table
for existing refs. Replace it with a hashmap.
Signed-off-by: Junio C Hamano <gits...@pobox.com>
[*]
expecting success:
test_when_finished "rm -rf hgrepo gitrepo" &&
(
hg init hgrepo &&
cd hgrepo &&
echo one > content &&
hg add content &&
hg commit -m one
) &&
git clone "hg::hgrepo" gitrepo &&
(cd hgrepo && hg tag v1.0) &&
(cd gitrepo && git pull) &&
echo "v1.0" > expected &&
git --git-dir=gitrepo/.git tag > actual &&
test_cmp expected actual
Cloning into 'gitrepo'...
WARNING: capability_push is disabled, only do so when really sure
WARNING: various enhanced features might fail in subtle ways
requesting all changes
adding changesets
adding manifests
adding file changes
added 1 changesets with 1 changes to 1 files
new changesets 50e85c807eb0
progress revision walk 'bookmarks/master' (0/0)
progress revision 0 'master' (0/1)
WARNING: capability_push is disabled, only do so when really sure
WARNING: various enhanced features might fail in subtle ways
searching for changes
adding changesets
adding manifests
adding file changes
added 1 changesets with 1 changes to 1 files
new changesets ff570a4c8fa2
progress revision 1 'default' (0/1)
>From hg::/src/git-remote-hg/test/trash directory.main/tmp/hgrepo
5ac88dd..82ef3dd master -> origin/master
5ac88dd..82ef3dd branches/default -> origin/branches/default
Updating 5ac88dd..82ef3dd
Fast-forward
.hgtags | 1 +
1 file changed, 1 insertion(+)
create mode 100644 .hgtags
--- expected 2018-12-05 06:36:57.995012275 +0000
+++ actual 2018-12-05 06:36:57.995012275 +0000
@@ -1 +0,0 @@
-v1.0
not ok 32 - pull tags
