Hi, You're giving the tests the wrong input filename - that is a bug in pcapfix (the tests weren't updated for the .pcap move).
The second thing is that returning 254 on errors breaks autopkgtest, so
it would be good if you could change exit codes 128 < code < 255 into
one below 128. That's arguably an autopkgtest bug, so you might not want
to fix it, but if you do it will help the testers.
Cheers,
Iain
On Wed, Jan 30, 2019 at 07:06:47PM +0100, Robert Krause wrote:
> Hi Iain,
>
> thank you for this bug report.
>
> Did I get it right that is a bug in the tool (pcapfix) itself and not the
> testing process?
>
> I am a bit confused, since I did not change any return codes since version
> 1.1.4.
> Nevertheless it is correct, that pcapfix returns negative numbers in case of
> errors.
> I can fix this and turn them positive if this will make autopkgtest work
> again.
>
> Is "no such file" also a bug of pcapfix or is it the test case. I checked
> file opening function and process and it works on my system.
>
> Thanks in advance.
>
> Cheers,
> Robert
>
> On 2019-01-30 18:48, Iain Lane wrote:
> > Package: src:pcapfix
> > Version: 1.1.4-1
> > Severity: normal
> >
> > Hi,
> >
> > Removing autopkgtest-satdep (0) ...
> > autopkgtest [15:14:06]: test command1: pcapfix
> > debian/test/test_2018.pcap
> > autopkgtest [15:14:06]: test command1: [-----------------------
> > [-] Cannot open input file: No such file or directory
> > pcapfix 1.1.4 (c) 2012-2019 Robert Krause
> >
> > [*] Reading from file: debian/test/test_2018.pcap
> > autopkgtest [15:14:07]: ERROR: testbed failure: testbed auxverb
> > failed with exit code 254
> >
> > The path to the .pcap file is wrong since 1.1.4-1.
> >
> > In addition, the last line shows that the exit status of the test
> > command is making autopkgtest think that *it* failed rather than the
> > test command. It only supports exit 0-125 - is there any chance you
> > could chop off any larger exit codes please? In a script, something like
> > (untested)
> >
> > #!/bin/sh
> > pcapfix ...; RC=$?
> > if [ "${RC}" -gt 125 ]; then
> > RC=125
> > fi
> > exit ${RC}
> >
> > (The closest bit of documentation I can find for this is in [0]:
> >
> > program's exit status will be that of the testbed command if the
> > latter exits with a value from 0..125.
> >
> > ...
> >
> > If program fails it will exit 254 or 255
> >
> > Where "program" is not the test program: it is an autopkgtest-internal
> > program to execute a given command inside the testbed.)
> >
> > Thanks!
--
Iain Lane [ i...@orangesquash.org.uk ]
Debian Developer [ la...@debian.org ]
Ubuntu Developer [ la...@ubuntu.com ]
signature.asc
Description: PGP signature
