On 04/03/2019 13:53, Andrej Shadura wrote: > On 04/03/2019 13:40, Matthias Klose wrote: >> On 04.03.19 13:29, Andrej Shadura wrote: >>> On Tue, 29 Jan 2019 10:21:02 +0100 Andrej Shadura >>> <andrew.shad...@collabora.co.uk> wrote: >>>> Hi, >>>> >>>> The same issue as #861183 is found in binutils, when built with OBS, it >>>> generates files inside the tarball looking like this: >>>> >>>> -rw-r--r-- root/root 959 2018-06-24 20:38 BUILD/bfd/aout32.c >>>> -rw-r--r-- root/root 1097 2018-06-24 20:38 BUILD/bfd/aout64.c >>>> -rw-r--r-- root/root 166798 2018-06-24 20:38 BUILD/bfd/aoutx.h >>>> -rw-r--r-- root/root 14034 2018-12-14 20:22 BUILD/bfd/arc-got.h >>>> -rw-r--r-- root/root 3973 2018-06-24 20:38 BUILD/bfd/arc-plt.def >>>> -rw-r--r-- root/root 4665 2018-06-24 20:38 BUILD/bfd/arc-plt.h >>>> >>>> Arguably this is something OBS could have changed, but one can run into >>>> this issue by just building the package locally in a directory not >>>> matching what dpkg-source creates. >>>> >>>> Anyway, I hope the attached patch solves the issue. I’m currently >>>> testing it building binutils and binutils-mingw64; I will post the >>>> update as I confirm it indeed fixes the issue. >>> >>> Matthias, have you had time to have a look at this? I know this is a low >>> priority thing, but nevertheless it’d be cool to know what you think. >> >> No, afraid that this will break the current cross-toolchain-base* packages. >> Did >> you test build these? > > It shouldn’t break them as what the patch does is replaces whatever > directory name the package was unpacked into with what dpkg-source > --extract does by default, i.e. it makes things more unified at large > and in substandard situations but does not changes the paths in the > default configuration. > > In fact, with this patch applied the contents on the binutils-source > package built in our OBS is the same as the contents of the package > built at Debian buildds, which wasn’t like that before.
E.g. this is how files are named in binutils-2.31.1.tar.xz from 2.31.1-11 with my patch: -rw-r--r-- root/root 18002 2018-06-24 20:38 binutils-2.31.1/COPYING -rw-r--r-- root/root 1719 2018-06-24 20:38 binutils-2.31.1/README This is binutils-2.32.tar.xz from 2.32-4: -rw-r--r-- root/root 18002 2019-01-19 17:01 binutils-2.32/COPYING -rw-r--r-- root/root 1719 2019-01-19 17:01 binutils-2.32/README -- Cheers, Andrej
