Hello, On Mon 15 Jul 2019 at 02:33AM +01, Ian Jackson wrote:
> Package: dgit-infrastructure > Version: 9.2 > > git-debpush > - sends upstream commitish and tag info > whenever processing a non-native package. > > The tag2upload bot > - runs git-deborig iff upstream info was provided; > this should cause a .orig to exist > - passes --upstream... to dgit iff --quilt=baredebian (only) > (subject to the bug I have just filed) > dgit > - always checks that the orig (if there is one) is treesame enough > - uses upstream git history iff --quilt=baredebian > > So this means that in the non-baredebian non-native case, nothing > checks that the supplied git tag is an ancestor of the maintainer > history. > > I think the supplied git tag should be an ancestor of the maintainer > history except with --quilt=baredebian. Is this a thing that should > be checked ? I am not yet convinced that this is something which should be checked. What is the benefit of avoiding uploads where the upstream git tag is not, for whatever reason, an ancestor of the commit to be uploaded? If the upstream tag provided does not actually correspond to the upstream source, dgit will detect that already. Whether that tag is an ancestor or not does not seem relevant. There may well be a git workflow someone uses where they have an upstream tag, but they update their packaging branch by some means other than merging that tag. This change would make git-debpush/tag2upload not usable by them. And I do not see why we would want to do that. -- Sean Whitton
signature.asc
Description: PGP signature
