Hello, On Mon 15 Jul 2019 at 09:19AM +01, Sean Whitton wrote:
> I am not yet convinced that this is something which should be checked. > > What is the benefit of avoiding uploads where the upstream git tag is > not, for whatever reason, an ancestor of the commit to be uploaded? > > If the upstream tag provided does not actually correspond to the > upstream source, dgit will detect that already. Whether that tag is an > ancestor or not does not seem relevant. > > There may well be a git workflow someone uses where they have an > upstream tag, but they update their packaging branch by some means other > than merging that tag. This change would make git-debpush/tag2upload > not usable by them. And I do not see why we would want to do that. An alternative is to implement this as one of git-debpush's skippable sanity checks. It's very easy using `git branch --merged` or `git branch --contains` (I'm not quite sure which right now). Would that satisfy your objectives here? -- Sean Whitton
signature.asc
Description: PGP signature
