Am 13.01.20 um 03:56 schrieb Asher Gordon: > Package: berusky2 > Version: 0.10+git20170630-3 > Severity: normal > Tags: patch > > Dear Maintainer, > > Currently when Berusky2 is compiled it generates a *lot* of compile > warnings, some of which seem serious. I've fixed all these warnings and > have attached a patch (I've attached it as an attachment rather than > inline because it is quite large (3651 lines) and I don't want to > clutter up the bug report log). > > I've set the severity to "normal" since there are so many warnings and I > suspect that my patch may fix some crashes. But feel free to downgrade > as you see fit.
Hello, thanks for the report. Have you considered to forward these patches upstream and help upstream to implement them? I'm asking because a lot of users won't benefit from bug fixes if they are only fixed in Debian. > Since Berusky2 now compiles without warnings, I recommend adding -Werror > to the C{,XX}FLAGS. I guess this would be done by adding it to > DEB_CXXFLAGS_MAINT_APPEND (like you did in 89e7190) and > DEB_CFLAGS_MAINT_APPEND. I think -Werror is never a good idea for Debian packages. Even minor warnings would cause a build failure. Ideally -Werror is used in development to detect and fix warnings but not in production. Again this is something to consider for upstream. > I tested running Berusky2 periodically while writing the patch to make > sure that I didn't introduce any bugs. I also tested it after I finished > writing the patch. But I did not test very thoroughly (I just started it > and made a few moves in a level). However, the only part that seems > likely to introduce new bugs is the replacement of the deprecated ALUT > functions, and sound still works fine. So I'm pretty sure I didn't > introduce any new bugs. > > I have attached the patch after the message. I would feel more comfortable if upstream included and reviewed the patch. It may take a while to find the time to review it myself. Regards, Markus
signature.asc
Description: OpenPGP digital signature