Hello Markus and Bernhard, Markus Koschany <a...@debian.org> writes:
> Am 13.01.20 um 22:26 schrieb Bernhard Übelacker: >> Hello Asher, >> maybe you want to incorporate the changes given here: >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944431#31 >> Unfortunately I was too late there. >> >> Then the call to e.g. SetThreadPriority would not needed to get >> commented out, and the "-O0" fix in #944431 could be removed >> again, I guess. > > I had incorporated and applied your patch and removed the -O0 fix again. > I haven't checked though how all this is related to Asher's patch. As Markus says, he's already added Bernhard's fixes. I've written my patch on top of those fixes. Markus Koschany <a...@debian.org> writes: > thanks for the report. Have you considered to forward these patches > upstream and help upstream to implement them? I'm asking because a lot > of users won't benefit from bug fixes if they are only fixed in Debian. I've forked the upstream repository here[1] (because I don't want to use GitHub) and I've sent Martin Stransky an email to let him know. In my repository, I've added Markus's patch for GCC 6 and Bernhard's patch for the 'no return statement in function returning non-void' warning as well as my patches. I've added both of these as separate commits where I've credited you in the commit message. But if you like, I can change the Author to your name instead. Hopefully, these will be accepted upstream and we will be able to drop all patches except the Debian-specific ones (data.patch and docs.patch). Asher Footnotes: [1] https://notabug.org/AsDaGo/berusky2 -- If at first you don't succeed, redefine success. GPG fingerprint: 38F3 975C D173 4037 B397 8095 D4C9 C4FC 5460 8E68
signature.asc
Description: PGP signature