-=| gregor herrmann, 19.03.2020 11:34:19 +0100 |=-
> The merge request exists, thanks Iain!
> 
> https://salsa.debian.org/kgb-team/kgb/-/merge_requests/7
> 
> To me it looks good, and I especially appreciate the added tests.
> Iain, I guess you tested the changes also with a test installation,
> as discussed on IRC?
> 
> Dam, I hope you have a moment to look at the changes as well.

Looks good to me.

This:

-  ... not grep { ... } @{...}
+  ... not any  {     } @{...}

is a nice catch :)

The only things missing for me are:

 * addition of Iain in the copyright notices and debian/copyright
 * addition of the new (build) dependencies to Build.PL

But I guess these can be made at release time as well.


-- dam

Reply via email to