On Thu, 19 Mar 2020 10:44:06 +0000, Iain Lane wrote: > > > So, please, Iain, send that merge request. Thanks! > > The merge request exists, thanks Iain! > > https://salsa.debian.org/kgb-team/kgb/-/merge_requests/7 > Ah yeah, I should have updated the bug.
No worries. > > To me it looks good, and I especially appreciate the added tests. > > Iain, I guess you tested the changes also with a test installation, > > as discussed on IRC? > I did, yes - and it seems to work as designed. Thanks for the initial > review! Great, thanks for the real-life tests. > Hopefully once this is merged the "production" instances can be updated > to use it? Then I can fix pkg-gnome's webhooks to not spam #debian-gnome > :-). Right, that would indeed make a lot sense :) On Thu, 19 Mar 2020 15:26:17 +0200, Damyan Ivanov wrote: > > Dam, I hope you have a moment to look at the changes as well. > Looks good to me. Thanks! > The only things missing for me are: > > * addition of Iain in the copyright notices and debian/copyright > * addition of the new (build) dependencies to Build.PL > > But I guess these can be made at release time as well. Alright, I merged the patch, updated the copyright notices and Build.PL and did a round of packaging polishing. Dam, could you take another look and maybe release the thing (or I can do it as well if you don't have time)? Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Don McLean: He's Got You
signature.asc
Description: Digital Signature
