Hi Nikos, Сб 30 мая 2020 @ 13:34 Nikos Tsipinakis <ni...@tsipinakis.com>:
> On 26/05, Lev Lamberov wrote: >> Then you could compare your packages and somehow merge them, taking best >> pieces. > > I took a look at that package and cherry-picked some improvements from there, > also added Fritz to d/copyright. I think it's ready to be uploaded now, I've > put it on mentors[1]. > > Upstream symlinks compton to picom and also installs a compton.desktop file, > so > rather than override that I opted to set a Conflict/Replaces for compton. > > [1] https://mentors.debian.net/debian/pool/main/p/picom/picom_8-1.dsc Good. Could you update your Salsa repository too? Your d/watch needs some tweaks, because currently it detects 7.5 as the latest upstream version, where there is 8 (which you package). I'd recommend using pristine-tar. And I have a question. Why don't you import upstream versions as archives and not use upstream branch to track upstream master? The latter could make cherry-picking patches much more easy. There are some lintian stuff to deal with: lintian -L ">=pedantic" ../*.changes W: picom: binary-without-manpage usr/bin/compton W: picom: binary-without-manpage usr/bin/compton-trans I: picom: desktop-entry-lacks-icon-entry usr/share/applications/picom.desktop I: picom: spelling-error-in-binary usr/bin/picom everytime every time I: picom: spelling-error-in-manpage usr/share/man/man1/picom.1.gz everytime every time I: picom source: testsuite-autopkgtest-missing P: picom source: file-contains-trailing-whitespace debian/control (line 50) P: picom source: package-uses-old-debhelper-compat-version 12 P: picom source: rules-requires-root-missing At the very least, please, add the following changes: (1) migrate to debhelper-compat=13 (in d/control), (2) add Rules-Requires-Root: no (in d/control), (3) remove trailing whitespaces from d/*. Also, do we really need to have symlinks (compton and compton-trans) and corresponding desktop files? Since it is a new Debian package, probably we can drop these. What do you think? And I have not looked into d/copyright yet. Cheers! Lev
