Hi Lev,

On 31/05, Lev Lamberov wrote:
> Good. Could you update your Salsa repository too?

Whoops, forgot to push, updated with all the recent changes.

> Your d/watch needs some tweaks, because currently it detects 7.5 as the
> latest upstream version, where there is 8 (which you package).

Fixed.

> I'd recommend using pristine-tar.
>
> And I have a question. Why don't you import upstream versions as
> archives and not use upstream branch to track upstream master? The
> latter could make cherry-picking patches much more easy.

This reminds me of the discussion on d-devel about the myriad ways of using git
for debian patching. The disappointing answer is "that's the way I've done it
this far", however I haven't taken the time to explore all the different
workflows, which I do aim on doing soon.

> I: picom: spelling-error-in-binary usr/bin/picom everytime every time
> I: picom: spelling-error-in-manpage usr/share/man/man1/picom.1.gz everytime 
> every time

Fixed.

> P: picom source: file-contains-trailing-whitespace debian/control (line 50)
> P: picom source: package-uses-old-debhelper-compat-version 12
> P: picom source: rules-requires-root-missing

Fixed.

> Also, do we really need to have symlinks (compton and compton-trans)
> and corresponding desktop files? Since it is a new Debian package,
> probably we can drop these. What do you think?

You're right, for now they serve no purpose so I removed them. However, upstream
seems to have a full migration plan from compton[1] and it looks like they do
intend on keeping backwards compatibility to some degree. So, it might be worth
looking into the possibility of going through a migration to picom, given that
compton is unmaintained, and will inevitably bitrot.

[1] https://github.com/yshui/picom/#migration

- Nikos

Reply via email to