Am 07.10.20 um 13:47 schrieb Sergio Gelato:
> Commit a21b649 (first included in 1:77.0~b1-1) silently changed the
> spelling of lockPref to lock_pref .
Are you sure?
This commit is about modifying the patch queue. I don't see any changes
here regarding a switch of using lockPref over lock_pref.
> $ git show a21b649 --summary
> commit a21b6495154e02f772c44c95ce237c6e47e116f8
> Author: Carsten Schoenert <c.schoen...@t-online.de>
> Date: Thu May 7 18:28:34 2020 +0200
>
> rebuild patch queue from patch-queue branch
>
> removed patch:
> lower-down-required-version-on-NSS3.patch
>
> added patches:
> fixes/Bug-1634994-fix-disable-av1-r-tnikkel.patch
> fixes/Bug-1635671-Upgrade-typename-to-1.12.0.-r-emilio.patch
>
> create mode 100644
> debian/patches/fixes/Bug-1634994-fix-disable-av1-r-tnikkel.patch
> create mode 100644
> debian/patches/fixes/Bug-1635671-Upgrade-typename-to-1.12.0.-r-emilio.patch
> delete mode 100644 debian/patches/lower-down-required-version-on-NSS3.patch
...
> This breaking change doesn't seem to have been documented anywhere:
> not in debian/changelog, not in debian/thunderbird.NEWS.
If there was a change than this change was introduced by upstream not by
me or Debian. So how would we need to document such things that we even
don't know, if I'd be aware of such changes I for sure would have
documented it somehow.
> Moreover, it looks like parts of the test suite (e.g.,
> extensions/pref/autoconfig/test/unit/autoconfig-all.cfg) are still
> referencing the old spelling. Are these files being used?
I don't know, we don't do any usage of the upstream test suites. I guess
you'd need to ask these MZLNA.
The only change about handling of preferences I know of did happen
before 1:60.0-1.
> $ git show 90a1d9e
> commit 90a1d9eb61f1cf502ef55a7df38030e66c86cb4e
> Author: Carsten Schoenert <c.schoen...@t-online.de>
> Date: Wed Jul 11 22:00:36 2018 +0200
>
> sticky prefs: use the new syntax in vendor.js
>
> The syntax for locked preferences has been changed a while ago, it's
> time to adjust the entry within vendor.js to disable automatic updates
> for AddOns.
>
> diff --git a/debian/vendor.js b/debian/vendor.js
> index 15bcb62bfc8..1a5daea0a2b 100644
> --- a/debian/vendor.js
> +++ b/debian/vendor.js
> @@ -1,2 +1,2 @@
> // Forbid application updates
> -lockPref("app.update.enabled", false);
> +pref("app.update.enabled", false, locked);
...
> The most annoying implication of this change is that custom .js files
> must be updated at the same time as Thunderbird itself. It would have
> been more convenient if both spellings had been allowed during a
> transition period.
I've no real idea what your problem is about.
The syntax of /e/t/pref/thunderbird.js hasn't changed since it got
introduced, at this time it was called icedove.js of course.
So any other user specific file within that folder doesn't need adjustments.
The same is true for the other shipped files in
/usr/lib/thunderbird/defaults/pref/.
Sorry, as much I'd like to help, but some information is missing to give
some more useful feedback.
--
Regards
Carsten Schoenert
